Commit graph

64 commits

Author SHA1 Message Date
depfu[bot]
74c2551ed8
Update rubocop-rspec to version 2.23.0 2024-03-04 17:05:55 +01:00
Henne Vogelsang
ff52f02fa4
Introduces rubocop-performance 2023-05-08 13:53:15 +02:00
Henne Vogelsang
7b85b86e15
Introduces rubocop-capybara 2023-05-08 13:52:04 +02:00
Henne Vogelsang
76145f0874
Include rubocop-rails in configuration 2023-05-08 13:48:43 +02:00
depfu[bot]
8b9e4d1288
Update rubocop-rspec to version 2.4.0 2021-08-13 15:01:27 +02:00
Andrew Kvalheim
75d28b802f
Don't clobber RuboCop's default excludes
By default, adding an exclude (faffc49) has the effect of removing the
default excludes. Merge them as described in rubocop-hq/rubocop#6567.
2021-03-06 19:33:28 +01:00
Andrew Kvalheim
162e0f720f
Exclude Rails database schema from linting
The schema is automatically generated, so RuboCop's recommendations are
non-actionable; ignore it as in rubocop-hq/rubocop#752.
2021-03-06 19:33:28 +01:00
James Mason
299738f58d Explicitly define Rubocop hash style 2018-11-16 09:06:05 -08:00
James Mason
8b12b1662d Unlint Rspec/DescibeClass #BetterPlace 2018-11-06 08:19:01 -08:00
Henne Vogelsang
f866974b19 Enable FactoryBot/AttributeDefinedStatically
See https://robots.thoughtbot.com/deprecating-static-attributes-in-factory_bot-4-11
2018-09-08 04:29:22 +02:00
Henne Vogelsang
5fc867a8fc Introduces rubocop-rspec
Also regenerating the config. Most stuff in there didn't really make sense.
Time to go through .rubocop_todo.yml people :-)
2018-09-08 04:29:22 +02:00
James Mason
24396d35c2 Use Ruby safe navigation over Rails try
re: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/SafeNavigation
2018-06-01 09:15:57 -07:00
James Mason
d8bd269a64 Add frozen_string_literal magic comment
re: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/FrozenStringLiteralComment
2018-06-01 09:15:57 -07:00
James Mason
7f116ecda6 Enable rubocop Rails rules 2018-06-01 09:15:57 -07:00
James Mason
a68be76a15 Add rubocop TargetVersion; disable new cops 2018-06-01 09:15:57 -07:00
AEtherC0r3
7eea930269 Implement track scheduling
Add track association to schedule
Show schedules in admin sidebar to track organizers
Allow track organizers to manage the schedules of their tracks
Don't allow self-organized track events to be dragged or unscheduled in
a conference schedule
Make scheduled events of self-organized tracks appear semitransparent in
conference schedules
Make the rooms of confirmed self_organized tracks appear semitransparent
and don't allow events to be scheduled to it in the conference schedules
during the dates of its track
Create admin/SchedulesController#new action
Add a button in admin/Schedules#index to create schedules for tracks
Add self_organized scope to Track
Modify Schedules#show to handle track schedules and show a unified
schedule
Allow track organizers to create new schedules for their tracks
Correctly identify scheduled and unscheduled events in Schedules#events
Fix Event#room and Event#time for when the event is scheduled in a track
schedule
Modify Program#selected_event_schedules to include the event_schedules
of selected track schedules
Modify Track#revoke_role_and_cleanup to destroy the track's schedules
and revert its events' state to new
Add tabs for conference and track schedules in admin/Schedules#index
Add button to Create/Show a tracks schedule in Tracks#index and #show
Fix concurrent_events in application_helper because of changes in
Program#selected_event_schedules
Do not take into account cfp_active in Event#valid_track
Modify EventsController#get_tracks accordingly
Enforce cfp_active of track to be enabled for proposals in
ProposalsController#create and #update
Add support for multiple schedules per track
Add selected_schedule_id to Track
Load EventSchedules of selected track schedules for conference schedules
in admin/SchedulesController#show
Modify SchedulesController#show to take into account only the selected
track schedules
Create Event#selected_schedule_id and use it in Event#scheduled? and
Event#time
Validate that an EventSchedule for an event of a self-organized track
belongs to one of the track's schedules
Add 'Manage' button in Tracks#index, #show that sends you to the admin
side of things
Add admin/TracksController#update_selected_schedule to update the
selected_schedule_id of tracks
2017-08-26 00:31:44 +03:00
AEtherC0r3
68fc750e9f Implement track requests and add the track organizer role
About track requests:
Create migration that adds the fields submitter_id, state, and
cfp_active to Tracks
Add validations and the self_organized? method to the Track model
Create a new TracksController outide of the admin namespace
Create the relevant views for index, show, new and edit
Modify the admin views for tracks to include extra info for
self-organized tracks

About track organizers:
Create the role when a self-organized track is created
Define track organizer abilities
Modify the roles views and controller to handle the new role

The route for Roles#edit needs to have higher priority than the nested
routes for track roles, otherwise, the word edit in the url is matched
as a track with short_name edit
2017-07-14 12:38:53 +03:00
AEtherC0r3
f37d3095e1 Rework cfp abilities 2017-06-27 21:16:46 +03:00
Ana María Martínez Gómez
6469ea7da5 Remove default configuration from .rubocop.yml
We had part of the default Rubocop configuration in the `.rubocop.yml`
file. It is not needed as it is the default and it also don't make
sense, because we only have part of it.

That was caused because when enabling a cop we were moving it from
`.rubocop_todo.yml` to `.rubocop.yml`, but this is only needed if we
overwrite the default configuration.
2017-06-22 16:49:52 +02:00
Dimitris
d160c22a0b Enable rails/findEach Rubocop cop
This cop enforce the use of `find_each` instead of `each`.

Closes #1535
2017-06-20 10:46:04 +03:00
divyanshumehta
cdf794ecbf Add Style/SelfAssignment Rubocop cop
The cop enforces use of self assignment operator E.g. a=a+2 gets
written as a+=2. Also the offenses listed in rubocop.todo.yml
have been corrected automatically with the --auto-correct option.
Fixes issue #1531
2017-06-14 09:22:19 +05:30
divyanshumehta
0d01ed08b0 Added Style/SpaceInsideBrackets Rubocop cop 2017-06-11 22:57:52 +05:30
nasia
6cb11ff2f3 Add Style/WordArray at rubocop.yml #1463 2017-06-06 13:53:05 +03:00
divyanshumehta
4824537aeb Added Rails/Delegate Rubucop Cop 2017-05-23 10:31:40 +05:30
Siddhant Bajaj
dc865abaaa Excluded conference_spec from block cop
Fixes #1333
2017-04-25 18:00:24 +05:30
Sunny
0564d2df7a add performance/stringreplacement rubocop cop
Enabled the performance/stringreplacement rubocop in the .rubocop.yml file and removed it from .rubocop_todo.yml. This cop checks for instances where gsub can be replaced with tr or delete. Supports auto correct, but there weren't any offenses.

Closes #1444
2017-04-13 21:20:35 -04:00
Ana María Martínez Gómez
46a6a59622 Merge pull request #1430 from codyborders/master
Adds Style/Tab cop to rubocop.yml
2017-04-07 18:50:22 +02:00
Ana María Martínez Gómez
fd6d0bf39b Merge pull request #1446 from sunny-b/master
Enable Style/DotPosition Rubocop cop
2017-04-07 11:21:34 +02:00
Sunny
03fa299058 enable style/dotposition rubocop cop 2017-04-06 23:19:58 -04:00
Cody Borders
535b3f86d6 Fixes Style/Tab cops
Removes exclusions for Style/Tab cops in rubocop_todo
Places Style/Tab cop in appropriate alphabetical order
All cops now fixed.
2017-04-06 10:57:44 -06:00
Christian Bruckmayer
5f74360da8 Merge pull request #1441 from neilhalligan/rubocop-edit
Add Lint/DuplicatedKey to rubocop
2017-04-06 09:34:41 +02:00
Neil Halligan
c74e914683 Add Lint/DuplicatedKey to rubocop
Fixes openSUSE/osem#1437
2017-04-05 17:33:14 +01:00
Ana María Martínez Gómez
d1bf19867c Merge pull request #1421 from sunny-b/master
Enable Style/NegatedIf Cop and Fix Alphabetical Ordering
2017-03-30 10:30:55 +02:00
Iris Sprague
29650beddb enable negatedif and correct db file
fix spacing
2017-03-29 11:24:43 -04:00
Emanuel Hayford
e5587d42a2 Enable Rails/Validation Rubocop cop
Cop checks for the use of old-style attribute validation. Supports autocorrection which was run
to fix the files concerned

Closes #1414
2017-03-28 21:47:31 +02:00
Chaitanya
782937b1d9 Enable Style/ZeroLengthPredicate Rubocop cop
This cop checks for numeric comparisons that can be replaced by a predicate method. It supports autocorrection, so all the offenses where automatically solved.

Closes #1416
2017-03-28 14:42:21 +05:30
Chaitanya
4427f43bdf Enable Style/RedundantSelf Rubocop cop
This cop checks for redundant uses of self. It supports autocorrection, so all the offenses where automatically solved.

Closes #1373
2017-03-28 13:27:52 +05:30
Emanuel Hayford
50b2153754 Group related cops together
This groups related cops in rubocop configuration file together and
arranges them in an alphabetical order

Close #1385
2017-03-24 20:13:02 +01:00
Chaitanya
7de009e46e Enable Style/DoubleNegation Rubocop cop
This cop checks for uses of double negation (!!) to convert something to a boolean value. It doesn't support autocorrection, so all the offenses where manually solved.

Closes #1374
2017-03-20 19:12:40 +05:30
Ana María Martínez Gómez
ebb5203887 Exclude conference model from ClassLength cop
Exclude conference.rb file from ClassLength Rubocop cop and decrease the
max value of this cop to 300, as the following class in number of lines is
event.rb with 218.

Also, remove unused comments from Conference model class.
2017-02-22 17:08:51 +01:00
gotens1211
4a9c971ec7 Enable Style/SpaceAroundOperators Rubocop
Cleared all the offenses for Style/SpaceAroundOperators

Added a description for the Style/SpaceAroundOperators Rubocop.
2017-02-05 19:43:00 +05:30
Ana
1559b29d2d Rubocop class length increased
Rubocop class length increased in 5 lines as app/models/conference.rb had too many lines.
2016-07-25 11:33:30 +02:00
Ana
2e73c3f67b Rubocop class length increased 2016-07-11 13:46:02 +02:00
Ana
1f7c903f2f 10 extra lines added to Rubocop ClassLength 2016-06-30 10:17:44 +02:00
Henne Vogelsang
ed0f55c45f Fix remaining rubocop problems 2016-02-18 14:40:24 +01:00
Henne Vogelsang
e2fb83146a Merge pull request #768 from hennevogel/rubocop
Update rubocop todo file
2016-02-18 14:08:04 +01:00
Aditya Prakash
67ac6f0d65 Update spring-commands-rspec and springify bin/rspec 2016-02-16 21:46:33 +05:30
Henne Vogelsang
046f726414 rubocop: Update todo file, enable rails cops 2016-02-08 14:57:23 +01:00
Stella Rouzi
da061b3902 exclude config/ from rubocop styling, more style fixes 2014-09-02 21:45:07 +03:00
Stella Rouzi
b7c45718d8 apply StringLiterals cop (remove double quotes, unless there is string interpolation) 2014-09-02 21:45:07 +03:00