enable negatedif and correct db file

fix spacing
This commit is contained in:
Iris Sprague 2017-03-28 22:20:27 -04:00 committed by Sun-Li Beatteay
parent e2a7e396a2
commit 29650beddb
3 changed files with 9 additions and 19 deletions

View file

@ -63,15 +63,15 @@ Style/EmptyLiteral:
Style/For:
Enabled: true
# Checks that operators have space around them, except for ** which should not have surrounding space.
Style/SpaceAroundOperators:
Enabled: true
# Use the new Ruby 1.9 hash syntax
Style/HashSyntax:
Enabled: true
EnforcedStyle: ruby19
# Checks for uses of if with negated condition. Use unless instead
Style/NegatedIf:
Enabled: true
# Do not compare with nil. Use .nil? instead
Style/NilComparison:
Enabled: true
@ -80,6 +80,10 @@ Style/NilComparison:
Style/RedundantSelf:
Enabled: true
# Checks that operators have space around them, except for ** which should not have surrounding space.
Style/SpaceAroundOperators:
Enabled: true
# Use single quotes unless there's string interpolation
Style/StringLiterals:
Enabled: true

View file

@ -439,20 +439,6 @@ Style/MutableConstant:
- 'app/models/event_user.rb'
- 'app/models/role.rb'
# Offense count: 16
# Cop supports --auto-correct.
Style/NegatedIf:
Exclude:
- 'app/controllers/admin/events_controller.rb'
- 'app/controllers/application_controller.rb'
- 'app/controllers/conference_registrations_controller.rb'
- 'app/controllers/proposal_controller.rb'
- 'app/models/conference.rb'
- 'app/models/datatable.rb'
- 'app/models/event.rb'
- 'app/models/venue.rb'
- 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb'
# Offense count: 4
Style/NestedParenthesizedCalls:
Exclude:

View file

@ -30,7 +30,7 @@ class MigratingSupporterRegistrationsToTicketUsers < ActiveRecord::Migration
s.save
end
end
if !s.user_id
unless s.user_id
s.user_id = deleted_user.id
s.save
end