Commit graph

1975 commits

Author SHA1 Message Date
Nishanth Vijayan
a45e537bac Setup basic Revision History page
Sets up paper_trail tracking in important models

and add conference_id to versions for storing conference_id
of conference related objects  as metadata.This will help in querying
for versions related to conferences.

Fix issues with factories & event types initialization.Import paper_trail testing helpers
Fix bug: Creating an event creates a useless version with event update

Add revert and view changes features to revision history
2016-08-12 13:35:56 +05:30
Christian Bruckmayer
60877e9593 Merge pull request #1141 from ChrisBr/update_rails
Update rails to version 4.2.7.1
2016-08-12 09:56:50 +02:00
Christian Bruckmayer
3b1a474ee0 Merge pull request #1094 from Ana06/schedule-versioning
Schedule versioning
2016-08-12 09:56:31 +02:00
Christian Bruckmayer
20dd33d2ff
Update rails to version 4.2.7.1 2016-08-12 09:43:05 +02:00
Christian Bruckmayer
02b287d398 Merge pull request #1139 from Ana06/css-removed
Restore css removed
2016-08-12 09:28:35 +02:00
Ana
d1392c1cba Restore css removed
Restore css which was removed in https://github.com/openSUSE/osem/pull/1132 as it is used in the public schedule.
2016-08-12 01:23:54 +02:00
Ana
0e9b8b598f Use jquery-ui-rails gem 2016-08-11 15:11:27 +02:00
Ana
1989a33da1 Test namings
Test namings in event_schedules and schedules controllers.
2016-08-11 15:11:27 +02:00
Ana
aebd5f20a1 Remove unnecessary attributes in osem-schedule.js
Remove unnecessary attributes (schedule and event id) in osem-schedule.js used for update an event.
2016-08-11 15:11:27 +02:00
Ana
8975df6a6b Event schedules controller tests improved 2016-08-11 15:11:27 +02:00
Ana
a1c7f67735 Render errors in JSON in the schedule correctly 2016-08-11 15:11:27 +02:00
Ana
e8261d41bc Improve Error messages
- Improve error messages in event schedules, schedules and program controller.
- Two respond_to blocks in the update method of program controller.
2016-08-11 15:11:27 +02:00
Ana
c687c1072e Add event schedules and schedules controller specs 2016-08-11 15:11:27 +02:00
Ana
5761e0f7a4 Using flash instead of alerts in the schedule
Using flash instead of alerts in the schedule to notify errors.

Also, a message shown when a schedule is successfully created.
2016-08-11 15:11:27 +02:00
Ana
81108290e5 Schedule update moved to program update
Schedule update updated a program attribute
2016-08-11 15:11:27 +02:00
Ana
310c521790 EventSchedulesController when something goes wrong
Consider that create, update or destroy can fails in EventSchedulesController

Params in remove deleted because they were not used
2016-08-11 15:11:27 +02:00
Ana
13bcee485e Has a valid factory test for event schedule
Has a valid factory test introduced for event schedule
2016-08-11 15:11:27 +02:00
Ana
c469f4f415 Event schedule controller pluralized 2016-08-11 15:11:27 +02:00
Ana
33e9c86214 Selected_scheduled? helper added
To be used in Schedules#index
2016-08-11 15:11:27 +02:00
Ana
29b920d746 Corrections in SchedulesController
- Controler file name pluralized
- Load and authorization fixed and improved
- Consider that save can fail in create action
- Eliminate unnecessary if in update action
- Ability and tests related to the schedules link in the admin sidebar fixed
2016-08-11 15:11:27 +02:00
Ana
2e1cd164a4 Load event schedule fixed
It was needed to use the id instead of the guid in the html attributes of the events in the admin schedule
2016-08-11 15:11:27 +02:00
Ana
57d2a05b7f Use of Rails usl helper instead of interpolation
I also eliminated a duplicated attribute in params
2016-08-11 15:11:27 +02:00
Ana
a578167cf5 Event model improvements
- Drop selected_event_schedule function
- Rename scheduled_room and scheduled_start_time to room and time as if there is no selected_schedule, the event is not scheduled.
2016-08-11 15:11:27 +02:00
Ana
5001848af7 Introduce an Admin::EventScheduleController
- move SchedulesController#update action
- split it into an #create/#update and #destroy action and use these actions in the JS code
2016-08-11 15:11:27 +02:00
Ana
a394293500 Do not use JS to initialize the schedule
- Only use JS for the drag&drop functionality and to the set/alter the time and rooms of the EventSchedule object.

- Introduce has_many :events, through: :event_schedules association to get unscheduled event easily
2016-08-11 15:11:27 +02:00
Ana
71dab6b79c SchedulesController introduced
The actions #schedule and #events were moved from conference controller to the new controller
2016-08-11 15:11:27 +02:00
Ana
b037a5eb7c Load and authorize schedule in ScheduleController 2016-08-11 15:11:27 +02:00
Ana
42848f929b Several schedules in the backend && routes changed
- Introduce plural resources for Schedule in routes.rb
- Introduce #index and #create actions for ScheduleController
- Make it possible to set a schedule as selected_schedule
2016-08-11 15:11:27 +02:00
Ana
3897ec79ca Repeated sentence moved to a function
program.selected_schedule.event_schedules.order(start_time: :asc) was repeated several times and it has been moved to conference#selected_event_schedules
2016-08-11 15:11:27 +02:00
Ana
beb17165a2 Introduce an association for the selected_schedule
Association in Program fot the selected_schedule
2016-08-11 15:11:27 +02:00
Ana
3f114629f9 javascript for the admin schedule moved to a .js
Inline javascript for the admin schedule moved to a dedicated .js file.
2016-08-11 15:11:27 +02:00
Ana
0b26ed5c35 EventSchedule validations
event, schedule, room and start_time are mandatory in EventSchedule.
2016-08-11 15:11:27 +02:00
Ana
354e15a76d Public schedule adapted to the new relations
Public schedule and all events adapted to the new relations and models to allow having several schedules in the admin shcedule.
2016-08-11 15:11:27 +02:00
Ana
dfd64a4510 Integrate the schedule in the admin interface
Integrate the schedule in the admin interface while adapting it to the new associations and models.
2016-08-11 15:06:52 +02:00
Ana
e7a30302ff Tests for the new associations and models
Tests for the schedule versioning new associations and models
2016-08-11 15:06:52 +02:00
Ana
c047ffd699 New associations and models: schedule versioning
For the schedule versioning in the admin interface (having multiple possible shcedules) we need to change some models and associations. It has also been create a rake:move_events_attributes task to migrate the data.

User Interface addapted to make use of the introduced associations and models
2016-08-11 15:06:52 +02:00
Stella Rouzi
e34a1904e0 Merge pull request #1132 from Ana06/all-events-links
Make the whole event panel clickable in all events
2016-08-11 13:20:46 +03:00
Ana
96337ed081 Make the whole event panel clickable in all events
Make the whole event panel clickable in all events in the public schedule. It didn't work properly when having links inside the panel.

It also works with ctrl + click openning the event page in a new tab.
2016-08-11 11:19:05 +02:00
Stella Rouzi
424b1302cb Merge pull request #1126 from Ana06/unless
Do not use unless with else
2016-08-09 13:21:17 +03:00
Ana
c1334e59cc Do not use unless with else
Solve Rubocop offense introduced in https://github.com/openSUSE/osem/pull/1123
2016-08-08 23:57:03 +02:00
Christian Bruckmayer
859b3beda6 Merge pull request #1123 from Ana06/if_not
style: if ! changed by unless
2016-08-08 14:07:05 +02:00
Christian Bruckmayer
81ef4f0438 Merge pull request #1112 from Ana06/ability_test
Creation of my_conference repeated in ability_spec
2016-08-08 14:05:30 +02:00
Ana
7e5d20c89d style: if ! changed by unless
- if ! changed by unless as it is more readable
- !object.blank? is equivalent to object.present?, also more readable
2016-08-06 00:57:07 +02:00
Ana
71b39bb612 creation of my_conference repeated in ability_spec
my_conference is created several times in ability_spec but it is not necessary.
2016-07-29 19:58:11 +02:00
Henne Vogelsang
96155eb87f Merge pull request #1082 from nishanthvijayan/handle-cancelled-events
Handle cancellation of scheduled events
2016-07-25 15:52:53 +02:00
Henne Vogelsang
5edc6123f4 Merge pull request #987 from differentreality/blind_voting
Blind voting
2016-07-25 15:49:01 +02:00
Nishanth Vijayan
a071d4497b Handle cancelation of scheduled events 2016-07-25 17:34:06 +05:30
Henne Vogelsang
63750345e7 Merge pull request #1032 from Ana06/all-events
All events grouped by date and time
2016-07-25 11:47:28 +02:00
Ana
1559b29d2d Rubocop class length increased
Rubocop class length increased in 5 lines as app/models/conference.rb had too many lines.
2016-07-25 11:33:30 +02:00
Ana
bf7f5ce09f The schedule takes you to the current day and time
The schedule takes you to the current day and time in case that the current date belongs to the conference schedule.

Closes https://github.com/openSUSE/osem/issues/1057
2016-07-25 11:33:30 +02:00