Changes:
- restoration of labels that were formerly generated by Formtastic
- corrections to markup of HTML labels and Bootstrap form controls
- minor copy editing
Resolves:
- Duplicate event listeners are registered during every word count,
increasing the number of word counts until the browser becomes
unresponsive.
- The word count is triggered multiple times on input due to listening
to redundant events.
This parameter was accidentally disconnected in commit c967a0b9a4
but is still used by `app/views/admin/conferences/index.html.haml` and
`app/views/admin/events/index.html.haml`.
Resolves:
Failures:
1) Survey as an attendee respond to a survey during registration
Failure/Error: expect(flash).to eq('Successfully responded to survey.')
expected: "Successfully responded to survey."
got: "none"
(compared using ==)
# ./spec/features/surveys_spec.rb:49:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:37 # Survey as an attendee respond to a survey during registration
The logic used for the `:reply` ability incompletely duplicated that of
`Survey#active?` and incorrectly assumed that surveys always have start
and end dates.
Resolves:
Failures:
1) Survey as an attendee respond to a survey during registration
Failure/Error: survey.start_date > Time.current || survey.end_date < Time.current
ActionView::Template::Error:
undefined method `>' for nil:NilClass
survey.start_date > Time.current || survey.end_date < Time.current
^
# ./app/models/ability.rb:126:in `block in signed_in'
# ./app/views/surveys/show.html.haml:28:in `block in _app_views_surveys_show_html_haml___3404959267043700678_138180'
# ./app/views/surveys/show.html.haml:19:in `_app_views_surveys_show_html_haml___3404959267043700678_138180'
Failed examples:
rspec ./spec/features/surveys_spec.rb:37 # Survey as an attendee respond to a survey during registration
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: select 'boolean', from: 'Type of Question:', visible: false # Hidden by bootstrap-select
Capybara::ElementNotFound:
Unable to find select box "Type of Question:" that is not disabled and Unable to find input box with datalist completion "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# Capybara::ElementNotFound:
# Unable to find select box "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
Resolves:
app/views/admin/surveys/_form.html.haml:25: warning: key :class is duplicated and overwritten on line 25
app/views/admin/surveys/_form.html.haml:27: warning: key :class is duplicated and overwritten on line 27
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: raise ActionController::MissingExactTemplate, message
ActionController::MissingExactTemplate:
Admin::SurveyQuestionsController#new is missing a template for request formats: text/html
# <internal:kernel>:90:in `tap'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: click_link 'New'
Capybara::ElementNotFound:
Unable to find link "New"
# ./spec/features/surveys_spec.rb:18:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
This reverts the skipping of tests by commit b688d353ac in:
- `spec/models/user_spec.rb`
- `spec/controllers/admin/users_controller_spec.rb`
- `spec/datatables/user_datatable_spec.rb`
