Commit graph

48 commits

Author SHA1 Message Date
rahul2240
2affec9614 Regenerate rubocop_todo file
Todo file is regenerated because of the changes in the new version of Rubocop.
We are following the default Rubocop configuration.
closes https://github.com/openSUSE/osem/issues/1815
2017-11-28 16:18:06 +05:30
nasia
52cde784fa Add :accept booth to ability 2017-08-18 23:41:38 +03:00
nasia
7107f9a35f Add emails for booth's acceptance and rejection 2017-08-14 22:34:17 +03:00
AEtherC0r3
fd93b04f16 Add room and dates to tracks
They are required only for accepted and confirmed self-organized tracks
2017-08-11 16:25:21 +03:00
AEtherC0r3
d616c66745 Define the track's finite state machine 2017-08-11 16:25:21 +03:00
nasia
32c5af2a17 Add booths to non admin 2017-08-08 16:18:07 +03:00
Hernan Schmidt
523203ac74 Update rubocop_todo.yml
Generated automatically by `rubocop --auto-gen-config`
2017-07-14 15:16:43 +02:00
AEtherC0r3
9c58397cd2 Enable Style/IndentationWidth cop
The offenses were fixed manually
2017-07-14 12:47:20 +03:00
AEtherC0r3
68fc750e9f Implement track requests and add the track organizer role
About track requests:
Create migration that adds the fields submitter_id, state, and
cfp_active to Tracks
Add validations and the self_organized? method to the Track model
Create a new TracksController outide of the admin namespace
Create the relevant views for index, show, new and edit
Modify the admin views for tracks to include extra info for
self-organized tracks

About track organizers:
Create the role when a self-organized track is created
Define track organizer abilities
Modify the roles views and controller to handle the new role

The route for Roles#edit needs to have higher priority than the nested
routes for track roles, otherwise, the word edit in the url is matched
as a track with short_name edit
2017-07-14 12:38:53 +03:00
AEtherC0r3
c3eb178546 Modify CFP to accept proposals for other things
Add field cfp_type and relevant validations
Add Program#cfp to preserve backwards compatibility
Add 'for_events' scope to the cfp, in order for it to be used like
program.cfps.events
Add useful methods
Add rspec test for the new code
The supported cfp types can be viewed via Cfp::TYPES
2017-06-27 21:16:46 +03:00
Ana María Martínez Gómez
267f080ac7 Enable Style/CommentAnnotation Rubocop cop
This cop checks that comment annotation keywords are written according
to guidelines. The offense was automatically corrected.
2017-06-26 16:47:07 +02:00
Dimitris
d160c22a0b Enable rails/findEach Rubocop cop
This cop enforce the use of `find_each` instead of `each`.

Closes #1535
2017-06-20 10:46:04 +03:00
divyanshumehta
cdf794ecbf Add Style/SelfAssignment Rubocop cop
The cop enforces use of self assignment operator E.g. a=a+2 gets
written as a+=2. Also the offenses listed in rubocop.todo.yml
have been corrected automatically with the --auto-correct option.
Fixes issue #1531
2017-06-14 09:22:19 +05:30
Ana María Martínez Gómez
53040b3be9 Merge pull request #1498 from divyanshumehta/issue_1497
Added Style/SpaceInsideBrackets Rubocop cop
2017-06-12 17:45:30 +02:00
AEtherC0r3
41503bb7a0 Compute ticket statistics
And exclude admin/ConferencesController from rubocop_todo.yml
2017-06-12 15:24:27 +03:00
divyanshumehta
0d01ed08b0 Added Style/SpaceInsideBrackets Rubocop cop 2017-06-11 22:57:52 +05:30
nasia
6cb11ff2f3 Add Style/WordArray at rubocop.yml #1463 2017-06-06 13:53:05 +03:00
AEtherC0r3
5bb52f24a5 Ignore html_safe in application helper 2017-06-04 15:31:45 +03:00
Agrim Mittal
e68738c154 update rubocop_todo.yml 2017-05-26 15:47:01 +03:00
hitman
f63259f187 update rubocop.yml for new files 2017-05-26 15:47:01 +03:00
divyanshumehta
4824537aeb Added Rails/Delegate Rubucop Cop 2017-05-23 10:31:40 +05:30
Chaitanya
4b72d383ea Fix Travis-Ci errors
Rubocop offenses lead to failure of Travis-ci build. Offensive files are added as exclude files of respective offense in rubocop_todo.yml
2017-05-13 17:49:17 +03:00
Agrim Mittal
aaeca108a8 Add missed offenses to rubocop_todo
A known rubocop bug, solved by adding files manually
Closes #1450
2017-04-21 21:36:39 +05:30
Agrim Mittal
7a10d69f14 regenerate rubocop_todo
Automatically generated using --auto-gen-config
2017-04-21 21:36:21 +05:30
Sunny
0564d2df7a add performance/stringreplacement rubocop cop
Enabled the performance/stringreplacement rubocop in the .rubocop.yml file and removed it from .rubocop_todo.yml. This cop checks for instances where gsub can be replaced with tr or delete. Supports auto correct, but there weren't any offenses.

Closes #1444
2017-04-13 21:20:35 -04:00
Ana María Martínez Gómez
46a6a59622 Merge pull request #1430 from codyborders/master
Adds Style/Tab cop to rubocop.yml
2017-04-07 18:50:22 +02:00
Ana María Martínez Gómez
fd6d0bf39b Merge pull request #1446 from sunny-b/master
Enable Style/DotPosition Rubocop cop
2017-04-07 11:21:34 +02:00
Sunny
03fa299058 enable style/dotposition rubocop cop 2017-04-06 23:19:58 -04:00
Cody Borders
535b3f86d6 Fixes Style/Tab cops
Removes exclusions for Style/Tab cops in rubocop_todo
Places Style/Tab cop in appropriate alphabetical order
All cops now fixed.
2017-04-06 10:57:44 -06:00
Ana María Martínez Gómez
d1bf19867c Merge pull request #1421 from sunny-b/master
Enable Style/NegatedIf Cop and Fix Alphabetical Ordering
2017-03-30 10:30:55 +02:00
Iris Sprague
29650beddb enable negatedif and correct db file
fix spacing
2017-03-29 11:24:43 -04:00
Emanuel Hayford
e5587d42a2 Enable Rails/Validation Rubocop cop
Cop checks for the use of old-style attribute validation. Supports autocorrection which was run
to fix the files concerned

Closes #1414
2017-03-28 21:47:31 +02:00
Chaitanya
782937b1d9 Enable Style/ZeroLengthPredicate Rubocop cop
This cop checks for numeric comparisons that can be replaced by a predicate method. It supports autocorrection, so all the offenses where automatically solved.

Closes #1416
2017-03-28 14:42:21 +05:30
Chaitanya
4427f43bdf Enable Style/RedundantSelf Rubocop cop
This cop checks for redundant uses of self. It supports autocorrection, so all the offenses where automatically solved.

Closes #1373
2017-03-28 13:27:52 +05:30
Chaitanya
7de009e46e Enable Style/DoubleNegation Rubocop cop
This cop checks for uses of double negation (!!) to convert something to a boolean value. It doesn't support autocorrection, so all the offenses where manually solved.

Closes #1374
2017-03-20 19:12:40 +05:30
gotens1211
4a9c971ec7 Enable Style/SpaceAroundOperators Rubocop
Cleared all the offenses for Style/SpaceAroundOperators

Added a description for the Style/SpaceAroundOperators Rubocop.
2017-02-05 19:43:00 +05:30
Stella
ccd7ecbb90 Roles into their own controller. Rework interface. Add flash messages to ajax calls. Add description to roles. Possible to edit roles in use. 2016-03-01 17:10:45 +02:00
Henne Vogelsang
ed0f55c45f Fix remaining rubocop problems 2016-02-18 14:40:24 +01:00
Henne Vogelsang
046f726414 rubocop: Update todo file, enable rails cops 2016-02-08 14:57:23 +01:00
Stella Rouzi
f91467a00a remove trailing spaces and blank lines 2014-09-02 21:41:25 +03:00
Stella Rouzi
1c1391c69e enable style ClassAndModuleChildren 2014-08-06 21:26:08 +03:00
Artem Chernikov
eb127b4f8c Add new styles to be checked 2014-07-30 23:43:00 +02:00
Artem Chernikov
99f773a040 Style/Blocks Style/BlockNesting cops enabled 2014-07-30 23:36:32 +02:00
Artem Chernikov
4aa1f0bf3a rubocop Style/AndOr style enabled 2014-07-30 23:34:09 +02:00
Artem Chernikov
f8784fdcd8 rubocop style fix Style/AlignParameters 2014-07-30 23:32:29 +02:00
Artem Chernikov
bce659a5d9 Move Accessor names to todo 2014-07-21 15:05:58 +02:00
Artem Chernikov
763f864dc9 Fix basic style issues with rubocop 2014-07-21 15:05:58 +02:00
Artem Chernikov
f4a22851a1 Update rubocop and add basic checks 2014-07-21 15:05:58 +02:00