Merge pull request #2406 from openSUSE/depfu/update/rubocop-0.65.0

Update rubocop: 0.61.1 → 0.65.0 (major)
This commit is contained in:
Henne Vogelsang 2019-03-11 17:03:59 +01:00 committed by GitHub
commit a19772307a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 151 additions and 128 deletions

View file

@ -1,12 +1,12 @@
# This configuration was generated by # This configuration was generated by
# `rubocop --auto-gen-config` # `rubocop --auto-gen-config`
# on 2018-09-08 03:47:39 +0200 using RuboCop version 0.58.2. # on 2019-03-08 16:06:53 +0000 using RuboCop version 0.65.0.
# The point is for the user to remove these configuration records # The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base. # one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new # Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again. # versions of RuboCop, may require this file to be generated again.
# Offense count: 381 # Offense count: 351
Capybara/CurrentPathExpectation: Capybara/CurrentPathExpectation:
Exclude: Exclude:
- 'spec/features/base_controller_spec.rb' - 'spec/features/base_controller_spec.rb'
@ -23,17 +23,12 @@ Capybara/CurrentPathExpectation:
- 'spec/features/track_organizer_ability_spec.rb' - 'spec/features/track_organizer_ability_spec.rb'
- 'spec/features/user_ability_spec.rb' - 'spec/features/user_ability_spec.rb'
# Offense count: 170 # Offense count: 161
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnabledMethods. # Configuration parameters: EnabledMethods.
Capybara/FeatureMethods: Capybara/FeatureMethods:
Enabled: false Enabled: false
# Offense count: 140
# Cop supports --auto-correct.
FactoryBot/AttributeDefinedStatically:
Enabled: false
# Offense count: 4 # Offense count: 4
# Cop supports --auto-correct. # Cop supports --auto-correct.
Layout/ClosingParenthesisIndentation: Layout/ClosingParenthesisIndentation:
@ -67,7 +62,7 @@ Layout/EmptyLineAfterMagicComment:
Exclude: Exclude:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 121 # Offense count: 117
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: empty_lines, no_empty_lines # SupportedStyles: empty_lines, no_empty_lines
@ -80,7 +75,7 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords:
Exclude: Exclude:
- 'app/models/payment.rb' - 'app/models/payment.rb'
# Offense count: 51 # Offense count: 52
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
Layout/ExtraSpacing: Layout/ExtraSpacing:
@ -98,7 +93,7 @@ Layout/ExtraSpacing:
- 'db/schema.rb' - 'db/schema.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 47 # Offense count: 43
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth. # Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
@ -113,13 +108,12 @@ Layout/IndentArray:
Exclude: Exclude:
- 'app/models/conference.rb' - 'app/models/conference.rb'
# Offense count: 6 # Offense count: 5
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: IndentationWidth. # Configuration parameters: IndentationWidth.
Layout/IndentAssignment: Layout/IndentAssignment:
Exclude: Exclude:
- 'app/helpers/format_helper.rb' - 'app/helpers/format_helper.rb'
- 'app/models/conference.rb'
- 'config/environments/development.rb' - 'config/environments/development.rb'
# Offense count: 4 # Offense count: 4
@ -149,13 +143,12 @@ Layout/IndentationWidth:
Exclude: Exclude:
- 'app/controllers/users_controller.rb' - 'app/controllers/users_controller.rb'
# Offense count: 5 # Offense count: 4
# Cop supports --auto-correct. # Cop supports --auto-correct.
Layout/LeadingCommentSpace: Layout/LeadingCommentSpace:
Exclude: Exclude:
- 'Guardfile' - 'Guardfile'
- 'app/models/comment.rb' - 'app/models/comment.rb'
- 'config/deploy.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
@ -181,14 +174,14 @@ Layout/MultilineHashBraceLayout:
- 'config/routes.rb' - 'config/routes.rb'
- 'spec/models/event_spec.rb' - 'spec/models/event_spec.rb'
# Offense count: 40 # Offense count: 36
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: symmetrical, new_line, same_line # SupportedStyles: symmetrical, new_line, same_line
Layout/MultilineMethodCallBraceLayout: Layout/MultilineMethodCallBraceLayout:
Enabled: false Enabled: false
# Offense count: 56 # Offense count: 53
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, IndentationWidth. # Configuration parameters: EnforcedStyle, IndentationWidth.
# SupportedStyles: aligned, indented, indented_relative_to_receiver # SupportedStyles: aligned, indented, indented_relative_to_receiver
@ -244,7 +237,7 @@ Layout/SpaceAroundOperators:
- 'config/initializers/airbrake.rb' - 'config/initializers/airbrake.rb'
- 'lib/tasks/data.rake' - 'lib/tasks/data.rake'
# Offense count: 487 # Offense count: 138
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space # SupportedStyles: space, no_space
@ -294,20 +287,19 @@ Layout/SpaceInsideBlockBraces:
- 'app/models/ticket.rb' - 'app/models/ticket.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
- 'lib/tasks/events_registrations.rake' - 'lib/tasks/events_registrations.rake'
- 'spec/ability/ability_spec.rb'
- 'spec/controllers/admin/event_schedules_controller_spec.rb' - 'spec/controllers/admin/event_schedules_controller_spec.rb'
- 'spec/controllers/admin/schedules_controller_spec.rb' - 'spec/controllers/admin/schedules_controller_spec.rb'
- 'spec/features/splashpage_spec.rb' - 'spec/features/splashpage_spec.rb'
- 'spec/ability/ability_spec.rb'
- 'spec/models/user_spec.rb' - 'spec/models/user_spec.rb'
# Offense count: 39 # Offense count: 37
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
# SupportedStyles: space, no_space, compact # SupportedStyles: space, no_space, compact
# SupportedStylesForEmptyBraces: space, no_space # SupportedStylesForEmptyBraces: space, no_space
Layout/SpaceInsideHashLiteralBraces: Layout/SpaceInsideHashLiteralBraces:
Exclude: Exclude:
- 'app/controllers/admin/conferences_controller.rb'
- 'app/controllers/api/v1/speakers_controller.rb' - 'app/controllers/api/v1/speakers_controller.rb'
- 'app/models/conference.rb' - 'app/models/conference.rb'
- 'app/models/event_type.rb' - 'app/models/event_type.rb'
@ -331,13 +323,11 @@ Layout/SpaceInsideParens:
Exclude: Exclude:
- 'app/views/admin/registrations/index.xlsx.axlsx' - 'app/views/admin/registrations/index.xlsx.axlsx'
# Offense count: 5 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct.
Layout/SpaceInsidePercentLiteralDelimiters: Layout/SpaceInsidePercentLiteralDelimiters:
Exclude: Exclude:
- 'Gemfile' - 'Gemfile'
- 'config/deploy.rb'
- 'config/initializers/assets.rb'
# Offense count: 2 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct.
@ -412,45 +402,64 @@ Lint/UnusedMethodArgument:
Exclude: Exclude:
- 'config/initializers/fuckups.rb' - 'config/initializers/fuckups.rb'
# Offense count: 142 # Offense count: 138
Metrics/AbcSize: Metrics/AbcSize:
Max: 94 Max: 74
# Offense count: 331 # Offense count: 312
# Configuration parameters: CountComments, ExcludedMethods. # Configuration parameters: CountComments, ExcludedMethods.
# ExcludedMethods: refine # ExcludedMethods: refine
Metrics/BlockLength: Metrics/BlockLength:
Max: 1419 Max: 1347
# Offense count: 1 # Offense count: 1
# Configuration parameters: CountBlocks. # Configuration parameters: CountBlocks, Max.
Metrics/BlockNesting: Metrics/BlockNesting:
Max: 4 Exclude:
- 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
# Offense count: 13 # Offense count: 13
# Configuration parameters: CountComments. # Configuration parameters: CountComments, Max.
Metrics/ClassLength: Metrics/ClassLength:
Max: 684 Exclude:
- 'app/controllers/admin/booths_controller.rb'
- 'app/controllers/admin/conferences_controller.rb'
- 'app/controllers/admin/events_controller.rb'
- 'app/controllers/admin/tracks_controller.rb'
- 'app/controllers/proposals_controller.rb'
- 'app/mailers/mailbot.rb'
- 'app/models/ability.rb'
- 'app/models/admin_ability.rb'
- 'app/models/conference.rb'
- 'app/models/event.rb'
- 'app/models/program.rb'
- 'app/models/track.rb'
- 'app/models/user.rb'
# Offense count: 32 # Offense count: 33
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:
Max: 14 Max: 14
# Offense count: 146 # Offense count: 147
# Configuration parameters: CountComments. # Configuration parameters: CountComments, ExcludedMethods.
Metrics/MethodLength: Metrics/MethodLength:
Max: 60 Max: 56
# Offense count: 5 # Offense count: 5
# Configuration parameters: CountComments. # Configuration parameters: CountComments, Max.
Metrics/ModuleLength: Metrics/ModuleLength:
Max: 173 Exclude:
- 'app/helpers/application_helper.rb'
- 'app/helpers/events_helper.rb'
- 'app/helpers/format_helper.rb'
- 'app/helpers/versions_helper.rb'
- 'spec/support/omniauth_macros.rb'
# Offense count: 22 # Offense count: 22
Metrics/PerceivedComplexity: Metrics/PerceivedComplexity:
Max: 16 Max: 16
# Offense count: 17 # Offense count: 13
Naming/AccessorMethodName: Naming/AccessorMethodName:
Exclude: Exclude:
- 'app/models/conference.rb' - 'app/models/conference.rb'
@ -478,7 +487,7 @@ Naming/PredicateName:
# Offense count: 2 # Offense count: 2
# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
# AllowedNames: io, id, to, by, on, in, at, ip # AllowedNames: io, id, to, by, on, in, at, ip, db
Naming/UncommunicativeMethodParamName: Naming/UncommunicativeMethodParamName:
Exclude: Exclude:
- 'app/models/conference.rb' - 'app/models/conference.rb'
@ -497,7 +506,7 @@ Performance/InefficientHashSearch:
- 'app/controllers/admin/versions_controller.rb' - 'app/controllers/admin/versions_controller.rb'
- 'app/helpers/versions_helper.rb' - 'app/helpers/versions_helper.rb'
# Offense count: 31 # Offense count: 28
RSpec/AnyInstance: RSpec/AnyInstance:
Exclude: Exclude:
- 'spec/controllers/admin/rooms_controller_spec.rb' - 'spec/controllers/admin/rooms_controller_spec.rb'
@ -508,13 +517,13 @@ RSpec/AnyInstance:
- 'spec/controllers/proposals_controller_spec.rb' - 'spec/controllers/proposals_controller_spec.rb'
- 'spec/controllers/tracks_controller_spec.rb' - 'spec/controllers/tracks_controller_spec.rb'
# Offense count: 327 # Offense count: 314
# Configuration parameters: Prefixes. # Configuration parameters: Prefixes.
# Prefixes: when, with, without # Prefixes: when, with, without
RSpec/ContextWording: RSpec/ContextWording:
Enabled: false Enabled: false
# Offense count: 73 # Offense count: 68
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: SkipBlocks, EnforcedStyle. # Configuration parameters: SkipBlocks, EnforcedStyle.
# SupportedStyles: described_class, explicit # SupportedStyles: described_class, explicit
@ -536,7 +545,7 @@ RSpec/EmptyLineAfterExampleGroup:
Exclude: Exclude:
- 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb'
# Offense count: 12 # Offense count: 11
# Cop supports --auto-correct. # Cop supports --auto-correct.
RSpec/EmptyLineAfterFinalLet: RSpec/EmptyLineAfterFinalLet:
Exclude: Exclude:
@ -544,7 +553,6 @@ RSpec/EmptyLineAfterFinalLet:
- 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/admin/users_controller_spec.rb'
- 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb'
- 'spec/features/conference_spec.rb' - 'spec/features/conference_spec.rb'
- 'spec/models/admin_ability_spec.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/payment_spec.rb' - 'spec/models/payment_spec.rb'
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
@ -564,12 +572,11 @@ RSpec/EmptyLineAfterHook:
- 'spec/models/payment_spec.rb' - 'spec/models/payment_spec.rb'
- 'spec/models/program_spec.rb' - 'spec/models/program_spec.rb'
# Offense count: 9 # Offense count: 8
# Cop supports --auto-correct. # Cop supports --auto-correct.
RSpec/EmptyLineAfterSubject: RSpec/EmptyLineAfterSubject:
Exclude: Exclude:
- 'spec/ability/ability_spec.rb' - 'spec/ability/ability_spec.rb'
- 'spec/models/admin_ability_spec.rb'
- 'spec/models/booth_spec.rb' - 'spec/models/booth_spec.rb'
- 'spec/models/cfp_spec.rb' - 'spec/models/cfp_spec.rb'
- 'spec/models/event_spec.rb' - 'spec/models/event_spec.rb'
@ -578,7 +585,7 @@ RSpec/EmptyLineAfterSubject:
- 'spec/models/survey_spec.rb' - 'spec/models/survey_spec.rb'
- 'spec/models/track_spec.rb' - 'spec/models/track_spec.rb'
# Offense count: 230 # Offense count: 219
# Configuration parameters: Max. # Configuration parameters: Max.
RSpec/ExampleLength: RSpec/ExampleLength:
Enabled: false Enabled: false
@ -599,7 +606,7 @@ RSpec/ExampleWording:
- 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_purchase_spec.rb'
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
# Offense count: 38 # Offense count: 37
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: method_call, block # SupportedStyles: method_call, block
@ -629,28 +636,41 @@ RSpec/FilePath:
- 'spec/models/comment_spec.rb' - 'spec/models/comment_spec.rb'
- 'spec/models/openid.rb' - 'spec/models/openid.rb'
# Offense count: 174 # Offense count: 170
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: implicit, each, example # SupportedStyles: implicit, each, example
RSpec/HookArgument: RSpec/HookArgument:
Enabled: false Enabled: false
# Offense count: 499 # Offense count: 140
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: is_expected, should # SupportedStyles: is_expected, should
RSpec/ImplicitExpect: RSpec/ImplicitExpect:
Enabled: false Exclude:
- 'spec/ability/ability_spec.rb'
- 'spec/models/commercial_spec.rb'
- 'spec/models/conference_spec.rb'
- 'spec/models/event_schedule_spec.rb'
- 'spec/models/event_type_spec.rb'
- 'spec/models/organization_spec.rb'
- 'spec/models/registration_period_spec.rb'
- 'spec/models/room_spec.rb'
- 'spec/models/schedule_spec.rb'
- 'spec/models/sponsor_spec.rb'
- 'spec/models/sponsorship_level_spec.rb'
- 'spec/models/ticket_purchase_spec.rb'
- 'spec/models/ticket_spec.rb'
- 'spec/models/user_spec.rb'
# Offense count: 48 # Offense count: 39
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: single_line_only, disallow # SupportedStyles: single_line_only, single_statement_only, disallow
RSpec/ImplicitSubject: RSpec/ImplicitSubject:
Exclude: Exclude:
- 'spec/ability/ability_spec.rb' - 'spec/ability/ability_spec.rb'
- 'spec/models/admin_ability_spec.rb'
- 'spec/models/booth_spec.rb' - 'spec/models/booth_spec.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/event_type_spec.rb' - 'spec/models/event_type_spec.rb'
@ -661,21 +681,35 @@ RSpec/ImplicitSubject:
- 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_purchase_spec.rb'
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
# Offense count: 347 # Offense count: 321
# Configuration parameters: AssignmentOnly. # Configuration parameters: AssignmentOnly.
RSpec/InstanceVariable: RSpec/InstanceVariable:
Enabled: false Exclude:
- 'spec/controllers/admin/sponsorship_levels_controller_spec.rb'
- 'spec/controllers/admin/versions_controller_spec.rb'
- 'spec/controllers/api/v1/conferences_controller_spec.rb'
- 'spec/controllers/application_controller_spec.rb'
- 'spec/controllers/conference_registration_controller_spec.rb'
- 'spec/controllers/conferences_controller_spec.rb'
- 'spec/controllers/confirmations_controller_spec.rb'
- 'spec/controllers/proposals_controller_spec.rb'
- 'spec/features/proposals_spec.rb'
- 'spec/helpers/application_helper_spec.rb'
- 'spec/models/conference_spec.rb'
- 'spec/models/event_schedule_spec.rb'
- 'spec/models/sponsorship_level_spec.rb'
- 'spec/models/track_spec.rb'
- 'spec/models/user_spec.rb'
# Offense count: 5 # Offense count: 4
# Cop supports --auto-correct. # Cop supports --auto-correct.
RSpec/LeadingSubject: RSpec/LeadingSubject:
Exclude: Exclude:
- 'spec/ability/ability_spec.rb' - 'spec/ability/ability_spec.rb'
- 'spec/models/admin_ability_spec.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
- 'spec/models/ticket_spec.rb' - 'spec/models/ticket_spec.rb'
# Offense count: 51 # Offense count: 50
RSpec/LetSetup: RSpec/LetSetup:
Enabled: false Enabled: false
@ -690,12 +724,12 @@ RSpec/MultipleDescribes:
Exclude: Exclude:
- 'spec/controllers/application_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb'
# Offense count: 283 # Offense count: 278
# Configuration parameters: AggregateFailuresByDefault. # Configuration parameters: AggregateFailuresByDefault.
RSpec/MultipleExpectations: RSpec/MultipleExpectations:
Max: 106 Max: 97
# Offense count: 403 # Offense count: 387
RSpec/NamedSubject: RSpec/NamedSubject:
Exclude: Exclude:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
@ -703,11 +737,11 @@ RSpec/NamedSubject:
- 'spec/models/room_spec.rb' - 'spec/models/room_spec.rb'
- 'spec/models/track_spec.rb' - 'spec/models/track_spec.rb'
# Offense count: 213 # Offense count: 206
RSpec/NestedGroups: RSpec/NestedGroups:
Max: 7 Max: 7
# Offense count: 93 # Offense count: 85
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: not_to, to_not # SupportedStyles: not_to, to_not
@ -737,7 +771,7 @@ RSpec/RepeatedExample:
Exclude: Exclude:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 13 # Offense count: 10
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: and_return, block # SupportedStyles: and_return, block
@ -745,11 +779,10 @@ RSpec/ReturnFromStub:
Exclude: Exclude:
- 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb'
# Offense count: 49 # Offense count: 19
RSpec/ScatteredLet: RSpec/ScatteredLet:
Exclude: Exclude:
- 'spec/ability/ability_spec.rb' - 'spec/ability/ability_spec.rb'
- 'spec/models/admin_ability_spec.rb'
- 'spec/models/payment_spec.rb' - 'spec/models/payment_spec.rb'
# Offense count: 2 # Offense count: 2
@ -764,8 +797,8 @@ RSpec/SubjectStub:
- 'spec/models/room_spec.rb' - 'spec/models/room_spec.rb'
- 'spec/models/track_spec.rb' - 'spec/models/track_spec.rb'
# Offense count: 1 # Offense count: 3
# Configuration parameters: IgnoreSymbolicNames. # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
RSpec/VerifiedDoubles: RSpec/VerifiedDoubles:
Exclude: Exclude:
- 'spec/datatables/user_datatable_spec.rb' - 'spec/datatables/user_datatable_spec.rb'
@ -785,12 +818,12 @@ Rails/ActionFilter:
Exclude: Exclude:
- 'app/controllers/users/omniauth_callbacks_controller.rb' - 'app/controllers/users/omniauth_callbacks_controller.rb'
# Offense count: 107 # Offense count: 103
# Cop supports --auto-correct. # Cop supports --auto-correct.
Rails/ActiveRecordAliases: Rails/ActiveRecordAliases:
Enabled: false Enabled: false
# Offense count: 128 # Offense count: 129
# Cop supports --auto-correct. # Cop supports --auto-correct.
Rails/ApplicationRecord: Rails/ApplicationRecord:
Enabled: false Enabled: false
@ -812,7 +845,7 @@ Rails/Blank:
Rails/CreateTableWithTimestamps: Rails/CreateTableWithTimestamps:
Enabled: false Enabled: false
# Offense count: 126 # Offense count: 111
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible # SupportedStyles: strict, flexible
Rails/Date: Rails/Date:
@ -870,7 +903,7 @@ Rails/HasAndBelongsToMany:
- 'app/models/registration.rb' - 'app/models/registration.rb'
- 'app/models/vchoice.rb' - 'app/models/vchoice.rb'
# Offense count: 20 # Offense count: 19
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: app/models/**/*.rb # Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent: Rails/HasManyOrHasOneDependent:
@ -890,7 +923,7 @@ Rails/HasManyOrHasOneDependent:
- 'app/models/vday.rb' - 'app/models/vday.rb'
- 'app/models/vposition.rb' - 'app/models/vposition.rb'
# Offense count: 256 # Offense count: 249
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: spec/**/*, test/**/* # Include: spec/**/*, test/**/*
@ -915,6 +948,12 @@ Rails/LexicallyScopedActionFilter:
Exclude: Exclude:
- 'app/controllers/registrations_controller.rb' - 'app/controllers/registrations_controller.rb'
# Offense count: 1
# Cop supports --auto-correct.
Rails/LinkToBlank:
Exclude:
- 'app/helpers/format_helper.rb'
# Offense count: 1 # Offense count: 1
# Configuration parameters: Include. # Configuration parameters: Include.
# Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
@ -943,7 +982,7 @@ Rails/Presence:
- 'app/helpers/application_helper.rb' - 'app/helpers/application_helper.rb'
- 'app/models/user.rb' - 'app/models/user.rb'
# Offense count: 23 # Offense count: 18
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. # Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank.
Rails/Present: Rails/Present:
@ -977,7 +1016,7 @@ Rails/ReversibleMigration:
- 'db/migrate/20141130182139_drop_table_event_attachments.rb' - 'db/migrate/20141130182139_drop_table_event_attachments.rb'
# Offense count: 8 # Offense count: 8
# Configuration parameters: Blacklist. # Configuration parameters: Blacklist, Whitelist.
# Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters
Rails/SkipsModelValidations: Rails/SkipsModelValidations:
Exclude: Exclude:
@ -989,7 +1028,7 @@ Rails/SkipsModelValidations:
- 'lib/tasks/user.rake' - 'lib/tasks/user.rake'
- 'spec/controllers/conferences_controller_spec.rb' - 'spec/controllers/conferences_controller_spec.rb'
# Offense count: 51 # Offense count: 49
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: strict, flexible # SupportedStyles: strict, flexible
Rails/TimeZone: Rails/TimeZone:
@ -1005,18 +1044,11 @@ Rails/TimeZone:
- 'spec/factories/users.rb' - 'spec/factories/users.rb'
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 2 # Offense count: 3
Security/Open: Security/Open:
Exclude: Exclude:
- 'app/pdfs/ticket_pdf.rb' - 'app/pdfs/ticket_pdf.rb'
# Offense count: 2
# Configuration parameters: EnforcedStyle.
# SupportedStyles: inline, group
Style/AccessModifierDeclarations:
Exclude:
- 'spec/factories/splashpages.rb'
# Offense count: 1 # Offense count: 1
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
@ -1037,27 +1069,18 @@ Style/ColonMethodCall:
- 'app/models/commercial.rb' - 'app/models/commercial.rb'
- 'app/models/contact.rb' - 'app/models/contact.rb'
# Offense count: 5 # Offense count: 4
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
# SupportedStyles: assign_to_condition, assign_inside_condition # SupportedStyles: assign_to_condition, assign_inside_condition
Style/ConditionalAssignment: Style/ConditionalAssignment:
Exclude: Exclude:
- 'app/helpers/format_helper.rb' - 'app/helpers/format_helper.rb'
- 'config/environments/production.rb'
- 'config/initializers/airbrake.rb' - 'config/initializers/airbrake.rb'
- 'db/migrate/20140610165551_migrate_data_person_to_user.rb' - 'db/migrate/20140610165551_migrate_data_person_to_user.rb'
- 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb'
# Offense count: 11 # Offense count: 516
Style/DateTime:
Exclude:
- 'app/models/conference.rb'
- 'app/models/program.rb'
- 'spec/models/conference_spec.rb'
- 'spec/models/program_spec.rb'
# Offense count: 514
Style/Documentation: Style/Documentation:
Enabled: false Enabled: false
@ -1079,7 +1102,7 @@ Style/EmptyLiteral:
Exclude: Exclude:
- 'spec/models/conference_spec.rb' - 'spec/models/conference_spec.rb'
# Offense count: 9 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: compact, expanded # SupportedStyles: compact, expanded
@ -1116,19 +1139,19 @@ Style/ExpandPathArguments:
- 'config/environment.rb' - 'config/environment.rb'
- 'spec/spec_helper.rb' - 'spec/spec_helper.rb'
# Offense count: 44 # Offense count: 49
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle. # Configuration parameters: EnforcedStyle.
# SupportedStyles: when_needed, always, never # SupportedStyles: when_needed, always, never
Style/FrozenStringLiteralComment: Style/FrozenStringLiteralComment:
Enabled: false Enabled: false
# Offense count: 30 # Offense count: 29
# Configuration parameters: MinBodyLength. # Configuration parameters: MinBodyLength.
Style/GuardClause: Style/GuardClause:
Enabled: false Enabled: false
# Offense count: 8 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
@ -1139,7 +1162,7 @@ Style/HashSyntax:
- 'app/views/admin/registrations/index.xlsx.axlsx' - 'app/views/admin/registrations/index.xlsx.axlsx'
- 'lib/tasks/user.rake' - 'lib/tasks/user.rake'
# Offense count: 61 # Offense count: 58
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/IfUnlessModifier: Style/IfUnlessModifier:
Enabled: false Enabled: false
@ -1148,7 +1171,6 @@ Style/IfUnlessModifier:
# Cop supports --auto-correct. # Cop supports --auto-correct.
Style/LineEndConcatenation: Style/LineEndConcatenation:
Exclude: Exclude:
- 'spec/features/cfp_spec.rb'
- 'spec/features/conference_spec.rb' - 'spec/features/conference_spec.rb'
- 'spec/features/registration_periods_spec.rb' - 'spec/features/registration_periods_spec.rb'
@ -1182,6 +1204,8 @@ Style/MultilineIfModifier:
# Offense count: 2 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle.
# SupportedStyles: literals, strict
Style/MutableConstant: Style/MutableConstant:
Exclude: Exclude:
- 'app/models/event_user.rb' - 'app/models/event_user.rb'
@ -1203,7 +1227,7 @@ Style/NestedParenthesizedCalls:
Style/Next: Style/Next:
Enabled: false Enabled: false
# Offense count: 121 # Offense count: 120
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedOctalStyle. # Configuration parameters: EnforcedOctalStyle.
# SupportedOctalStyles: zero_with_o, zero_only # SupportedOctalStyles: zero_with_o, zero_only
@ -1220,13 +1244,18 @@ Style/NumericLiteralPrefix:
# Offense count: 8 # Offense count: 8
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: Strict. # Configuration parameters: MinDigits, Strict.
Style/NumericLiterals: Style/NumericLiterals:
MinDigits: 15 Exclude:
- 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb'
- 'db/schema.rb'
- 'lib/tasks/events_registrations.rake'
- 'spec/features/versions_spec.rb'
- 'spec/models/ticket_spec.rb'
# Offense count: 41 # Offense count: 36
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, EnforcedStyle. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
# SupportedStyles: predicate, comparison # SupportedStyles: predicate, comparison
Style/NumericPredicate: Style/NumericPredicate:
Exclude: Exclude:
@ -1264,7 +1293,7 @@ Style/ParenthesesAroundCondition:
- 'app/controllers/application_controller.rb' - 'app/controllers/application_controller.rb'
- 'app/helpers/format_helper.rb' - 'app/helpers/format_helper.rb'
# Offense count: 28 # Offense count: 22
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: PreferredDelimiters. # Configuration parameters: PreferredDelimiters.
Style/PercentLiteralDelimiters: Style/PercentLiteralDelimiters:
@ -1297,15 +1326,15 @@ Style/RedundantParentheses:
Exclude: Exclude:
- 'app/controllers/admin/base_controller.rb' - 'app/controllers/admin/base_controller.rb'
# Offense count: 3 # Offense count: 4
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, AllowInnerSlashes. # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
# SupportedStyles: slashes, percent_r, mixed # SupportedStyles: slashes, percent_r, mixed
Style/RegexpLiteral: Style/RegexpLiteral:
Exclude: Exclude:
- 'Guardfile' - 'Guardfile'
- 'config/initializers/airbrake.rb'
- 'app/uploaders/picture_uploader.rb' - 'app/uploaders/picture_uploader.rb'
- 'config/initializers/airbrake.rb'
# Offense count: 2 # Offense count: 2
# Cop supports --auto-correct. # Cop supports --auto-correct.
@ -1332,7 +1361,7 @@ Style/SingleLineMethods:
Exclude: Exclude:
- 'Guardfile' - 'Guardfile'
# Offense count: 672 # Offense count: 611
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes # SupportedStyles: single_quotes, double_quotes
@ -1343,9 +1372,7 @@ Style/StringLiterals:
- 'bin/spring' - 'bin/spring'
- 'config/deploy.rb' - 'config/deploy.rb'
- 'config/environments/production.rb' - 'config/environments/production.rb'
- 'config/initializers/devise.rb'
- 'config/puma.rb' - 'config/puma.rb'
- 'config/routes.rb'
- 'db/schema.rb' - 'db/schema.rb'
- 'lib/tasks/dump_db.rake' - 'lib/tasks/dump_db.rake'
- 'lib/tasks/events_registrations.rake' - 'lib/tasks/events_registrations.rake'
@ -1363,19 +1390,13 @@ Style/StringLiteralsInInterpolation:
- 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - 'app/views/admin/events/_confirmed_events.xlsx.axlsx'
- 'lib/tasks/dump_db.rake' - 'lib/tasks/dump_db.rake'
# Offense count: 109 # Offense count: 110
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, MinSize. # Configuration parameters: EnforcedStyle, MinSize.
# SupportedStyles: percent, brackets # SupportedStyles: percent, brackets
Style/SymbolArray: Style/SymbolArray:
Enabled: false Enabled: false
# Offense count: 1
# Cop supports --auto-correct.
Style/SymbolLiteral:
Exclude:
- 'config/deploy.rb'
# Offense count: 10 # Offense count: 10
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: IgnoredMethods. # Configuration parameters: IgnoredMethods.
@ -1428,7 +1449,7 @@ Style/UnneededCondition:
- 'app/helpers/versions_helper.rb' - 'app/helpers/versions_helper.rb'
- 'app/models/ticket.rb' - 'app/models/ticket.rb'
# Offense count: 8 # Offense count: 7
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: WordRegex. # Configuration parameters: WordRegex.
# SupportedStyles: percent, brackets # SupportedStyles: percent, brackets
@ -1436,7 +1457,7 @@ Style/WordArray:
EnforcedStyle: percent EnforcedStyle: percent
MinSize: 8 MinSize: 8
# Offense count: 3041 # Offense count: 2887
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https # URISchemes: http, https
Metrics/LineLength: Metrics/LineLength:

View file

@ -242,7 +242,7 @@ GEM
loggability (~> 0.12) loggability (~> 0.12)
io-like (0.3.0) io-like (0.3.0)
iso-639 (0.2.8) iso-639 (0.2.8)
jaro_winkler (1.5.1) jaro_winkler (1.5.2)
jquery-datatables-rails (3.4.0) jquery-datatables-rails (3.4.0)
actionpack (>= 3.1) actionpack (>= 3.1)
jquery-rails jquery-rails
@ -342,8 +342,8 @@ GEM
paper_trail (10.1.0) paper_trail (10.1.0)
activerecord (>= 4.2, < 6.0) activerecord (>= 4.2, < 6.0)
request_store (~> 1.1) request_store (~> 1.1)
parallel (1.12.1) parallel (1.14.0)
parser (2.5.3.0) parser (2.6.0.0)
ast (~> 2.4.0) ast (~> 2.4.0)
pdf-core (0.7.0) pdf-core (0.7.0)
pdf-inspector (1.3.0) pdf-inspector (1.3.0)
@ -373,6 +373,7 @@ GEM
coderay (~> 1.1.0) coderay (~> 1.1.0)
method_source (~> 0.8.1) method_source (~> 0.8.1)
slop (~> 3.4) slop (~> 3.4)
psych (3.1.0)
public_suffix (3.0.3) public_suffix (3.0.3)
puma (3.12.0) puma (3.12.0)
rack (2.0.6) rack (2.0.6)
@ -488,11 +489,12 @@ GEM
rspec-mocks (~> 3.6.0) rspec-mocks (~> 3.6.0)
rspec-support (~> 3.6.0) rspec-support (~> 3.6.0)
rspec-support (3.6.0) rspec-support (3.6.0)
rubocop (0.61.1) rubocop (0.65.0)
jaro_winkler (~> 1.5.1) jaro_winkler (~> 1.5.1)
parallel (~> 1.10) parallel (~> 1.10)
parser (>= 2.5, != 2.5.1.1) parser (>= 2.5, != 2.5.1.1)
powerpack (~> 0.1) powerpack (~> 0.1)
psych (>= 3.1.0)
rainbow (>= 2.2.2, < 4.0) rainbow (>= 2.2.2, < 4.0)
ruby-progressbar (~> 1.7) ruby-progressbar (~> 1.7)
unicode-display_width (~> 1.4.0) unicode-display_width (~> 1.4.0)
@ -580,7 +582,7 @@ GEM
unf (0.1.4) unf (0.1.4)
unf_ext unf_ext
unf_ext (0.0.7.5) unf_ext (0.0.7.5)
unicode-display_width (1.4.0) unicode-display_width (1.4.1)
unicode_utils (1.4.0) unicode_utils (1.4.0)
unobtrusive_flash (3.3.1) unobtrusive_flash (3.3.1)
railties railties