From 8872d9e6c8d3c2cd00394fab6c553c158405477e Mon Sep 17 00:00:00 2001 From: "depfu[bot]" Date: Fri, 8 Mar 2019 13:21:25 +0000 Subject: [PATCH 1/2] Update rubocop to version 0.65.0 --- Gemfile.lock | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index 29d27c7a..73acb733 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -242,7 +242,7 @@ GEM loggability (~> 0.12) io-like (0.3.0) iso-639 (0.2.8) - jaro_winkler (1.5.1) + jaro_winkler (1.5.2) jquery-datatables-rails (3.4.0) actionpack (>= 3.1) jquery-rails @@ -342,8 +342,8 @@ GEM paper_trail (10.1.0) activerecord (>= 4.2, < 6.0) request_store (~> 1.1) - parallel (1.12.1) - parser (2.5.3.0) + parallel (1.14.0) + parser (2.6.0.0) ast (~> 2.4.0) pdf-core (0.7.0) pdf-inspector (1.3.0) @@ -373,6 +373,7 @@ GEM coderay (~> 1.1.0) method_source (~> 0.8.1) slop (~> 3.4) + psych (3.1.0) public_suffix (3.0.3) puma (3.12.0) rack (2.0.6) @@ -488,11 +489,12 @@ GEM rspec-mocks (~> 3.6.0) rspec-support (~> 3.6.0) rspec-support (3.6.0) - rubocop (0.61.1) + rubocop (0.65.0) jaro_winkler (~> 1.5.1) parallel (~> 1.10) parser (>= 2.5, != 2.5.1.1) powerpack (~> 0.1) + psych (>= 3.1.0) rainbow (>= 2.2.2, < 4.0) ruby-progressbar (~> 1.7) unicode-display_width (~> 1.4.0) @@ -580,7 +582,7 @@ GEM unf (0.1.4) unf_ext unf_ext (0.0.7.5) - unicode-display_width (1.4.0) + unicode-display_width (1.4.1) unicode_utils (1.4.0) unobtrusive_flash (3.3.1) railties From 78c5401eaad6542bd6d495b332bf29f84580f728 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ana=20Mar=C3=ADa=20Mart=C3=ADnez=20G=C3=B3mez?= Date: Fri, 8 Mar 2019 16:35:55 +0100 Subject: [PATCH 2/2] Regenerate the todo file after the Rubocop update Generated automatically by running: ``` bundle exec rubocop --auto-gen-config --auto-gen-only-exclude ``` --- .rubocop_todo.yml | 267 +++++++++++++++++++++++++--------------------- 1 file changed, 144 insertions(+), 123 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 714645c5..d7c30a27 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2018-09-08 03:47:39 +0200 using RuboCop version 0.58.2. +# on 2019-03-08 16:06:53 +0000 using RuboCop version 0.65.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 381 +# Offense count: 351 Capybara/CurrentPathExpectation: Exclude: - 'spec/features/base_controller_spec.rb' @@ -23,17 +23,12 @@ Capybara/CurrentPathExpectation: - 'spec/features/track_organizer_ability_spec.rb' - 'spec/features/user_ability_spec.rb' -# Offense count: 170 +# Offense count: 161 # Cop supports --auto-correct. # Configuration parameters: EnabledMethods. Capybara/FeatureMethods: Enabled: false -# Offense count: 140 -# Cop supports --auto-correct. -FactoryBot/AttributeDefinedStatically: - Enabled: false - # Offense count: 4 # Cop supports --auto-correct. Layout/ClosingParenthesisIndentation: @@ -67,7 +62,7 @@ Layout/EmptyLineAfterMagicComment: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 121 +# Offense count: 117 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines @@ -80,7 +75,7 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords: Exclude: - 'app/models/payment.rb' -# Offense count: 51 +# Offense count: 52 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment. Layout/ExtraSpacing: @@ -98,7 +93,7 @@ Layout/ExtraSpacing: - 'db/schema.rb' - 'spec/models/conference_spec.rb' -# Offense count: 47 +# Offense count: 43 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses @@ -113,13 +108,12 @@ Layout/IndentArray: Exclude: - 'app/models/conference.rb' -# Offense count: 6 +# Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: IndentationWidth. Layout/IndentAssignment: Exclude: - 'app/helpers/format_helper.rb' - - 'app/models/conference.rb' - 'config/environments/development.rb' # Offense count: 4 @@ -149,13 +143,12 @@ Layout/IndentationWidth: Exclude: - 'app/controllers/users_controller.rb' -# Offense count: 5 +# Offense count: 4 # Cop supports --auto-correct. Layout/LeadingCommentSpace: Exclude: - 'Guardfile' - 'app/models/comment.rb' - - 'config/deploy.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -181,14 +174,14 @@ Layout/MultilineHashBraceLayout: - 'config/routes.rb' - 'spec/models/event_spec.rb' -# Offense count: 40 +# Offense count: 36 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: Enabled: false -# Offense count: 56 +# Offense count: 53 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented, indented_relative_to_receiver @@ -244,7 +237,7 @@ Layout/SpaceAroundOperators: - 'config/initializers/airbrake.rb' - 'lib/tasks/data.rake' -# Offense count: 487 +# Offense count: 138 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space @@ -294,20 +287,19 @@ Layout/SpaceInsideBlockBraces: - 'app/models/ticket.rb' - 'app/models/user.rb' - 'lib/tasks/events_registrations.rake' + - 'spec/ability/ability_spec.rb' - 'spec/controllers/admin/event_schedules_controller_spec.rb' - 'spec/controllers/admin/schedules_controller_spec.rb' - 'spec/features/splashpage_spec.rb' - - 'spec/ability/ability_spec.rb' - 'spec/models/user_spec.rb' -# Offense count: 39 +# Offense count: 37 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact # SupportedStylesForEmptyBraces: space, no_space Layout/SpaceInsideHashLiteralBraces: Exclude: - - 'app/controllers/admin/conferences_controller.rb' - 'app/controllers/api/v1/speakers_controller.rb' - 'app/models/conference.rb' - 'app/models/event_type.rb' @@ -331,13 +323,11 @@ Layout/SpaceInsideParens: Exclude: - 'app/views/admin/registrations/index.xlsx.axlsx' -# Offense count: 5 +# Offense count: 2 # Cop supports --auto-correct. Layout/SpaceInsidePercentLiteralDelimiters: Exclude: - 'Gemfile' - - 'config/deploy.rb' - - 'config/initializers/assets.rb' # Offense count: 2 # Cop supports --auto-correct. @@ -412,45 +402,64 @@ Lint/UnusedMethodArgument: Exclude: - 'config/initializers/fuckups.rb' -# Offense count: 142 +# Offense count: 138 Metrics/AbcSize: - Max: 94 + Max: 74 -# Offense count: 331 +# Offense count: 312 # Configuration parameters: CountComments, ExcludedMethods. # ExcludedMethods: refine Metrics/BlockLength: - Max: 1419 + Max: 1347 # Offense count: 1 -# Configuration parameters: CountBlocks. +# Configuration parameters: CountBlocks, Max. Metrics/BlockNesting: - Max: 4 + Exclude: + - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' # Offense count: 13 -# Configuration parameters: CountComments. +# Configuration parameters: CountComments, Max. Metrics/ClassLength: - Max: 684 + Exclude: + - 'app/controllers/admin/booths_controller.rb' + - 'app/controllers/admin/conferences_controller.rb' + - 'app/controllers/admin/events_controller.rb' + - 'app/controllers/admin/tracks_controller.rb' + - 'app/controllers/proposals_controller.rb' + - 'app/mailers/mailbot.rb' + - 'app/models/ability.rb' + - 'app/models/admin_ability.rb' + - 'app/models/conference.rb' + - 'app/models/event.rb' + - 'app/models/program.rb' + - 'app/models/track.rb' + - 'app/models/user.rb' -# Offense count: 32 +# Offense count: 33 Metrics/CyclomaticComplexity: Max: 14 -# Offense count: 146 -# Configuration parameters: CountComments. +# Offense count: 147 +# Configuration parameters: CountComments, ExcludedMethods. Metrics/MethodLength: - Max: 60 + Max: 56 # Offense count: 5 -# Configuration parameters: CountComments. +# Configuration parameters: CountComments, Max. Metrics/ModuleLength: - Max: 173 + Exclude: + - 'app/helpers/application_helper.rb' + - 'app/helpers/events_helper.rb' + - 'app/helpers/format_helper.rb' + - 'app/helpers/versions_helper.rb' + - 'spec/support/omniauth_macros.rb' # Offense count: 22 Metrics/PerceivedComplexity: Max: 16 -# Offense count: 17 +# Offense count: 13 Naming/AccessorMethodName: Exclude: - 'app/models/conference.rb' @@ -478,7 +487,7 @@ Naming/PredicateName: # Offense count: 2 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: io, id, to, by, on, in, at, ip +# AllowedNames: io, id, to, by, on, in, at, ip, db Naming/UncommunicativeMethodParamName: Exclude: - 'app/models/conference.rb' @@ -497,7 +506,7 @@ Performance/InefficientHashSearch: - 'app/controllers/admin/versions_controller.rb' - 'app/helpers/versions_helper.rb' -# Offense count: 31 +# Offense count: 28 RSpec/AnyInstance: Exclude: - 'spec/controllers/admin/rooms_controller_spec.rb' @@ -508,13 +517,13 @@ RSpec/AnyInstance: - 'spec/controllers/proposals_controller_spec.rb' - 'spec/controllers/tracks_controller_spec.rb' -# Offense count: 327 +# Offense count: 314 # Configuration parameters: Prefixes. # Prefixes: when, with, without RSpec/ContextWording: Enabled: false -# Offense count: 73 +# Offense count: 68 # Cop supports --auto-correct. # Configuration parameters: SkipBlocks, EnforcedStyle. # SupportedStyles: described_class, explicit @@ -536,7 +545,7 @@ RSpec/EmptyLineAfterExampleGroup: Exclude: - 'spec/controllers/admin/users_controller_spec.rb' -# Offense count: 12 +# Offense count: 11 # Cop supports --auto-correct. RSpec/EmptyLineAfterFinalLet: Exclude: @@ -544,7 +553,6 @@ RSpec/EmptyLineAfterFinalLet: - 'spec/controllers/admin/users_controller_spec.rb' - 'spec/controllers/application_controller_spec.rb' - 'spec/features/conference_spec.rb' - - 'spec/models/admin_ability_spec.rb' - 'spec/models/conference_spec.rb' - 'spec/models/payment_spec.rb' - 'spec/models/ticket_spec.rb' @@ -564,12 +572,11 @@ RSpec/EmptyLineAfterHook: - 'spec/models/payment_spec.rb' - 'spec/models/program_spec.rb' -# Offense count: 9 +# Offense count: 8 # Cop supports --auto-correct. RSpec/EmptyLineAfterSubject: Exclude: - 'spec/ability/ability_spec.rb' - - 'spec/models/admin_ability_spec.rb' - 'spec/models/booth_spec.rb' - 'spec/models/cfp_spec.rb' - 'spec/models/event_spec.rb' @@ -578,7 +585,7 @@ RSpec/EmptyLineAfterSubject: - 'spec/models/survey_spec.rb' - 'spec/models/track_spec.rb' -# Offense count: 230 +# Offense count: 219 # Configuration parameters: Max. RSpec/ExampleLength: Enabled: false @@ -599,7 +606,7 @@ RSpec/ExampleWording: - 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_spec.rb' -# Offense count: 38 +# Offense count: 37 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: method_call, block @@ -629,28 +636,41 @@ RSpec/FilePath: - 'spec/models/comment_spec.rb' - 'spec/models/openid.rb' -# Offense count: 174 +# Offense count: 170 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, each, example RSpec/HookArgument: Enabled: false -# Offense count: 499 +# Offense count: 140 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: is_expected, should RSpec/ImplicitExpect: - Enabled: false + Exclude: + - 'spec/ability/ability_spec.rb' + - 'spec/models/commercial_spec.rb' + - 'spec/models/conference_spec.rb' + - 'spec/models/event_schedule_spec.rb' + - 'spec/models/event_type_spec.rb' + - 'spec/models/organization_spec.rb' + - 'spec/models/registration_period_spec.rb' + - 'spec/models/room_spec.rb' + - 'spec/models/schedule_spec.rb' + - 'spec/models/sponsor_spec.rb' + - 'spec/models/sponsorship_level_spec.rb' + - 'spec/models/ticket_purchase_spec.rb' + - 'spec/models/ticket_spec.rb' + - 'spec/models/user_spec.rb' -# Offense count: 48 +# Offense count: 39 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. -# SupportedStyles: single_line_only, disallow +# SupportedStyles: single_line_only, single_statement_only, disallow RSpec/ImplicitSubject: Exclude: - 'spec/ability/ability_spec.rb' - - 'spec/models/admin_ability_spec.rb' - 'spec/models/booth_spec.rb' - 'spec/models/conference_spec.rb' - 'spec/models/event_type_spec.rb' @@ -661,21 +681,35 @@ RSpec/ImplicitSubject: - 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_spec.rb' -# Offense count: 347 +# Offense count: 321 # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: - Enabled: false + Exclude: + - 'spec/controllers/admin/sponsorship_levels_controller_spec.rb' + - 'spec/controllers/admin/versions_controller_spec.rb' + - 'spec/controllers/api/v1/conferences_controller_spec.rb' + - 'spec/controllers/application_controller_spec.rb' + - 'spec/controllers/conference_registration_controller_spec.rb' + - 'spec/controllers/conferences_controller_spec.rb' + - 'spec/controllers/confirmations_controller_spec.rb' + - 'spec/controllers/proposals_controller_spec.rb' + - 'spec/features/proposals_spec.rb' + - 'spec/helpers/application_helper_spec.rb' + - 'spec/models/conference_spec.rb' + - 'spec/models/event_schedule_spec.rb' + - 'spec/models/sponsorship_level_spec.rb' + - 'spec/models/track_spec.rb' + - 'spec/models/user_spec.rb' -# Offense count: 5 +# Offense count: 4 # Cop supports --auto-correct. RSpec/LeadingSubject: Exclude: - 'spec/ability/ability_spec.rb' - - 'spec/models/admin_ability_spec.rb' - 'spec/models/conference_spec.rb' - 'spec/models/ticket_spec.rb' -# Offense count: 51 +# Offense count: 50 RSpec/LetSetup: Enabled: false @@ -690,12 +724,12 @@ RSpec/MultipleDescribes: Exclude: - 'spec/controllers/application_controller_spec.rb' -# Offense count: 283 +# Offense count: 278 # Configuration parameters: AggregateFailuresByDefault. RSpec/MultipleExpectations: - Max: 106 + Max: 97 -# Offense count: 403 +# Offense count: 387 RSpec/NamedSubject: Exclude: - 'spec/models/conference_spec.rb' @@ -703,11 +737,11 @@ RSpec/NamedSubject: - 'spec/models/room_spec.rb' - 'spec/models/track_spec.rb' -# Offense count: 213 +# Offense count: 206 RSpec/NestedGroups: Max: 7 -# Offense count: 93 +# Offense count: 85 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: not_to, to_not @@ -737,7 +771,7 @@ RSpec/RepeatedExample: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 13 +# Offense count: 10 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: and_return, block @@ -745,11 +779,10 @@ RSpec/ReturnFromStub: Exclude: - 'spec/helpers/events_helper_spec.rb' -# Offense count: 49 +# Offense count: 19 RSpec/ScatteredLet: Exclude: - 'spec/ability/ability_spec.rb' - - 'spec/models/admin_ability_spec.rb' - 'spec/models/payment_spec.rb' # Offense count: 2 @@ -764,8 +797,8 @@ RSpec/SubjectStub: - 'spec/models/room_spec.rb' - 'spec/models/track_spec.rb' -# Offense count: 1 -# Configuration parameters: IgnoreSymbolicNames. +# Offense count: 3 +# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames. RSpec/VerifiedDoubles: Exclude: - 'spec/datatables/user_datatable_spec.rb' @@ -785,12 +818,12 @@ Rails/ActionFilter: Exclude: - 'app/controllers/users/omniauth_callbacks_controller.rb' -# Offense count: 107 +# Offense count: 103 # Cop supports --auto-correct. Rails/ActiveRecordAliases: Enabled: false -# Offense count: 128 +# Offense count: 129 # Cop supports --auto-correct. Rails/ApplicationRecord: Enabled: false @@ -812,7 +845,7 @@ Rails/Blank: Rails/CreateTableWithTimestamps: Enabled: false -# Offense count: 126 +# Offense count: 111 # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/Date: @@ -870,7 +903,7 @@ Rails/HasAndBelongsToMany: - 'app/models/registration.rb' - 'app/models/vchoice.rb' -# Offense count: 20 +# Offense count: 19 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -890,7 +923,7 @@ Rails/HasManyOrHasOneDependent: - 'app/models/vday.rb' - 'app/models/vposition.rb' -# Offense count: 256 +# Offense count: 249 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: spec/**/*, test/**/* @@ -915,6 +948,12 @@ Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/registrations_controller.rb' +# Offense count: 1 +# Cop supports --auto-correct. +Rails/LinkToBlank: + Exclude: + - 'app/helpers/format_helper.rb' + # Offense count: 1 # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb @@ -943,7 +982,7 @@ Rails/Presence: - 'app/helpers/application_helper.rb' - 'app/models/user.rb' -# Offense count: 23 +# Offense count: 18 # Cop supports --auto-correct. # Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. Rails/Present: @@ -977,7 +1016,7 @@ Rails/ReversibleMigration: - 'db/migrate/20141130182139_drop_table_event_attachments.rb' # Offense count: 8 -# Configuration parameters: Blacklist. +# Configuration parameters: Blacklist, Whitelist. # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters Rails/SkipsModelValidations: Exclude: @@ -989,7 +1028,7 @@ Rails/SkipsModelValidations: - 'lib/tasks/user.rake' - 'spec/controllers/conferences_controller_spec.rb' -# Offense count: 51 +# Offense count: 49 # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: @@ -1005,18 +1044,11 @@ Rails/TimeZone: - 'spec/factories/users.rb' - 'spec/models/conference_spec.rb' -# Offense count: 2 +# Offense count: 3 Security/Open: Exclude: - 'app/pdfs/ticket_pdf.rb' -# Offense count: 2 -# Configuration parameters: EnforcedStyle. -# SupportedStyles: inline, group -Style/AccessModifierDeclarations: - Exclude: - - 'spec/factories/splashpages.rb' - # Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. @@ -1037,27 +1069,18 @@ Style/ColonMethodCall: - 'app/models/commercial.rb' - 'app/models/contact.rb' -# Offense count: 5 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. # SupportedStyles: assign_to_condition, assign_inside_condition Style/ConditionalAssignment: Exclude: - 'app/helpers/format_helper.rb' - - 'config/environments/production.rb' - 'config/initializers/airbrake.rb' - 'db/migrate/20140610165551_migrate_data_person_to_user.rb' - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' -# Offense count: 11 -Style/DateTime: - Exclude: - - 'app/models/conference.rb' - - 'app/models/program.rb' - - 'spec/models/conference_spec.rb' - - 'spec/models/program_spec.rb' - -# Offense count: 514 +# Offense count: 516 Style/Documentation: Enabled: false @@ -1079,7 +1102,7 @@ Style/EmptyLiteral: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 9 +# Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: compact, expanded @@ -1116,19 +1139,19 @@ Style/ExpandPathArguments: - 'config/environment.rb' - 'spec/spec_helper.rb' -# Offense count: 44 +# Offense count: 49 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: when_needed, always, never Style/FrozenStringLiteralComment: Enabled: false -# Offense count: 30 +# Offense count: 29 # Configuration parameters: MinBodyLength. Style/GuardClause: Enabled: false -# Offense count: 8 +# Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -1139,7 +1162,7 @@ Style/HashSyntax: - 'app/views/admin/registrations/index.xlsx.axlsx' - 'lib/tasks/user.rake' -# Offense count: 61 +# Offense count: 58 # Cop supports --auto-correct. Style/IfUnlessModifier: Enabled: false @@ -1148,7 +1171,6 @@ Style/IfUnlessModifier: # Cop supports --auto-correct. Style/LineEndConcatenation: Exclude: - - 'spec/features/cfp_spec.rb' - 'spec/features/conference_spec.rb' - 'spec/features/registration_periods_spec.rb' @@ -1182,6 +1204,8 @@ Style/MultilineIfModifier: # Offense count: 2 # Cop supports --auto-correct. +# Configuration parameters: EnforcedStyle. +# SupportedStyles: literals, strict Style/MutableConstant: Exclude: - 'app/models/event_user.rb' @@ -1203,7 +1227,7 @@ Style/NestedParenthesizedCalls: Style/Next: Enabled: false -# Offense count: 121 +# Offense count: 120 # Cop supports --auto-correct. # Configuration parameters: EnforcedOctalStyle. # SupportedOctalStyles: zero_with_o, zero_only @@ -1220,13 +1244,18 @@ Style/NumericLiteralPrefix: # Offense count: 8 # Cop supports --auto-correct. -# Configuration parameters: Strict. +# Configuration parameters: MinDigits, Strict. Style/NumericLiterals: - MinDigits: 15 + Exclude: + - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' + - 'db/schema.rb' + - 'lib/tasks/events_registrations.rake' + - 'spec/features/versions_spec.rb' + - 'spec/models/ticket_spec.rb' -# Offense count: 41 +# Offense count: 36 # Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, EnforcedStyle. +# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison Style/NumericPredicate: Exclude: @@ -1264,7 +1293,7 @@ Style/ParenthesesAroundCondition: - 'app/controllers/application_controller.rb' - 'app/helpers/format_helper.rb' -# Offense count: 28 +# Offense count: 22 # Cop supports --auto-correct. # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: @@ -1297,15 +1326,15 @@ Style/RedundantParentheses: Exclude: - 'app/controllers/admin/base_controller.rb' -# Offense count: 3 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, AllowInnerSlashes. # SupportedStyles: slashes, percent_r, mixed Style/RegexpLiteral: Exclude: - 'Guardfile' - - 'config/initializers/airbrake.rb' - 'app/uploaders/picture_uploader.rb' + - 'config/initializers/airbrake.rb' # Offense count: 2 # Cop supports --auto-correct. @@ -1332,7 +1361,7 @@ Style/SingleLineMethods: Exclude: - 'Guardfile' -# Offense count: 672 +# Offense count: 611 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes @@ -1343,9 +1372,7 @@ Style/StringLiterals: - 'bin/spring' - 'config/deploy.rb' - 'config/environments/production.rb' - - 'config/initializers/devise.rb' - 'config/puma.rb' - - 'config/routes.rb' - 'db/schema.rb' - 'lib/tasks/dump_db.rake' - 'lib/tasks/events_registrations.rake' @@ -1363,19 +1390,13 @@ Style/StringLiteralsInInterpolation: - 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - 'lib/tasks/dump_db.rake' -# Offense count: 109 +# Offense count: 110 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinSize. # SupportedStyles: percent, brackets Style/SymbolArray: Enabled: false -# Offense count: 1 -# Cop supports --auto-correct. -Style/SymbolLiteral: - Exclude: - - 'config/deploy.rb' - # Offense count: 10 # Cop supports --auto-correct. # Configuration parameters: IgnoredMethods. @@ -1428,7 +1449,7 @@ Style/UnneededCondition: - 'app/helpers/versions_helper.rb' - 'app/models/ticket.rb' -# Offense count: 8 +# Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: WordRegex. # SupportedStyles: percent, brackets @@ -1436,7 +1457,7 @@ Style/WordArray: EnforcedStyle: percent MinSize: 8 -# Offense count: 3041 +# Offense count: 2887 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: