gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Don't require support/external_request from rake tasks

Browse source 
If we require this we're requiring everything that
support/external_request requires for production.
This commit is contained in:
Henne Vogelsang 2016-03-09 13:32:43 +01:00
parent fd8dbfe7a7
commit 9c2ef19741
2 changed files with 2 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Gemfile
View file

@ -159,9 +159,6 @@ gem 'bootstrap-switch-rails', '~> 3.0.0'
# for parsing OEmbed data # for parsing OEmbed data
gem 'ruby-oembed' gem 'ruby-oembed'
# for mocking external requests
gem 'webmock'
# Use guard and spring for testing in development # Use guard and spring for testing in development
group :development do group :development do
# rspec Guard rules # rspec Guard rules
@ -196,6 +193,8 @@ group :test do
# Extracted from RSpec 3 stub_model and mock_model # Extracted from RSpec 3 stub_model and mock_model
gem 'rspec-activemodel-mocks' gem 'rspec-activemodel-mocks'
gem 'timecop' gem 'timecop'
# for mocking external requests
gem 'webmock'
end end
group :development, :test do group :development, :test do

3
lib/tasks/factory_girl.rake
View file

@ -1,12 +1,9 @@
require_relative '../../spec/support/external_request'
namespace :factory_girl do namespace :factory_girl do
desc "Verify that all FactoryGirl factories are valid" desc "Verify that all FactoryGirl factories are valid"
task lint: :environment do task lint: :environment do
if Rails.env.test? if Rails.env.test?
begin begin
DatabaseCleaner.start DatabaseCleaner.start
mock_commercial_request
FactoryGirl.lint FactoryGirl.lint
ensure ensure
DatabaseCleaner.clean DatabaseCleaner.clean