From 9c2ef197413e99a1b26de460da3cf10ce48561a0 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Wed, 9 Mar 2016 13:32:43 +0100 Subject: [PATCH] Don't require support/external_request from rake tasks If we require this we're requiring everything that support/external_request requires for production. --- Gemfile | 5 ++--- lib/tasks/factory_girl.rake | 3 --- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/Gemfile b/Gemfile index a5af02f4..e7593f2f 100644 --- a/Gemfile +++ b/Gemfile @@ -159,9 +159,6 @@ gem 'bootstrap-switch-rails', '~> 3.0.0' # for parsing OEmbed data gem 'ruby-oembed' -# for mocking external requests -gem 'webmock' - # Use guard and spring for testing in development group :development do # rspec Guard rules @@ -196,6 +193,8 @@ group :test do # Extracted from RSpec 3 stub_model and mock_model gem 'rspec-activemodel-mocks' gem 'timecop' + # for mocking external requests + gem 'webmock' end group :development, :test do diff --git a/lib/tasks/factory_girl.rake b/lib/tasks/factory_girl.rake index b922b0ef..bccc1b66 100644 --- a/lib/tasks/factory_girl.rake +++ b/lib/tasks/factory_girl.rake @@ -1,12 +1,9 @@ -require_relative '../../spec/support/external_request' - namespace :factory_girl do desc "Verify that all FactoryGirl factories are valid" task lint: :environment do if Rails.env.test? begin DatabaseCleaner.start - mock_commercial_request FactoryGirl.lint ensure DatabaseCleaner.clean