Merge pull request #1498 from divyanshumehta/issue_1497

Added Style/SpaceInsideBrackets Rubocop cop
This commit is contained in:
Ana María Martínez Gómez 2017-06-12 17:45:30 +02:00 committed by GitHub
commit 53040b3be9
5 changed files with 8 additions and 11 deletions

View file

@ -88,6 +88,10 @@ Style/RedundantSelf:
Style/SpaceAroundOperators: Style/SpaceAroundOperators:
Enabled: true Enabled: true
# Checks for spaces inside square brackets.
Style/SpaceInsideBrackets:
Enabled: true
# Use single quotes unless there's string interpolation # Use single quotes unless there's string interpolation
Style/StringLiterals: Style/StringLiterals:
Enabled: true Enabled: true

View file

@ -813,13 +813,6 @@ Style/SpaceInsideBlockBraces:
- 'spec/models/ability_spec.rb' - 'spec/models/ability_spec.rb'
- 'spec/models/user_spec.rb' - 'spec/models/user_spec.rb'
# Offense count: 5
# Cop supports --auto-correct.
Style/SpaceInsideBrackets:
Exclude:
- 'app/models/conference.rb'
- 'app/models/user.rb'
# Offense count: 25 # Offense count: 25
# Cop supports --auto-correct. # Cop supports --auto-correct.
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces.

View file

@ -152,7 +152,7 @@ module ApplicationHelper
end end
def speaker_links(event) def speaker_links(event)
event.speakers.map{ |speaker| link_to speaker.name, admin_user_path(speaker) }.join(', ').html_safe safe_join(event.speakers.map{ |speaker| link_to speaker.name, admin_user_path(speaker) }, ',')
end end
def speaker_selector_input(form) def speaker_selector_input(form)