diff --git a/.rubocop.yml b/.rubocop.yml index de234a2a..9f7f0d00 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -88,6 +88,10 @@ Style/RedundantSelf: Style/SpaceAroundOperators: Enabled: true +# Checks for spaces inside square brackets. +Style/SpaceInsideBrackets: + Enabled: true + # Use single quotes unless there's string interpolation Style/StringLiterals: Enabled: true diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index e70a8709..1544c6f2 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -813,13 +813,6 @@ Style/SpaceInsideBlockBraces: - 'spec/models/ability_spec.rb' - 'spec/models/user_spec.rb' -# Offense count: 5 -# Cop supports --auto-correct. -Style/SpaceInsideBrackets: - Exclude: - - 'app/models/conference.rb' - - 'app/models/user.rb' - # Offense count: 25 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SupportedStylesForEmptyBraces. diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 0efe5321..fe81dfad 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -152,7 +152,7 @@ module ApplicationHelper end def speaker_links(event) - event.speakers.map{ |speaker| link_to speaker.name, admin_user_path(speaker) }.join(', ').html_safe + safe_join(event.speakers.map{ |speaker| link_to speaker.name, admin_user_path(speaker) }, ',') end def speaker_selector_input(form) diff --git a/app/models/conference.rb b/app/models/conference.rb index 2f623a4c..2ae6eabd 100644 --- a/app/models/conference.rb +++ b/app/models/conference.rb @@ -896,7 +896,7 @@ class Conference < ActiveRecord::Base hash[key] = 0 end end - Hash[ hash.sort ] + Hash[hash.sort] end ## diff --git a/app/models/user.rb b/app/models/user.rb index a63d721e..4be77fe8 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -26,11 +26,11 @@ class User < ActiveRecord::Base devise_modules = [] if ENV['OSEM_ICHAIN_ENABLED'] == 'true' - devise_modules += [ :ichain_authenticatable, :ichain_registerable, :omniauthable, omniauth_providers: [] ] + devise_modules += [:ichain_authenticatable, :ichain_registerable, :omniauthable, omniauth_providers: []] else devise_modules += [:database_authenticatable, :registerable, :recoverable, :rememberable, :trackable, :validatable, :confirmable, - :omniauthable, omniauth_providers: [:suse, :google, :facebook, :github] ] + :omniauthable, omniauth_providers: [:suse, :google, :facebook, :github]] end devise(*devise_modules)