gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix up spec to properly pass under expectations

Browse source
This commit is contained in:
CactusPuppy 2021-03-17 15:06:24 -07:00
parent 125c17838c
commit 0f6881414b
No known key found for this signature in database
GPG key ID: 4B33B0A3E15E2C82
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
app/helpers/external/mailbluster_helper.rb vendored
View file

@ -21,7 +21,7 @@ module External
'tags' => ['snapcon'] 'tags' => ['snapcon']
}.to_json }.to_json
response = http.request(request) response = http.request(request)
response.to_json response.body
rescue StandardError => e rescue StandardError => e
puts "ERROR #{e}" puts "ERROR #{e}"
nil nil
@ -34,7 +34,7 @@ module External
request = Net::HTTP::Delete.new(uri.path, request = Net::HTTP::Delete.new(uri.path,
'Authorization' => ENV['MAILBLUSTER_API_KEY']) 'Authorization' => ENV['MAILBLUSTER_API_KEY'])
response = http.request(request) response = http.request(request)
response.to_json response.body
rescue StandardError => e rescue StandardError => e
puts "ERROR #{e}" puts "ERROR #{e}"
nil nil

6
spec/helpers/external/mailbluster_helper_spec.rb vendored
View file

@ -5,7 +5,7 @@ require 'webmock/rspec'
describe External::MailblusterHelper, type: :helper do describe External::MailblusterHelper, type: :helper do
let!(:user) { create(:user) } let!(:user) { create(:user) }
url = 'https://api.mailbluster.com/api/leads/' url = 'http://api.mailbluster.com:443/api/leads/'
describe 'create_lead' do describe 'create_lead' do
it 'makes a post request to Mailbluster\'s API and gets the correct response' do it 'makes a post request to Mailbluster\'s API and gets the correct response' do
@ -27,7 +27,7 @@ describe External::MailblusterHelper, type: :helper do
.to_return(body: response_body, status: 200) .to_return(body: response_body, status: 200)
response = create_lead(user) response = create_lead(user)
expect(WebMock).to have_requested(:post, 'api.mailbluster.com/api/leads').with(body: { expect(WebMock).to have_requested(:post, url).with(body: {
'email': user.email, 'email': user.email,
'firstName': user.name, 'firstName': user.name,
'overrideExisting': true, 'overrideExisting': true,
@ -44,7 +44,7 @@ describe External::MailblusterHelper, type: :helper do
response_body = "{ response_body = "{
\"message\":\"Lead deleted\", \"message\":\"Lead deleted\",
\"leadHash\":\"#{email_hash}\" \"leadHash\":\"#{email_hash}\"
}" }"
lead_url = url + email_hash.to_s lead_url = url + email_hash.to_s
stub_request(:delete, lead_url) stub_request(:delete, lead_url)
.to_return(body: response_body) .to_return(body: response_body)