From 0f6881414bd5212704321c32b71cdb66b06a59f8 Mon Sep 17 00:00:00 2001 From: CactusPuppy Date: Wed, 17 Mar 2021 15:06:24 -0700 Subject: [PATCH] Fix up spec to properly pass under expectations --- app/helpers/external/mailbluster_helper.rb | 4 ++-- spec/helpers/external/mailbluster_helper_spec.rb | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/app/helpers/external/mailbluster_helper.rb b/app/helpers/external/mailbluster_helper.rb index e7fb1788..d00f7afa 100644 --- a/app/helpers/external/mailbluster_helper.rb +++ b/app/helpers/external/mailbluster_helper.rb @@ -21,7 +21,7 @@ module External 'tags' => ['snapcon'] }.to_json response = http.request(request) - response.to_json + response.body rescue StandardError => e puts "ERROR #{e}" nil @@ -34,7 +34,7 @@ module External request = Net::HTTP::Delete.new(uri.path, 'Authorization' => ENV['MAILBLUSTER_API_KEY']) response = http.request(request) - response.to_json + response.body rescue StandardError => e puts "ERROR #{e}" nil diff --git a/spec/helpers/external/mailbluster_helper_spec.rb b/spec/helpers/external/mailbluster_helper_spec.rb index 6c3f1731..7371ba21 100644 --- a/spec/helpers/external/mailbluster_helper_spec.rb +++ b/spec/helpers/external/mailbluster_helper_spec.rb @@ -5,7 +5,7 @@ require 'webmock/rspec' describe External::MailblusterHelper, type: :helper do let!(:user) { create(:user) } - url = 'https://api.mailbluster.com/api/leads/' + url = 'http://api.mailbluster.com:443/api/leads/' describe 'create_lead' do it 'makes a post request to Mailbluster\'s API and gets the correct response' do @@ -27,7 +27,7 @@ describe External::MailblusterHelper, type: :helper do .to_return(body: response_body, status: 200) response = create_lead(user) - expect(WebMock).to have_requested(:post, 'api.mailbluster.com/api/leads').with(body: { + expect(WebMock).to have_requested(:post, url).with(body: { 'email': user.email, 'firstName': user.name, 'overrideExisting': true, @@ -44,7 +44,7 @@ describe External::MailblusterHelper, type: :helper do response_body = "{ \"message\":\"Lead deleted\", \"leadHash\":\"#{email_hash}\" - }" + }" lead_url = url + email_hash.to_s stub_request(:delete, lead_url) .to_return(body: response_body)