Commit graph

80 commits

Author SHA1 Message Date
Henne Vogelsang
9e36aa9721
Regenerate rubocop TODO 2023-05-08 13:46:49 +02:00
Henne Vogelsang
85cae7d093
Merge pull request #2970 from AndrewKvalheim/safe_links_only
Correct use of Redcarpet’s `safe_links_only` flag
2022-03-29 15:11:58 +02:00
Andrew Kvalheim
685d79e44b Correct use of Redcarpet’s safe_links_only flag 2022-03-17 17:03:30 -07:00
Andrew Kvalheim
c052516009 Grant conference organizers permission to manage surveys
Resolves:

    Failures:

      1) Survey as an organizer create a survey
         Failure/Error: click_link 'New'

         Capybara::ElementNotFound:
           Unable to find link "New"
         # ./spec/features/surveys_spec.rb:18:in `block (3 levels) in <top (required)>'

    Failed examples:

    rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
2022-03-16 13:37:00 -07:00
Henne Vogelsang
800bb28c34
Drop formtastic
formtastic-bootstrap is unmaintained since years, formtastic is
just syntactic sugar, ActionView grew up to be beautiful.
2022-02-23 14:36:07 +01:00
Henne Vogelsang
f3815ad543
Update rubocop to 1.25.1 2022-02-22 19:22:25 +01:00
depfu[bot]
8b9e4d1288
Update rubocop-rspec to version 2.4.0 2021-08-13 15:01:27 +02:00
Andrew Kvalheim
162e0f720f
Exclude Rails database schema from linting
The schema is automatically generated, so RuboCop's recommendations are
non-actionable; ignore it as in rubocop-hq/rubocop#752.
2021-03-06 19:33:28 +01:00
Espartaco Palma
5d79049e59
Linters gonna lint
I was not aware the linting was also applied to specs
2021-03-06 19:09:38 +01:00
James Mason
82f42244c0
Update rubocop TODOs based on new version 2019-10-16 20:31:36 -07:00
Ana María Martínez Gómez
33e11e3efa
Regenerate the todo file
It is a good idea to do this once in a while, so that files that used to
have offenses but don't have them anymore are not excluded and to
decrease the maximums in the metric cops.
2019-04-29 16:36:15 +02:00
Ana María Martínez Gómez
78c5401eaa
Regenerate the todo file after the Rubocop update
Generated automatically by running:

```
bundle exec rubocop --auto-gen-config --auto-gen-only-exclude
```
2019-03-08 17:07:13 +01:00
Ana María Martínez Gómez
0aa49e9c64 Get rid of vagrant
We are using Docker now instead.

Closes https://github.com/openSUSE/osem/issues/1213
2019-02-26 16:30:56 +01:00
James Mason
072116fffe Enable registration to proceed without requiring a ticket.
Requiring a ticket after registration is convoluted; while it may be neccesary
for some workflows, it definitely isn't for others, and the core of osem
doesn't need it... so let's make it optional.
2019-02-16 00:53:40 +01:00
James Mason
41c2995cff test for missing logo 2018-12-19 12:30:45 -08:00
James Mason
9f84454a8d Uploader changes based on https://github.com/carrierwaveuploader/carrierwave 2018-11-14 13:29:39 -08:00
James Mason
8b12b1662d Unlint Rspec/DescibeClass #BetterPlace 2018-11-06 08:19:01 -08:00
James Mason
b11001cdba Every campaign has an end.
Drop ahoy, because it's more trouble than it's worth. This means dropping
visits, campaigns, targets.

Campaigns are better run to analytics, such as:
* https://matomo.org/docs/tracking-campaigns/
* https://matomo.org/docs/tracking-goals-web-analytics/
* https://support.google.com/analytics/answer/1012040?hl=en
2018-10-16 21:34:04 +02:00
Henne Vogelsang
a0b79c7789 Drop knapsack
It constantly fails with "Mysql2::Error: This connection is in use by...".
Might be because of database cleaner? But until we can get this stable,
rip it out again.

Replaced by a matrix based on test type
2018-09-20 00:56:17 +02:00
Henne Vogelsang
5fc867a8fc Introduces rubocop-rspec
Also regenerating the config. Most stuff in there didn't really make sense.
Time to go through .rubocop_todo.yml people :-)
2018-09-08 04:29:22 +02:00
Henne Vogelsang
64d8f05bdd Update FactoryBot strings & urls 2018-09-06 00:42:28 +02:00
James Mason
6775add832 Update rubocop TODO 2018-06-01 09:15:57 -07:00
James Mason
7f116ecda6 Enable rubocop Rails rules 2018-06-01 09:15:57 -07:00
James Mason
a68be76a15 Add rubocop TargetVersion; disable new cops 2018-06-01 09:15:57 -07:00
James Mason
4951d085f5 Tidying up. 2018-03-14 18:00:37 -07:00
Carlos Coelho
8457dafbf6 Add withdrawn events to conference dashboard
Signed-off-by: Carlos Coelho <carlos@vinta.com.br>
2018-02-19 01:02:30 +02:00
Naman Gupta
808625106c Removed Style/DateTime offences which occured due to the use of DateTime class in spec/models/program_spec.rb 2017-12-21 21:17:00 +02:00
Ronaq13
505d9da3d4 Fix Performance/HashEachMethods offenses
values.each and keys.each methods are depreciated, so they have replaced by
each_value and each_key respectively. This has done manually.

Closes https://github.com/openSUSE/osem/issues/1825
2017-12-18 17:30:37 +01:00
Sidharth
93fcf8893a Fix Style/UnneededInterpolation
Exclusions from .rubocop_todo.yml deleted.
This cop checks for string interpolated expressions. It supports autocorrection.
Fixes #1823
2017-12-04 23:45:37 +05:30
Ana María Martínez Gómez
666f5ab2dc
Merge pull request #1850 from SidharthBansal/new
Fix Style/ReductantReturn rubocop
2017-12-04 14:40:01 +01:00
Sidharth
020dae3d49 Fix Style/ReductantReturn rubocop
Exclusions from .rubocop_todo.yml deleted.This cop checks for redundant return expressions.
Fixes #1824
2017-12-04 16:01:18 +05:30
rishabh92
97749fc195 Fix Bundler/OrderedGems Rubocop offenses
This cop checks that gems are alphabetically sorted within groups. The offenses were fixed using rubocop autocorrection.
2017-12-03 18:19:21 -06:00
rahul2240
2affec9614 Regenerate rubocop_todo file
Todo file is regenerated because of the changes in the new version of Rubocop.
We are following the default Rubocop configuration.
closes https://github.com/openSUSE/osem/issues/1815
2017-11-28 16:18:06 +05:30
nasia
52cde784fa Add :accept booth to ability 2017-08-18 23:41:38 +03:00
nasia
7107f9a35f Add emails for booth's acceptance and rejection 2017-08-14 22:34:17 +03:00
AEtherC0r3
fd93b04f16 Add room and dates to tracks
They are required only for accepted and confirmed self-organized tracks
2017-08-11 16:25:21 +03:00
AEtherC0r3
d616c66745 Define the track's finite state machine 2017-08-11 16:25:21 +03:00
nasia
32c5af2a17 Add booths to non admin 2017-08-08 16:18:07 +03:00
Hernan Schmidt
523203ac74 Update rubocop_todo.yml
Generated automatically by `rubocop --auto-gen-config`
2017-07-14 15:16:43 +02:00
AEtherC0r3
9c58397cd2 Enable Style/IndentationWidth cop
The offenses were fixed manually
2017-07-14 12:47:20 +03:00
AEtherC0r3
68fc750e9f Implement track requests and add the track organizer role
About track requests:
Create migration that adds the fields submitter_id, state, and
cfp_active to Tracks
Add validations and the self_organized? method to the Track model
Create a new TracksController outide of the admin namespace
Create the relevant views for index, show, new and edit
Modify the admin views for tracks to include extra info for
self-organized tracks

About track organizers:
Create the role when a self-organized track is created
Define track organizer abilities
Modify the roles views and controller to handle the new role

The route for Roles#edit needs to have higher priority than the nested
routes for track roles, otherwise, the word edit in the url is matched
as a track with short_name edit
2017-07-14 12:38:53 +03:00
AEtherC0r3
c3eb178546 Modify CFP to accept proposals for other things
Add field cfp_type and relevant validations
Add Program#cfp to preserve backwards compatibility
Add 'for_events' scope to the cfp, in order for it to be used like
program.cfps.events
Add useful methods
Add rspec test for the new code
The supported cfp types can be viewed via Cfp::TYPES
2017-06-27 21:16:46 +03:00
Ana María Martínez Gómez
267f080ac7 Enable Style/CommentAnnotation Rubocop cop
This cop checks that comment annotation keywords are written according
to guidelines. The offense was automatically corrected.
2017-06-26 16:47:07 +02:00
Dimitris
d160c22a0b Enable rails/findEach Rubocop cop
This cop enforce the use of `find_each` instead of `each`.

Closes #1535
2017-06-20 10:46:04 +03:00
divyanshumehta
cdf794ecbf Add Style/SelfAssignment Rubocop cop
The cop enforces use of self assignment operator E.g. a=a+2 gets
written as a+=2. Also the offenses listed in rubocop.todo.yml
have been corrected automatically with the --auto-correct option.
Fixes issue #1531
2017-06-14 09:22:19 +05:30
Ana María Martínez Gómez
53040b3be9 Merge pull request #1498 from divyanshumehta/issue_1497
Added Style/SpaceInsideBrackets Rubocop cop
2017-06-12 17:45:30 +02:00
AEtherC0r3
41503bb7a0 Compute ticket statistics
And exclude admin/ConferencesController from rubocop_todo.yml
2017-06-12 15:24:27 +03:00
divyanshumehta
0d01ed08b0 Added Style/SpaceInsideBrackets Rubocop cop 2017-06-11 22:57:52 +05:30
nasia
6cb11ff2f3 Add Style/WordArray at rubocop.yml #1463 2017-06-06 13:53:05 +03:00
AEtherC0r3
5bb52f24a5 Ignore html_safe in application helper 2017-06-04 15:31:45 +03:00