When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find visible css ".rating.bright" … 0 times, found 3 matches
expected to find visible css ".rating:not(.bright)" … 5 times, found 2 matches
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed in the event proposal tab is another user’s
vote, because the fragment’s cache dependencies don’t include the
current user.
resolves#2767
When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find text "Not rated" in "…You voted: 3/5…"
# ./spec/features/voting_spec.rb:15
# ./spec/features/voting_spec.rb:13
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed on the event index is another user’s vote,
because the fragment’s cache dependencies don’t include the current
user.
re #2767
When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find css ".rating.bright" … 3 times but there were no matches
expected to find visible css ".rating:not(.bright)" … 2 times, found 5 matches
# ./spec/features/voting_spec.rb:31
# ./spec/features/voting_spec.rb:30
# ./spec/features/voting_spec.rb:53
i.e. the rating displayed on the event index is not updated after
voting, because while the fragment’s cache dependencies include the
event, voting doesn’t update the event.
re #2767
Effective API changes:
- nil serializes to null, not empty string
- dates serialize to IETF RFC 3339 with millisecond precision, not
second precision surrounded by spaces
Changes:
- restoration of labels that were formerly generated by Formtastic
- corrections to markup of HTML labels and Bootstrap form controls
- minor copy editing
Resolves:
- Duplicate event listeners are registered during every word count,
increasing the number of word counts until the browser becomes
unresponsive.
- The word count is triggered multiple times on input due to listening
to redundant events.
This parameter was accidentally disconnected in commit c967a0b9a4
but is still used by `app/views/admin/conferences/index.html.haml` and
`app/views/admin/events/index.html.haml`.
Resolves:
Failures:
1) Survey as an attendee respond to a survey during registration
Failure/Error: expect(flash).to eq('Successfully responded to survey.')
expected: "Successfully responded to survey."
got: "none"
(compared using ==)
# ./spec/features/surveys_spec.rb:49:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:37 # Survey as an attendee respond to a survey during registration
The logic used for the `:reply` ability incompletely duplicated that of
`Survey#active?` and incorrectly assumed that surveys always have start
and end dates.
Resolves:
Failures:
1) Survey as an attendee respond to a survey during registration
Failure/Error: survey.start_date > Time.current || survey.end_date < Time.current
ActionView::Template::Error:
undefined method `>' for nil:NilClass
survey.start_date > Time.current || survey.end_date < Time.current
^
# ./app/models/ability.rb:126:in `block in signed_in'
# ./app/views/surveys/show.html.haml:28:in `block in _app_views_surveys_show_html_haml___3404959267043700678_138180'
# ./app/views/surveys/show.html.haml:19:in `_app_views_surveys_show_html_haml___3404959267043700678_138180'
Failed examples:
rspec ./spec/features/surveys_spec.rb:37 # Survey as an attendee respond to a survey during registration
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: select 'boolean', from: 'Type of Question:', visible: false # Hidden by bootstrap-select
Capybara::ElementNotFound:
Unable to find select box "Type of Question:" that is not disabled and Unable to find input box with datalist completion "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# Capybara::ElementNotFound:
# Unable to find select box "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
Resolves:
app/views/admin/surveys/_form.html.haml:25: warning: key :class is duplicated and overwritten on line 25
app/views/admin/surveys/_form.html.haml:27: warning: key :class is duplicated and overwritten on line 27
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: raise ActionController::MissingExactTemplate, message
ActionController::MissingExactTemplate:
Admin::SurveyQuestionsController#new is missing a template for request formats: text/html
# <internal:kernel>:90:in `tap'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: click_link 'New'
Capybara::ElementNotFound:
Unable to find link "New"
# ./spec/features/surveys_spec.rb:18:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
Resolves failing test `spec/features/versions_spec.rb:344`:
1) Version display changes in users_role for conference role
Failure/Error: expect(page).to have_text("added role cfp with ID #{user_role.id} to user #{user.name} in conference #{conference.short_title}")
expected to find text "added role cfp with ID 2 to user name2 in conference fr_GAQ" in "OSEM\nname1\nAll Conferences\nOrganizations\nRevision History\nAll Conferences\nRevision History\nLog of changes made to conferences and associated resources\nShow\n10\n25\n50\n100\nAll\nentries\nSearch:\nID Description Actions\n18\nname2 signed up less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n17\nSomeone (probably via the console) updated is admin of user name1 less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n16\nname1 signed up less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n15\nSomeone (probably via the console) created new cfp for events in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n14\nSomeone (probably via the console) created new role volunteers_coordinator in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n13\nSomeone (probably via the console) created new role info_desk in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n12\nSomeone (probably via the console) created new role cfp in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n11\nSomeone (probably via the console) created new role organizer in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n10\nSomeone (probably via the console) created new difficulty level Hard in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n9\nSomeone (probably via the console) created new difficulty level Medium in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\nShowing 1 to 10 of 16 entries\nFirst\nPrevious\n1\n2\nNext\nLast\nThis tool is free software, released under the MIT license. You can run, copy, distribute, study, change and improve it. The source code and the developers are on GitHub."
# ./spec/features/versions_spec.rb:350:in `block (2 levels) in <top (required)>'
