Commit graph

2081 commits

Author SHA1 Message Date
Henne Vogelsang
ddff97147f
Query versions of associations
Not association related versions data. To make this database save, this broke
with Postgre. Probably LIKE vs ILIKE...
2025-01-21 17:41:39 +01:00
Henne Vogelsang
c6d23e4742
Do not double assign attributes
Doing this messed with PictureUploader file names.
2025-01-21 14:19:23 +01:00
Henne Vogelsang
50d6f5b3d5
Remove superflous spec for User.registered/attended
There is no logic involved, just a map on the title...
2024-12-09 16:42:42 +01:00
Henne Vogelsang
a274940b5d
Autocorrect Rails/WhereRange 2024-12-02 13:16:34 +01:00
Henne Vogelsang
5b49af7559
Autocorrect Rails/EnumSyntax 2024-12-02 13:15:26 +01:00
Henne Vogelsang
e1e7c18586
Autocorrect Style/SafeNavigation 2024-12-02 11:46:33 +01:00
Henne Vogelsang
68e8203f27
Autocorrect
- Lint/SafeNavigationConsistency
- Capybara/NegationMatcher
2024-12-02 11:43:43 +01:00
Henne Vogelsang
d6b94c6291
Merge pull request #3418 from asdil12/tz
Fix wrong timezone in schedule XML
2024-07-02 15:29:11 +02:00
Henne Vogelsang
e339133c56
Do not require programs languages in controller
We did not set this in ProposalController#create so it was empty
if we the event validation failed and we rendered :new.

It makes little sense to assign this instance variable anyway, we already have
@program.
2024-07-01 14:23:08 +02:00
Dominik Heidler
14cbab11c0
Fix wrong timezone in schedule XML
Fixes #3242
Fixes #3417
2024-06-24 11:28:35 +02:00
Henne Vogelsang
9f1e877ea0
Expose Conference.code_of_conduct 2024-06-07 17:42:08 +02:00
Henne Vogelsang
275be8c80a
Drop Organization Feature 2024-06-07 17:42:08 +02:00
Henne Vogelsang
dc1a6a4363
Drop Organization abilities 2024-06-07 16:16:02 +02:00
Henne Vogelsang
7190867f21
Drop bootstrap3-datetimepicker-rails
We are using the browser for date inputs now...
2024-06-07 14:09:13 +02:00
Henne Vogelsang
30fdc2d796
Replace all datepickers with date input
Nowadays all browsers have reasonable date input support...
2024-06-07 14:09:12 +02:00
Henne Vogelsang
07bfff8fa1
Replace registration-period datepickers with date input
Nowadays all browsers have reasonable date input support...
2024-06-07 13:16:44 +02:00
Henne Vogelsang
494c73bbd6
Drop skylight, we already support sentry 2024-06-06 18:26:01 +02:00
Henne Vogelsang
30bc21c96a
Move word counting javascript to the page
It really does not need to run on every page load...
2024-03-05 15:41:53 +01:00
Henne Vogelsang
a154d99460
Merge pull request #3194 from openSUSE/depfu/update/countries-5.4.0
Drop country_select
2023-05-08 17:28:54 +02:00
depfu[bot]
d9f86d0564
Drop country_select
We are using i18n_data directly.
2023-05-08 17:09:55 +02:00
Andrew Kvalheim
3ae1275fb5 Restore views for Admin::EventsController#new and Admin::UsersController#edit
1. Restore views lost during 81853d1:

        git restore --source 4a16836 \
          app/views/admin/users/_form.html.haml \
          app/views/application/edit.html.haml \
          app/views/application/new.html.haml
        mv app/views/application/edit.html.haml app/views/admin/users/
        mv app/views/application/new.html.haml app/views/admin/events/

 2. Convert from Formtastic:

      - app/views/admin/users/_form.html.haml

 3. Add header as in 81853d1:

      - app/views/admin/events/new.html.haml

 4. Substitute partial unified in 88b5596:

      - app/views/admin/events/new.html.haml

resolves #2975
2023-05-01 18:34:55 -07:00
Andrew Kvalheim
c403247b79 Restore detailed event form for admins
In #2987 the detailed view of the event form was inadvertently lost,
presumably due to #2975 masking the problem.
2023-05-01 18:34:51 -07:00
Andrew Kvalheim
ada8d5a68c Add missing form labels
Lost during 81853d1
2023-05-01 18:33:16 -07:00
Henne Vogelsang
749115e507
Merge pull request #3090 from AndrewKvalheim/api-time-zone
Correct time zone of API dates
2023-04-19 13:36:12 +02:00
Henne Vogelsang
f533dd6d38
Merge pull request #3093 from differentreality/remove_datepicker_limits
Remove datepicker date limits
2023-04-19 13:29:05 +02:00
Henne Vogelsang
ef8863298e
Merge pull request #3094 from differentreality/2738_history_changes_deleted_models
Fix version history for deleted models
2023-04-19 13:28:17 +02:00
Henne Vogelsang
04b45adbe5
Merge pull request #3096 from AndrewKvalheim/api-urls
Add URLs to API responses
2023-04-19 13:26:44 +02:00
Henne Vogelsang
86b8990d71
Merge pull request #3130 from AndrewKvalheim/vote-cache-expiration
Expire voting fragment caches
2023-04-19 13:23:05 +02:00
Henne Vogelsang
8b909a95c9
Merge pull request #3131 from AndrewKvalheim/nofollow
Set `nofollow` on user-generated links
2023-04-19 13:19:34 +02:00
Henne Vogelsang
3aaf86076f
Merge pull request #3133 from AndrewKvalheim/thead-tr
Correct invalid table markup
2023-04-19 13:14:34 +02:00
Henne Vogelsang
4cb0147799
Merge pull request #3135 from AndrewKvalheim/send-to-whom
Clarify to whom emails will be sent
2023-04-19 13:13:29 +02:00
Henne Vogelsang
ddeb8bd776
Merge pull request #3139 from AndrewKvalheim/font-awesome-spill
Move text out of Font Awesome icons
2023-04-19 13:12:47 +02:00
Andrew Kvalheim
cdee712d07 Display track description on proposal form
Tracks are otherwise undocumented for CfP respondents.
2023-03-11 13:51:02 -08:00
Andrew Kvalheim
6ed1725b01 Server-side render initial visibility of select help text
Resolves failure to display initial help text of difficulty level.
2023-03-11 13:50:51 -08:00
Andrew Kvalheim
741c188260 Move text out of Font Awesome icons
Font Awesome icon elements are intended to be empty. Extending the icon
elements around adjacent text caused the text to be displayed in an
irregular font.
2023-03-10 14:17:46 -08:00
Andrew Kvalheim
1e97b391c2 Clarify to whom emails will be sent 2023-03-08 17:18:51 -08:00
Andrew Kvalheim
1f31c1c80d Correct invalid table markup
- Add required <tr> within <thead>
  - Add implicit <tbody> after <thead>
2023-03-04 14:33:08 -08:00
Andrew Kvalheim
e01fd2d721 Add URLs to API responses
Resolves inability of API consumers to provide links to OSEM.
2023-03-04 10:15:56 -08:00
Andrew Kvalheim
80d7ac545c Set nofollow on links in Markdown content
To disincentivize spamdexing, links in user-generated content should be
disavowed by annotation with `rel="nofollow"` attributes:

  - https://en.wikipedia.org/wiki/Nofollow

Automated spam has already targeted OSEM in the wild:

  - https://github.com/SeaGL/organization/issues/274

Ideally link annotation would be performed during Markdown rendering or
a single sanitization pass, but this is currently an unresolved issue:

  - https://github.com/vmg/redcarpet/issues/720
2023-03-03 17:16:53 -08:00
Andrew Kvalheim
04f6a73d73 Add user to cache dependencies of event proposal tab
When fragment caching is enabled—

    --- a/config/environments/test.rb
    +++ b/config/environments/test.rb
    @@ -27 +26,0 @@
    -  config.action_controller.perform_caching = false
    @@ -29 +27,0 @@
    -  config.cache_store = :null_store

—the test of voting fails with:

    expected to find visible css ".rating.bright" … 0 times, found 3 matches
    expected to find visible css ".rating:not(.bright)" … 5 times, found 2 matches
    # ./spec/features/voting_spec.rb:21
    # ./spec/features/voting_spec.rb:21
    # ./spec/features/voting_spec.rb:57

i.e. the vote displayed in the event proposal tab is another user’s
vote, because the fragment’s cache dependencies don’t include the
current user.

resolves #2767
2023-03-01 11:52:16 -08:00
Andrew Kvalheim
1563881153 Add user to cache dependencies of vote in events index
When fragment caching is enabled—

    --- a/config/environments/test.rb
    +++ b/config/environments/test.rb
    @@ -27 +26,0 @@
    -  config.action_controller.perform_caching = false
    @@ -29 +27,0 @@
    -  config.cache_store = :null_store

—the test of voting fails with:

    expected to find text "Not rated" in "…You voted: 3/5…"
    # ./spec/features/voting_spec.rb:15
    # ./spec/features/voting_spec.rb:13
    # ./spec/features/voting_spec.rb:57

i.e. the vote displayed on the event index is another user’s vote,
because the fragment’s cache dependencies don’t include the current
user.

re #2767
2023-03-01 11:43:50 -08:00
Andrew Kvalheim
17366c6eab Update events when rated
When fragment caching is enabled—

    --- a/config/environments/test.rb
    +++ b/config/environments/test.rb
    @@ -27 +26,0 @@
    -  config.action_controller.perform_caching = false
    @@ -29 +27,0 @@
    -  config.cache_store = :null_store

—the test of voting fails with:

    expected to find css ".rating.bright" … 3 times but there were no matches
    expected to find visible css ".rating:not(.bright)" … 2 times, found 5 matches
    # ./spec/features/voting_spec.rb:31
    # ./spec/features/voting_spec.rb:30
    # ./spec/features/voting_spec.rb:53

i.e. the rating displayed on the event index is not updated after
voting, because while the fragment’s cache dependencies include the
event, voting doesn’t update the event.

re #2767
2023-03-01 11:33:21 -08:00
Stella Rouzi
7fc848fe9c Fix version history for deleted models
Resolves #2738
2022-10-27 11:35:20 +03:00
Stella Rouzi
7b92754f29 Remove datepicker date limits 2022-10-19 16:24:48 +03:00
Andrew Kvalheim
6ce2e66f14 Correct time zone of API dates
Prior to this change, the API returned incorrect dates in UTC instead of
the conference time zone.
2022-09-28 13:22:15 -07:00
Andrew Kvalheim
397341a324 Use JSON date serializer
Effective API changes:

  - nil serializes to null, not empty string
  - dates serialize to IETF RFC 3339 with millisecond precision, not
    second precision surrounded by spaces
2022-09-28 09:34:01 -07:00
Andrew Kvalheim
57e9135287 Use CSS-compatible row IDs in datatables
In CSS IDs may not begin with a number:

  - https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier
2022-09-13 11:06:22 -07:00
Sasi Olin
45c57eb76e
Fix missing fa-stacked-icon function 2022-05-22 00:50:49 +02:00
Sasi Olin
f28f1fd9b3 Fix venue information city/country display 2022-05-20 16:25:38 +02:00
Sasi Olin
9fb26f880d Minor fixes 2022-05-20 16:09:31 +02:00