Ana María Martínez Gómez
014ff1acc3
Use new changed? Rails method
...
`attribute_changed?` inside of after callbacks has changed his
behaviour. The new return value will reflect the behavior of calling the
method after `save` returned. To maintain the current behavior, I have
`saved_change_to_attribute?` instead.
2019-07-17 00:13:24 +02:00
Ana María Martínez Gómez
085e33f495
Use url instead object in image_tag
...
Before Rails 5.2, it was possible to pass an uploader object to
`image_tag` and Rails guessed the url. With Rails 5.2 this is not
possible anymore.
2019-07-17 00:13:24 +02:00
Ana María Martínez Gómez
af1d5e4a3b
Do no use string in if conditional
...
Passing string to be evaluated in :if and :unless conditional options is
not supported. Pass a symbol for an instance method, or a lambda, proc
or block, instead.
2019-07-17 00:13:24 +02:00
Ana María Martínez Gómez
47ce659a2f
Merge pull request #2374 from openSUSE/depfu/update/shoulda-matchers-4.0.1
...
Update shoulda-matchers: 3.1.2 → 4.0.1 (major)
2019-06-03 09:23:52 +02:00
Henne Vogelsang
e6049adc52
Fix gigitty link
...
The modal didn't really work on mobiles. On mobiles you also need the schedule
link because it's hard to point your mobile to a QR code on your mobile...
2019-05-24 15:19:37 +02:00
Ana María Martínez Gómez
7473e889ee
Define ticket_purchases before through association
...
In the User model, a has_many :through association
'User#physical_tickets' which goes through 'User#ticket_purchases' was
defined before the through association was defined. This doesn't work in
Rails 5.1.
2019-05-05 09:40:50 +02:00
Ana María Martínez Gómez
a8d2f8caa4
Drop halt_callback_chains_on_return_false
...
ActiveSupport.halt_callback_chains_on_return_false= is deprecated and
will be removed in Rails 5.2. Stop using it and return `throw(:abort)`
instead in the callbacks which need it.
2019-05-05 09:40:49 +02:00
Ana María Martínez Gómez
b3716985f0
Stop using reload argument in associations
...
Deprecated force reload argument in association readers is deprecated
and has been removed in Rails 5.1:
09cac8c67a
2019-05-05 09:40:09 +02:00
Ana María Martínez Gómez
ca574ae2af
Fix failing validation in Registration
...
In the conference is not set, validation that the call for paper is
accepted breaks. This made the conference association test failing.
2019-03-27 10:22:07 +01:00
ibrahimelbanna
dc77795f95
Adding time zone validation to conference model
2019-03-17 00:03:42 +02:00
Henne Vogelsang
455fc0a270
Make it possible to view Surveys in ichain mode
...
This is not ichain specific.
2019-03-08 14:39:39 +01:00
Henne Vogelsang
1a1da83bf2
Document the ichain specific ability
2019-03-08 14:39:39 +01:00
Henne Vogelsang
b57c771d3e
Allow viewing the schedule/events in ichain mode
...
This abilit is not specific to one mode.
2019-03-08 14:39:39 +01:00
Henne Vogelsang
bec13df131
Adopt more specs to the shoulda-matchers update
2019-02-19 20:50:09 +01:00
James Mason
072116fffe
Enable registration to proceed without requiring a ticket.
...
Requiring a ticket after registration is convoluted; while it may be neccesary
for some workflows, it definitely isn't for others, and the core of osem
doesn't need it... so let's make it optional.
2019-02-16 00:53:40 +01:00
Henne Vogelsang
a4d7a1a771
Change initial state to new
...
The initial state needs to be one that is part of the machine.
See the transition README.md
2019-02-15 17:09:03 +01:00
Henne Vogelsang
334f84179f
Use deliver_later in devise
...
Do not send devise mails directly in the request but through the
delayed jobs.
2019-02-01 01:00:56 +01:00
Henne Vogelsang
0f5181ccf4
Introduces New Installation Page
...
If there are no users signed up and no conferences we show a page
informing people what they need to do.
2019-02-01 01:00:56 +01:00
James Mason
516e53d9df
Use chartkick globally
...
* Clean up legacy charting imports
* Update existing donut and line charts
* Create helpers for parsing out existing chart data
* Move chart partials to a more common path
2018-12-30 16:57:22 -08:00
James Mason
43bef689fc
Rubocop autocorrections
2018-11-16 09:06:05 -08:00
James Mason
b11001cdba
Every campaign has an end.
...
Drop ahoy, because it's more trouble than it's worth. This means dropping
visits, campaigns, targets.
Campaigns are better run to analytics, such as:
* https://matomo.org/docs/tracking-campaigns/
* https://matomo.org/docs/tracking-goals-web-analytics/
* https://support.google.com/analytics/answer/1012040?hl=en
2018-10-16 21:34:04 +02:00
Henne Vogelsang
fb2612ecaf
Simplify set_week callbacks
...
Changes to :week are already ignored py paper_trail. No need to wrap this in a
`without_versioning`. Also drop the reader in `Registration` and the tests. Why
write this into the DB but never read it again? Why test standard
ruby/activerecord stuff.
2018-09-04 21:12:46 +02:00
James Mason
64ceaf50f4
Update Admin user datatables to use AJAX
2018-08-30 16:50:42 +02:00
Stella Rouzi
9908f88570
Add survey with target after_event
2018-07-03 08:46:15 +03:00
Stella Rouzi
683f62a27c
Add more options for surveys
...
* Survey period constraints
* Add abilities
* Enforce required questions
* Update survey_submssion updated_at
* Do a full match of possible answer and user reply
2018-07-03 08:46:15 +03:00
Stella Rouzi
c278e547ce
Add survey related tests
2018-07-03 08:46:15 +03:00
Stella Rouzi
9f3c0eff5d
Add surveys; custom generated by admins
...
Available during registration or after conference
Co-authored-by: Shyukri <shshyukriev@suse.com>
Co-authored-by: Henne <hvogel@opensuse.org>
Co-authored-by: Moises <mdeniz@suse.com>
2018-07-03 08:46:15 +03:00
Stella Rouzi
3bb73f27cf
Fix ahoy tracking and visits
2018-07-02 09:42:40 -06:00
James Mason
24396d35c2
Use Ruby safe navigation over Rails try
...
re: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/SafeNavigation
2018-06-01 09:15:57 -07:00
Stella Rouzi
d01d15ba5e
Update paper_trail, show ticket price with currency in versions
2018-06-01 09:05:21 -07:00
Zach Kemp
3f2f35283c
improve template readability
2018-05-09 10:07:08 -07:00
Zach Kemp
7d5d935a65
optimize queries
2018-05-09 10:07:08 -07:00
James Mason
6d31dfeef4
Add frozen_string_literal magic comment
...
re: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/FrozenStringLiteralComment
2018-05-09 06:54:26 -07:00
James Mason
03ef28e74d
Require code of conduct acceptance on registration
2018-05-08 13:23:00 +02:00
James Mason
95196c7f80
Include code of conduct on conference
2018-05-08 13:23:00 +02:00
James Mason
217ec1a46f
Show code of conduct on organizations
2018-05-08 13:23:00 +02:00
James Mason
98defe2d0f
Use role caching for Rolify to avoid N+1 queries
...
Resolves #2018
See https://github.com/RolifyCommunity/rolify#cached-roles-to-avoid-n1-issue
2018-04-04 07:36:29 -07:00
Michael Klimenko
111812025b
Ignore changes of updated_at in Ticket and EventType models
2018-03-28 08:32:45 -07:00
Michael Klimenko
58cb62dd6d
Fix tickets turnover calculation
2018-03-27 07:52:25 -07:00
ViditChitkara
33d32b9294
currency of a single ticket could be updated now
...
closes #1913
fixed travis faliures
minor changes
removed empty file
added tests regarding currency updation
2018-03-15 13:19:59 +02:00
James Mason
a2ed9c0074
Move events index datatable row to a partial
...
- clean up columns
- tag unregistered submitters & speakers
- implement caching
2018-03-14 18:00:37 -07:00
Marie-Elise
b1960c08ef
Added name uniqueness validation for organization model.
2018-02-27 12:16:52 -08:00
Carlos Coelho
5f7029d28e
Make calculate_event_distribution use state to group events
...
Signed-off-by: Carlos Coelho <carlos@vinta.com.br>
2018-02-19 01:02:30 +02:00
ViditChitkara
9c322d682f
fixed csv export bug
2018-02-19 00:53:32 +02:00
namangupta01
7326bd132f
Ability of user to create registration is fixed Closes #1628
...
Speaker's ability to create registration and corresponding tests are improved
2018-02-10 19:19:02 +02:00
ViditChitkara
66a2777677
changes for test faliures
2018-01-23 18:26:03 -08:00
ViditChitkara
6d67e9c959
minor changes
2018-01-23 18:26:03 -08:00
ViditChitkara
0ec937e43e
fixed failing tests
2018-01-23 18:26:03 -08:00
ViditChitkara
86cab52f52
fixed ticket turnover bug
...
closes #1918
2018-01-23 18:26:03 -08:00
Rishabh Singh
61fcc262c8
Fixed org_admin administration dashboard error.
...
Fixed error accessing admin dashboard by passing
organization_id attribute.
Fixes #1933
2018-01-08 15:41:55 +01:00