Commit graph

2110 commits

Author SHA1 Message Date
Andrew Kvalheim
2a93d09d22 Update datatables for ajax-datatables-rails 1
Resolves:

  - inability to filter, order, or paginate datatables
  - exception AjaxDatatablesRails::Error::InvalidSearchColumn

Continues:

  - 81853d1ef9
  - 83636afee0
2022-03-18 12:49:30 -07:00
Andrew Kvalheim
edec5a98be Removed unused data and columns from datatables 2022-03-18 12:48:18 -07:00
Andrew Kvalheim
ef298f5a22 Restore colors parameter of donut chart partial
This parameter was accidentally disconnected in commit c967a0b9a4
but is still used by `app/views/admin/conferences/index.html.haml` and
`app/views/admin/events/index.html.haml`.
2022-03-17 18:46:04 -07:00
Andrew Kvalheim
685d79e44b Correct use of Redcarpet’s safe_links_only flag 2022-03-17 17:03:30 -07:00
Andrew Kvalheim
02dc5011fe Show feedback upon survey response
Resolves:

    Failures:

      1) Survey as an attendee respond to a survey during registration
         Failure/Error: expect(flash).to eq('Successfully responded to survey.')

           expected: "Successfully responded to survey."
                got: "none"

           (compared using ==)
         # ./spec/features/surveys_spec.rb:49:in `block (3 levels) in <top (required)>'

    Failed examples:

    rspec ./spec/features/surveys_spec.rb:37 # Survey as an attendee respond to a survey during registration
2022-03-16 14:12:01 -07:00
Andrew Kvalheim
b565be2f46 Correct assumption of survey start and end dates
The logic used for the `:reply` ability incompletely duplicated that of
`Survey#active?` and incorrectly assumed that surveys always have start
and end dates.

Resolves:

    Failures:

      1) Survey as an attendee respond to a survey during registration
         Failure/Error: survey.start_date > Time.current || survey.end_date < Time.current

         ActionView::Template::Error:
           undefined method `>' for nil:NilClass

                 survey.start_date > Time.current || survey.end_date < Time.current
                                   ^
         # ./app/models/ability.rb:126:in `block in signed_in'
         # ./app/views/surveys/show.html.haml:28:in `block in _app_views_surveys_show_html_haml___3404959267043700678_138180'
         # ./app/views/surveys/show.html.haml:19:in `_app_views_surveys_show_html_haml___3404959267043700678_138180'

    Failed examples:

    rspec ./spec/features/surveys_spec.rb:37 # Survey as an attendee respond to a survey during registration
2022-03-16 14:12:01 -07:00
Andrew Kvalheim
3e7be52586 Associate form label with its control
Resolves:

    Failures:

      1) Survey as an organizer create a survey
         Failure/Error: select 'boolean', from: 'Type of Question:', visible: false # Hidden by bootstrap-select

         Capybara::ElementNotFound:
           Unable to find select box "Type of Question:" that is not disabled and Unable to find input box with datalist completion "Type of Question:" that is not disabled
         # ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
         # ------------------
         # --- Caused by: ---
         # Capybara::ElementNotFound:
         #   Unable to find select box "Type of Question:" that is not disabled
         #   ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'

    Failed examples:

    rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
2022-03-16 14:12:01 -07:00
Andrew Kvalheim
d1a0167969 Correct failure to enable survey date pickers
Resolves:

    app/views/admin/surveys/_form.html.haml:25: warning: key :class is duplicated and overwritten on line 25
    app/views/admin/surveys/_form.html.haml:27: warning: key :class is duplicated and overwritten on line 27
2022-03-16 14:09:36 -07:00
Andrew Kvalheim
58b1440cdd Add missing view for survey question creation
Resolves:

    Failures:

      1) Survey as an organizer create a survey
         Failure/Error: raise ActionController::MissingExactTemplate, message

         ActionController::MissingExactTemplate:
           Admin::SurveyQuestionsController#new is missing a template for request formats: text/html
         # <internal:kernel>:90:in `tap'

    Failed examples:

    rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
2022-03-16 13:37:00 -07:00
Andrew Kvalheim
c052516009 Grant conference organizers permission to manage surveys
Resolves:

    Failures:

      1) Survey as an organizer create a survey
         Failure/Error: click_link 'New'

         Capybara::ElementNotFound:
           Unable to find link "New"
         # ./spec/features/surveys_spec.rb:18:in `block (3 levels) in <top (required)>'

    Failed examples:

    rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
2022-03-16 13:37:00 -07:00
Henne Vogelsang
b04ad33138
Merge pull request #2963 from AndrewKvalheim/ajax-datatables-rails-1
Update UserDatatable for ajax-datatables-rails 1
2022-03-08 13:22:33 +01:00
Henne Vogelsang
5c7c75b53c
Merge pull request #2962 from AndrewKvalheim/countries-4.2
Update venue country name for Countries 4.2
2022-03-08 13:21:45 +01:00
Andrew Kvalheim
e2bc6fc1c7 Fix bug in which role assignments aren’t tracked in version history
Resolves failing test `spec/features/versions_spec.rb:344`:

    1) Version display changes in users_role for conference role
       Failure/Error: expect(page).to have_text("added role cfp with ID #{user_role.id} to user #{user.name} in conference #{conference.short_title}")
         expected to find text "added role cfp with ID 2 to user name2 in conference fr_GAQ" in "OSEM\nname1\nAll Conferences\nOrganizations\nRevision History\nAll Conferences\nRevision History\nLog of changes made to conferences and associated resources\nShow\n10\n25\n50\n100\nAll\nentries\nSearch:\nID Description Actions\n18\nname2 signed up less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n17\nSomeone (probably via the console) updated is admin of user name1 less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n16\nname1 signed up less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n15\nSomeone (probably via the console) created new cfp for events in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n14\nSomeone (probably via the console) created new role volunteers_coordinator in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n13\nSomeone (probably via the console) created new role info_desk in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n12\nSomeone (probably via the console) created new role cfp in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n11\nSomeone (probably via the console) created new role organizer in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n10\nSomeone (probably via the console) created new difficulty level Hard in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\n9\nSomeone (probably via the console) created new difficulty level Medium in conference fr_GAQ less than a minute ago\n(May 1, 2014 00:01)\n\n\n\nView Changes\nRevert\nShowing 1 to 10 of 16 entries\nFirst\nPrevious\n1\n2\nNext\nLast\nThis tool is free software, released under the MIT license. You can run, copy, distribute, study, change and improve it. The source code and the developers are on GitHub."
       # ./spec/features/versions_spec.rb:350:in `block (2 levels) in <top (required)>'
2022-03-06 23:38:42 -08:00
Andrew Kvalheim
83636afee0 Update UserDatatable for ajax-datatables-rails 1
Resolves failing test `spec/datatables/user_datatable_spec.rb:97`:

    1) UserDatatable outputs recordsTotal
       Failure/Error: filter_records(fetch_records).unscope(:group, :select).count(:all)

       NotImplementedError:
         NotImplementedError
       # ./app/datatables/user_datatable.rb:59:in `records_filtered_count'
       # ./spec/datatables/user_datatable_spec.rb:95:in `block (3 levels) in <top (required)>'
       # ./spec/datatables/user_datatable_spec.rb:98:in `block (3 levels) in <top (required)>'

Details: https://github.com/jbox-web/ajax-datatables-rails/blob/v1.3.1/doc/migrate.md#to-migrate-from-v04x-to-v100

RegistrationDatatable has already been updated in 81853d1ef9.
2022-03-06 23:12:02 -08:00
Andrew Kvalheim
a179609773 Update venue country name for Countries 4.2
Resolves:

    DEPRECATION WARNING: The Country#name method has been deprecated.
    Please use Country#iso_short_name instead or refer to the README
    file for more information on this change.

Details: https://github.com/countries/countries/blob/v4.2.2/README.markdown#upgrading-to-42-and-5x
2022-03-06 23:05:29 -08:00
Henne Vogelsang
0ff503bc1b
Fix selectized users on booth/proposal forms 2022-03-03 16:48:49 +01:00
Henne Vogelsang
7e5175536e
Add missing container 2022-03-02 18:01:06 +01:00
Henne Vogelsang
7babc5d08a
Fix registration form
- Admins should be able to change admin status
- Username should not be changeable
- always require password confirmation
2022-03-02 17:59:30 +01:00
Henne Vogelsang
81853d1ef9
Retire semantic_form_for
Also a buttload of form cleanups...
2022-02-24 15:52:34 +01:00
Henne Vogelsang
350b1ebbbe
Consider OmniAuth test_mode in omniauth_configured
There are not secrets for providers in test_mode...
2022-02-23 14:36:08 +01:00
Henne Vogelsang
2e21079991
Ajaxify booth responsibles selectize interface
No need to load *all* users into a select input...
2022-02-23 14:36:08 +01:00
Henne Vogelsang
800bb28c34
Drop formtastic
formtastic-bootstrap is unmaintained since years, formtastic is
just syntactic sugar, ActionView grew up to be beautiful.
2022-02-23 14:36:07 +01:00
Henne Vogelsang
19d8afa613
Fix Datatables
Using `def_delegator` needs Forwardable
2022-02-23 14:36:07 +01:00
Henne Vogelsang
c967a0b9a4
Update chartkick to 4.1.3 2022-02-23 14:36:07 +01:00
Henne Vogelsang
e79cfe0f91
Drop jquery.mobile
All that code, just for swipe. Nah...
2022-02-23 14:36:07 +01:00
Henne Vogelsang
0fb080441a
Drop redirect_back_or_to helper
This is a thing in ActionController by now
2022-02-23 14:36:07 +01:00
Henne Vogelsang
b76102aa69
Fix ticket PDF spec
open is not neccesarily OpenURI
2022-02-23 14:36:06 +01:00
Henne Vogelsang
f3a54ee82d
Fix main assets location
Some OBSisms sneaked into my copy and paste job.
2022-02-23 14:36:06 +01:00
Henne Vogelsang
2aaca67bc1
Drop piwik_analytics
The gem is unmaintained, the openSUSE matomo installation is dead.
If you need this, bring it back...
2022-02-23 14:36:06 +01:00
Henne Vogelsang
85dae98a76
👋 update_attributes
You served us well...
2022-02-23 14:36:05 +01:00
Henne Vogelsang
5c5374252c
Fix HasManyThroughOrderErrors 2022-02-23 14:36:05 +01:00
Andrew Kvalheim
3da0bb3073 Order rooms by name in the schedule
Adapted from bf3be566cd
2022-02-05 17:29:40 -08:00
Henne Vogelsang
a662ed4cf8
Sanitize rendered markdown
Fixes #2892
2021-10-11 18:10:03 +02:00
Henne Vogelsang
9aee02ecb9
Include helper that provides number_with_precision 2021-08-18 15:36:54 +02:00
Henne Vogelsang
7c1d3ce1c4
Run rails upgrade task
next bundle exec rails app:update
2021-08-18 15:36:54 +02:00
Henne Vogelsang
b5a8f1b8c0
Rename deprecated CarrierWave methods 2021-08-18 14:10:31 +02:00
depfu[bot]
fd4c60ff9f
Update omniauth to version 2.0.0 2021-08-13 13:33:04 +02:00
Henne Vogelsang
2c520d9975
Switch to fenced code blocks in markdown
`:fenced_code_blocks:` Blocks delimited with 3 or more ~ or backticks will be considered as code, without the need to be indented. An optional language name may be added at the end of the opening fence for the code block.

`:disable_indented_code_blocks:` Do not parse usual markdown code blocks. Markdown converts text with four spaces at the front of each line to code blocks. This option prevents it from doing so. Recommended to use with fenced_code_blocks: true.

Fixes #2764
2021-07-09 11:17:52 +02:00
Henne Vogelsang
5e70690619
Merge pull request #2740 from differentreality/survey_question_validation
Fix JS error when saving survey_question
2021-03-07 14:43:11 +01:00
Sasi Olin
56838b6eb0 Don't set venue related values without a venue 2021-03-07 10:19:10 +01:00
Stella Rouzi
ee5274b352 Fix JS error when saving survey_question 2021-03-07 07:32:52 +02:00
Henne Vogelsang
05adba0e35
Merge pull request #2705 from cycomachead/patch-3
Fix Frozen String Error in Commercials Controller
2021-03-06 22:04:48 +01:00
Henne Vogelsang
57360c183c
Merge pull request #2729 from hennevogel/bugfix/carrierwave-update
CarrierWave needs to be told where to store in 2.x
2021-03-06 21:44:33 +01:00
Michael Ball
258a2c1489
Fix Frozen String Error in Commercials Controller
`errors_text` is a frozen string, so `<<` leads to an exception when trying to generate the error message.

https://sentry.cs10.org/share/issue/7867fdaf8eba4387ae2789fd5f1cff3b/
if you want a production example. :)
2021-03-06 21:40:25 +01:00
Henne Vogelsang
2c238365d6
CarrierWave needs to be told where to store in 2.x 2021-03-06 21:34:48 +01:00
Sasi Olin
613161bbc7
Add buttons in the interface 2021-03-06 21:18:42 +01:00
Sasi Olin
d540092bfc
Add icalendar files (fixes #2147) 2021-03-06 21:18:39 +01:00
Henne Vogelsang
995db101b3
Merge pull request #2657 from AndrewKvalheim/bootstrap-markdown
Remove superfluous click to display Markdown editor
2021-03-06 20:00:50 +01:00
Andrew Kvalheim
ce59c37ff6
Use correct loading mode of Bootstrap-Markdown
data-provide="markdown-editable" is intended for inline editing of page
content à la contenteditable. When this is applied to a textarea, the
editor is loaded only after the user clicks on the field. This behavior
breaks focus and is incompatible with keyboard navigation.
2021-03-06 19:35:23 +01:00
Stella Rouzi
c4da5cc31d
Fix chart legend position 2021-03-06 19:27:28 +01:00