Commit graph

916 commits

Author SHA1 Message Date
Michael Ball
1ca72dcf74 Attempt to fixup logo specs 2021-02-24 09:34:04 -08:00
Michael Ball
13aa7db90d use TODO-SNAPCON for the comment tag since rubocop is not flexible enough 2021-02-24 03:32:19 -08:00
Michael Ball
60b9684dd8 Sigh...skip one more annoying spec 2021-02-24 02:28:44 -08:00
Michael Ball
8c51c27146 Skip Admin Dashboard specs since front end metrics are disabled 2021-02-24 02:19:05 -08:00
Michael Ball
49821fff52 Fix TicketScanning spec by properly creating a *paid* ticket purchase 2021-02-24 02:03:49 -08:00
Michael Ball
8c3a29da47 fix typo in user spec 2021-02-24 02:03:19 -08:00
Michael Ball
5c899f8ca5 WTF is going on with registration spec 2021-02-24 00:27:49 -08:00
Michael Ball
98cd18c883 Resolve User model spec for auth methods 2021-02-23 22:45:28 -08:00
Michael Ball
1f22827a8f Fixup version spec to reflect commercial wording 2021-02-23 22:36:15 -08:00
Michael Ball
dbc0b80aa4 Consistently use "Submit Proposal" wording 2021-02-23 22:19:26 -08:00
Michael Ball
5629deeff9 make the cloudinary mock request more generic 2021-02-23 22:15:50 -08:00
Michael Ball
b553b95143 Mock request for sponsor image 2021-02-23 22:11:37 -08:00
Michael Ball
9668a40248 Fixup splashpage spec reflecting logo change 2021-02-23 21:51:11 -08:00
Michael Ball
578a3125b7 Update proposals spec to reflect "Submit Proposal" button 2021-02-23 21:42:42 -08:00
Michael Ball
c6cb051447 Fix spec by creating a ticket purchase before a registration 2021-02-23 21:29:55 -08:00
Michael Ball
7b1cee3f6c Fixup admin spec, ensuring a valid registration exists 2021-02-23 20:45:18 -08:00
Michael Ball
6a47257333 skip _not pending_ the commerical spec, since it is currently not correct 2021-02-23 20:44:56 -08:00
Michael Ball
e0fd14e0ce Cleanup omniauth specs 2021-02-23 19:49:34 -08:00
Michael Ball
2dc3950cb0 Fix commericals feature specs (UI consistency). 2021-02-23 18:43:18 -08:00
Michael Ball
d4a2861051 Improve Registration Flow Some:
* Trying to register when a ticket is required will now redirect you to buy tickets.
* #64 will then redirect you back to complete the registration
2021-02-23 18:17:45 -08:00
Michael Ball
62dd99b263 Fix cfp spec to use "Materials" instead of Commercials 2021-02-23 17:17:17 -08:00
Jimmy
57f4079d03 [fix] Fix mailbot rspec test 2021-02-23 16:31:07 -08:00
Michael Ball
f0ea293a43 Enable saving rspec output for --only-failures 2021-02-22 22:57:26 -08:00
Michael Ball
d7e24f6521 Run annotate_models 2021-02-20 09:57:27 -08:00
Michael Ball
2892a56a1c merge master 2020-12-04 01:17:39 -08:00
Hiroshi SHIBATA
ae98ac1430
Fixed some typos (#2695)
* Fix typos
2020-10-30 11:06:43 +02:00
Thomas Schmidt
f5ac859b9b
The "chromeOptions" key in chrome capabilities changed to "goog:chromeOptions".
But I'm rather switching to the 'option' array here for readability and alignment with Firefox options.
2020-09-29 00:02:18 +02:00
Michael Ball
0877aadb2e Merge some contributor fixes 2020-06-30 00:48:47 -07:00
Andrew Kvalheim
0618f93660 Merge #​2662 "Fix bug in test of animated form" 2020-06-26 20:19:37 -07:00
Andrew Kvalheim
943f0afaaf Merge #​2659 "Use Rails transactional tests" 2020-06-26 20:19:36 -07:00
Andrew Kvalheim
305c7cac28 Merge #​2658 "Fix bug in logging of screenshots of failed tests" 2020-06-26 20:19:36 -07:00
Andrew Kvalheim
e4251d7b67 Merge #​2654 "Fix access to the version history of organization-level roles" 2020-06-26 20:19:34 -07:00
Andrew Kvalheim
042fe17fdb Merge #​2649 "Work around ChromeDriver/Chromium crash" 2020-06-26 20:19:33 -07:00
Andrew Kvalheim
09b30b4b23 Merge #​2648 "Resolve conflict between WebMock and Webdrivers" 2020-06-26 20:19:32 -07:00
Michael Ball
0b9b100bf3 Merge master 2020-06-02 01:59:54 -07:00
Tymm Schmitke
40036899b3 Add empty line at end of file 2020-05-19 23:18:05 -04:00
Tymm Schmitke
aa99f909a6 Add uniqueness tests for Event scope on Vote model with User association 2020-05-19 22:24:37 -04:00
Andrew Kvalheim
e657d37c8d Whitelist Webdrivers update URLs in WebMock
Resolves #2557:

    $ docker-compose run --rm osem bundle exec rspec --tag js
    …
    WebMock::NetConnectNotAllowedError

See titusfortner/webdrivers#109 for details.
2020-04-12 17:43:46 -07:00
Andrew Kvalheim
e077fe9671 Fix bug in test of animated form
The help text for the event type field is animated using a technique
unaffected by `Capybara.disable_animation`. Wait for the animation.

Resolves: #2356
Works around: #2661
2020-04-12 13:40:49 -07:00
Andrew Kvalheim
ae00a7f055 Use Rails transactional tests
As of Rails 5.1:

  - Rails has built-in support for running tests within database
    transactions, so Database Cleaner is no longer needed for this.
  - Rails automatically shares the database connection across threads,
    so transactional_capybara is no longer needed.

Changes:

  - Enable `use_transactional_tests`.
  - Remove transactional_capybara.
  - Remove the Database Cleaner test wrapper.

This resolves:

  - transactional_capybara mismanages the shared database connection,
    causing the connection to falsely report as idle after the first
    test. At 6 minutes (idle_timeout + reaping_frequency) into testing,
    the connection is closed, causing e.g. `PG::ConnectionBad` errors.
2020-04-05 13:15:12 -07:00
Andrew Kvalheim
11a7e056bf Fix bug in test database preparation
Presumably the intent of this was to clear the database and repopulate
it with seed data. `transaction` isn't the right strategy for this; it
just rolls back any existing transactions.
2020-04-05 13:15:04 -07:00
Andrew Kvalheim
3aa32aebe8 Remove redundant code
This functionality is provided by transactional_capybara.
2020-04-05 13:14:55 -07:00
Andrew Kvalheim
75f64508de Work around RuboCop false positive
Details: rubocop-hq/rubocop#7853
2020-04-05 10:24:51 -07:00
Andrew Kvalheim
3142c0f164 Fix bug in logging of screenshots of failed tests
Presumably this was a typo.
2020-04-05 10:24:27 -07:00
Andrew Kvalheim
71d9860124 Test access to organization_admin version as organization_admin
This corrects the specification for the behavior of the Revision History
screen; changes to the organization administrator role should be
accessible to organization administrators, not conference organizers.
2020-04-03 15:35:44 -07:00
Andrew Kvalheim
aa61ec9692 Remove unused code 2020-04-03 15:35:25 -07:00
Andrew Kvalheim
a179a38fae Minor refactor 2020-04-01 08:53:46 -07:00
Andrew Kvalheim
10f0edac20 Decouple tests from unspecified data ordering
These tests have been passing with SQLite, but don't reflect guaranteed
behavior and with PostgreSQL failed intermittently.
2020-03-29 09:06:47 -07:00
Andrew Kvalheim
a7006a4edd Decouple tests from unspecified data ordering
These tests have been passing with SQLite, but don't reflect guaranteed
behavior and with PostgreSQL failed intermittently.
2020-03-28 15:15:01 -07:00
Andrew Kvalheim
f37eab88c7 Use Chrome::Options instead of Capabilities
Resolves:

    $ docker-compose run --rm osem bundle exec rspec --tag js
    …
    Selenium::WebDriver::Error::UnknownError:
    unknown error: Chrome failed to start: exited abnormally.
2020-03-28 13:30:45 -07:00