Incidentally resolves a JavaScript error introduced in #3138 affecting
pages without the proposal form:
Uncaught TypeError: text is undefined
at word_count (app/assets/javascripts/osem.js:134)
Accidentally lost during 81853d1ef9
Resolves:
1) Event as a participant not signed_in user submits proposal
Failure/Error: expect(page).to have_text 'Abstracts must be between 0 and 500 words.'
expected to find text "Abstracts must be between 0 and 500 words." in "…Abstracts must be between 0 and 250 words.…"
# ./spec/features/proposals_spec.rb:94
250 is the initial value hard-coded in app/views/proposals/_form.html.haml
Font Awesome icon elements are intended to be empty. Extending the icon
elements around adjacent text caused the text to be displayed in an
irregular font.
When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find visible css ".rating.bright" … 0 times, found 3 matches
expected to find visible css ".rating:not(.bright)" … 5 times, found 2 matches
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed in the event proposal tab is another user’s
vote, because the fragment’s cache dependencies don’t include the
current user.
resolves#2767
When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find text "Not rated" in "…You voted: 3/5…"
# ./spec/features/voting_spec.rb:15
# ./spec/features/voting_spec.rb:13
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed on the event index is another user’s vote,
because the fragment’s cache dependencies don’t include the current
user.
re #2767
When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find css ".rating.bright" … 3 times but there were no matches
expected to find visible css ".rating:not(.bright)" … 2 times, found 5 matches
# ./spec/features/voting_spec.rb:31
# ./spec/features/voting_spec.rb:30
# ./spec/features/voting_spec.rb:53
i.e. the rating displayed on the event index is not updated after
voting, because while the fragment’s cache dependencies include the
event, voting doesn’t update the event.
re #2767
Effective API changes:
- nil serializes to null, not empty string
- dates serialize to IETF RFC 3339 with millisecond precision, not
second precision surrounded by spaces
