When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find visible css ".rating.bright" … 0 times, found 3 matches
expected to find visible css ".rating:not(.bright)" … 5 times, found 2 matches
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed in the event proposal tab is another user’s
vote, because the fragment’s cache dependencies don’t include the
current user.
resolves#2767
When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find text "Not rated" in "…You voted: 3/5…"
# ./spec/features/voting_spec.rb:15
# ./spec/features/voting_spec.rb:13
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed on the event index is another user’s vote,
because the fragment’s cache dependencies don’t include the current
user.
re #2767
Changes:
- restoration of labels that were formerly generated by Formtastic
- corrections to markup of HTML labels and Bootstrap form controls
- minor copy editing
This parameter was accidentally disconnected in commit c967a0b9a4
but is still used by `app/views/admin/conferences/index.html.haml` and
`app/views/admin/events/index.html.haml`.
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: select 'boolean', from: 'Type of Question:', visible: false # Hidden by bootstrap-select
Capybara::ElementNotFound:
Unable to find select box "Type of Question:" that is not disabled and Unable to find input box with datalist completion "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# Capybara::ElementNotFound:
# Unable to find select box "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
Resolves:
app/views/admin/surveys/_form.html.haml:25: warning: key :class is duplicated and overwritten on line 25
app/views/admin/surveys/_form.html.haml:27: warning: key :class is duplicated and overwritten on line 27
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: raise ActionController::MissingExactTemplate, message
ActionController::MissingExactTemplate:
Admin::SurveyQuestionsController#new is missing a template for request formats: text/html
# <internal:kernel>:90:in `tap'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
data-provide="markdown-editable" is intended for inline editing of page
content à la contenteditable. When this is applied to a textarea, the
editor is loaded only after the user clicks on the field. This behavior
breaks focus and is incompatible with keyboard navigation.
It used to be a partial inside #index, but having their own page
yields some extra benefits:
- Performance: Move logic from the view to the controller
- Theres' no need to go extra steps inside the :index view
- UI: Remove the extra 'Upcoming Conferences' when the system needs
to start the flow of the creation of the first user
