Commit graph

332 commits

Author SHA1 Message Date
Rob Smith
8384f7a00e Merge b9a2a80a75 into 24f0625be1 2016-01-13 11:13:04 +00:00
Stella Rouzi
355ecc0ac6 Introduce strong parameters 2015-12-23 11:36:50 +02:00
raluka
3d57203727 added more consistency for email_settings 2015-10-14 15:34:23 +02:00
Rob Smith
b9a2a80a75 Support JSONP exports of conference schedules for embedding
Currently, it's rather difficult to use OSEM and embed a schedule into another website. We currently use OSEM for the backend, but still use a different system for our main site. This change allows us to dynamically embed the schedule in our main website as well as allow us a simple way to get data for the use in mobile applications or similar.

This limits the JSONP support to only GETS on json formatted requests. This prevents any XSS even though we don't require a authenticity token.
2015-10-09 22:28:45 -07:00
raluka
0c4b0b4ac1 Refactored EmailSetting incosistency. Fixes #603 2015-10-06 11:32:40 +02:00
raluka
1b63728440 Grooming conference.rb to fix rubocop offenses 2015-09-17 12:23:01 +02:00
raluka
37339dccc1 refactored comments_controller tests; fixed access to Administration link into user_menu view 2015-09-17 12:13:22 +02:00
raluka
1addae9cd9 WIP changed CommentsController#index; temporary view for all_comments 2015-09-17 12:13:22 +02:00
raluka
800a41b3f9 added logic for available conferences based on roles in comments_controller.rb 2015-09-17 12:13:22 +02:00
raluka
52a503afd2 changed #signed_in_with_roles(user) in ability.rb model 2015-09-17 12:13:21 +02:00
raluka
df29484317 changed wrong test for ability 2015-09-17 12:13:21 +02:00
raluka
74dcd75a8c created can_manage_comments helper for rendering button 2015-09-17 12:13:21 +02:00
raluka
e10a2491d3 created tests for user ability 2015-09-17 12:13:21 +02:00
raluka
b780996128 created comments with FactoryGirl 2015-09-17 12:13:21 +02:00
raluka
35714f350e Issue#15: Added Comment Notifications: notification_emails and comments view 2015-09-17 12:13:21 +02:00
Stella Rouzi
fb607050fe undo deletion of function, so that api works (/api/v1/conferences/) 2015-09-16 10:25:52 +03:00
Christian Bruckmayer
244ea9d34a Merge pull request #708 from raluka/remaining_days
Issue #649: Wrong days remaining label when submitting a new proposal
2015-08-28 13:27:42 +02:00
raluka
1de8f979cd Issue #649: Wrong days remaining label when submitting a new proposal 2015-08-27 10:35:43 +02:00
Stella Rouzi
2a6ca7b0ff Fix ordering for event.average_voting in events#index 2015-08-06 07:41:20 +03:00
Henne Vogelsang
68efa06696 Merge pull request #660 from bgeuken/conference_model
Conference model
2015-07-02 16:28:06 +02:00
milovanderlinden
5683974151 Fix for #684 2015-06-16 23:09:47 +02:00
Christian Bruckmayer
5b6f79bbd8 Merge pull request #659 from bgeuken/fix_registration_dates_given
Fix registration dates given
2015-06-15 22:06:42 +02:00
Stella Rouzi
969c24c091 Move common views to partial 2015-06-11 15:20:48 +03:00
Björn Geuken
c972731e20 Small refactoring of get_status & self.get_event_state_line_colors 2015-05-28 10:38:38 +02:00
Björn Geuken
12fa985fff conference: refactor some conditions 2015-05-27 16:06:17 +02:00
Björn Geuken
5a5745947d Simplify cfp_open? method 2015-05-27 16:06:17 +02:00
Björn Geuken
c58585d445 cleanup: if !object.nil? -> if object 2015-05-27 16:06:17 +02:00
Björn Geuken
a1d022d0be Refactor user_registered? method 2015-05-27 16:06:14 +02:00
Björn Geuken
3e77241f8a user_registered: Return false if user is nil
The return value of user_registered? is only used as boolean. So we can
don't need to hande non existent users separately.
2015-05-27 16:02:01 +02:00
Björn Geuken
f180ce0d27 Refactor registration_open? method, part II 2015-05-21 19:16:02 +02:00
Björn Geuken
0d8a77c9ef Refactor registration_open? method
The registration_period is already checked in registration_dates_given?
method. No need to check it twice
2015-05-21 19:16:02 +02:00
Björn Geuken
bc966259fb Refactor registration_dates_given? 2015-05-21 19:16:01 +02:00
Björn Geuken
7638b33926 Fix registration_dates_given?
When the registration period is nil registration_dates_given? should return
false.
2015-05-21 19:16:01 +02:00
Björn Geuken
ca7f1a3b25 Simplify progress calculation 2015-05-16 15:27:42 +02:00
Björn Geuken
1862534b2c Avoid float conversion when calculating progress 2015-05-16 15:27:34 +02:00
Björn Geuken
5043d26cc5 Update comment of calculate_progress method 2015-05-16 15:17:20 +02:00
Henne Vogelsang
01ba76e8c6 Merge pull request #638 from bgeuken/small_patches
Few things I stumbled over while waiting for tests to finish:)
2015-05-06 14:08:50 +02:00
Henne Vogelsang
132fe6f98c Disable registration/event submission without sign in with ichain 2015-04-23 11:50:22 +02:00
Stella Rouzi
3b8b86eb85 show users per question 2015-04-22 18:55:51 +03:00
Henne Vogelsang
6cc8c1e5c2 Merge pull request #635 from bgeuken/refactor_calculate_progress
Refactor calculate progress
2015-04-20 17:21:15 +02:00
Henne Vogelsang
206c3a8144 Merge pull request #636 from bgeuken/cleanup_get_progress
Cleanup get progress
2015-04-20 17:20:09 +02:00
Björn Geuken
8250e1305e event: refactor get_state_color method 2015-04-17 16:38:03 +02:00
Björn Geuken
82edf7870a event: refactor as_json method and add a test 2015-04-17 16:38:01 +02:00
Björn Geuken
80f8bba951 Refactor abstract_word_count method 2015-04-17 16:27:47 +02:00
Björn Geuken
9f3da955f0 Move default value into else branch and remove superfluous variable 2015-04-17 16:27:44 +02:00
Björn Geuken
650a49d87b Update method documentation (returns a string not an fixnum) 2015-04-17 14:46:25 +02:00
Björn Geuken
ac0abce6e1 Small refactoring of calculate_setup_progress, part II 2015-04-17 14:46:21 +02:00
Björn Geuken
28669ac635 get_progress: align case and when as rubocop 2015-04-17 14:19:32 +02:00
Björn Geuken
e9ba87a49c get_progress: cleanup case statement 2015-04-17 12:26:10 +02:00
Björn Geuken
eea7d94223 get_progress: Move default value into else branch 2015-04-17 12:26:03 +02:00