Commit graph

710 commits

Author SHA1 Message Date
Henne Vogelsang
80f09ff250
Merge f23d1f04b5 into 4b6895f31d 2026-06-27 18:17:28 +02:00
Henne Vogelsang
3494b91f4d
Fix parameter generation for activating a schedule
Also: `@program` is instantiated via `load_and_authorize_resource` already...
2026-03-18 13:11:17 +01:00
Henne Vogelsang
76c9a5330e
Fix too loose registration strong parameters 2026-03-18 12:20:20 +01:00
Henne Vogelsang
d6e36f2845
Fix too loose strong parameters in the admin interface
There are some attributes that we don't use and/or that should
not be changeable, even by admins.
2026-03-18 12:20:20 +01:00
Henne Vogelsang
d588fb00da
Fix too loose strong Booth parameters
People should not be able to change the state, conference or timestamps of
booths.
2026-03-18 12:18:10 +01:00
Henne Vogelsang
cf87cc6280
Remove unused ticket_purchase_params 2026-03-17 15:59:02 +01:00
luzpaz
7d9739349b Fix various typos
Fixes user-facing and non-user-facing typos

Found via `codespell -S "./vendor" -L ontext,rememberable,ridiculus,varius`
2025-10-15 11:15:47 +00:00
Henne Vogelsang
f23d1f04b5
Refactor /calendars into it's own controller
Spec it out too
2025-08-14 18:28:28 +02:00
Henne Vogelsang
27062ea5c3
Move sign_in_path into the controller it's used... 2025-08-12 18:00:45 +02:00
Henne Vogelsang
988b3bf689
Autocorrect new rubocop offenses 2025-08-12 16:44:20 +02:00
Henne Vogelsang
ddff97147f
Query versions of associations
Not association related versions data. To make this database save, this broke
with Postgre. Probably LIKE vs ILIKE...
2025-01-21 17:41:39 +01:00
Henne Vogelsang
c6d23e4742
Do not double assign attributes
Doing this messed with PictureUploader file names.
2025-01-21 14:19:23 +01:00
Henne Vogelsang
e339133c56
Do not require programs languages in controller
We did not set this in ProposalController#create so it was empty
if we the event validation failed and we rendered :new.

It makes little sense to assign this instance variable anyway, we already have
@program.
2024-07-01 14:23:08 +02:00
Henne Vogelsang
9f1e877ea0
Expose Conference.code_of_conduct 2024-06-07 17:42:08 +02:00
Henne Vogelsang
275be8c80a
Drop Organization Feature 2024-06-07 17:42:08 +02:00
Henne Vogelsang
d471d9eb23
Merge pull request #2972 from AndrewKvalheim/ajax-datatables-rails-1_part-2
Update datatables for ajax-datatables-rails 1
2022-03-29 15:15:10 +02:00
Andrew Kvalheim
2a93d09d22 Update datatables for ajax-datatables-rails 1
Resolves:

  - inability to filter, order, or paginate datatables
  - exception AjaxDatatablesRails::Error::InvalidSearchColumn

Continues:

  - 81853d1ef9
  - 83636afee0
2022-03-18 12:49:30 -07:00
Andrew Kvalheim
02dc5011fe Show feedback upon survey response
Resolves:

    Failures:

      1) Survey as an attendee respond to a survey during registration
         Failure/Error: expect(flash).to eq('Successfully responded to survey.')

           expected: "Successfully responded to survey."
                got: "none"

           (compared using ==)
         # ./spec/features/surveys_spec.rb:49:in `block (3 levels) in <top (required)>'

    Failed examples:

    rspec ./spec/features/surveys_spec.rb:37 # Survey as an attendee respond to a survey during registration
2022-03-16 14:12:01 -07:00
Andrew Kvalheim
83636afee0 Update UserDatatable for ajax-datatables-rails 1
Resolves failing test `spec/datatables/user_datatable_spec.rb:97`:

    1) UserDatatable outputs recordsTotal
       Failure/Error: filter_records(fetch_records).unscope(:group, :select).count(:all)

       NotImplementedError:
         NotImplementedError
       # ./app/datatables/user_datatable.rb:59:in `records_filtered_count'
       # ./spec/datatables/user_datatable_spec.rb:95:in `block (3 levels) in <top (required)>'
       # ./spec/datatables/user_datatable_spec.rb:98:in `block (3 levels) in <top (required)>'

Details: https://github.com/jbox-web/ajax-datatables-rails/blob/v1.3.1/doc/migrate.md#to-migrate-from-v04x-to-v100

RegistrationDatatable has already been updated in 81853d1ef9.
2022-03-06 23:12:02 -08:00
Henne Vogelsang
0ff503bc1b
Fix selectized users on booth/proposal forms 2022-03-03 16:48:49 +01:00
Henne Vogelsang
7babc5d08a
Fix registration form
- Admins should be able to change admin status
- Username should not be changeable
- always require password confirmation
2022-03-02 17:59:30 +01:00
Henne Vogelsang
81853d1ef9
Retire semantic_form_for
Also a buttload of form cleanups...
2022-02-24 15:52:34 +01:00
Henne Vogelsang
2e21079991
Ajaxify booth responsibles selectize interface
No need to load *all* users into a select input...
2022-02-23 14:36:08 +01:00
Henne Vogelsang
19d8afa613
Fix Datatables
Using `def_delegator` needs Forwardable
2022-02-23 14:36:07 +01:00
Henne Vogelsang
85dae98a76
👋 update_attributes
You served us well...
2022-02-23 14:36:05 +01:00
Andrew Kvalheim
3da0bb3073 Order rooms by name in the schedule
Adapted from bf3be566cd
2022-02-05 17:29:40 -08:00
Sasi Olin
56838b6eb0 Don't set venue related values without a venue 2021-03-07 10:19:10 +01:00
Henne Vogelsang
05adba0e35
Merge pull request #2705 from cycomachead/patch-3
Fix Frozen String Error in Commercials Controller
2021-03-06 22:04:48 +01:00
Michael Ball
258a2c1489
Fix Frozen String Error in Commercials Controller
`errors_text` is a frozen string, so `<<` leads to an exception when trying to generate the error message.

https://sentry.cs10.org/share/issue/7867fdaf8eba4387ae2789fd5f1cff3b/
if you want a production example. :)
2021-03-06 21:40:25 +01:00
Sasi Olin
d540092bfc
Add icalendar files (fixes #2147) 2021-03-06 21:18:39 +01:00
Espartaco Palma
490ea3c4b4
DRY on controllers/conferences_controller
Conferences.incoming is defined on the model as scope:

  scope :upcoming, (-> { where('end_date >= ?', Date.current) })
Conference.past

  scope :past, (-> { where('end_date < ?', Date.current) })
2021-03-06 19:00:47 +01:00
Henne Vogelsang
823f41427f
Merge pull request #2591 from openSUSE/remove-travel-schedule
Remove travel schedule from registration
2021-03-06 05:04:07 +01:00
James Mason
7a04f3582f
Remove travel schedule from registration
(cherry picked from commit d18cc02f0185df39bb4213d8a63a955dfb433dcb)
Re: https://github.com/openSUSE/osem/issues/2333
2021-03-06 04:09:02 +01:00
Espartaco Palma
e7452a9d31
Use New Install within their own template
It used to be a partial inside #index, but having their own page
yields some extra benefits:

- Performance: Move logic from the view to the controller
  - Theres' no need to go extra steps inside the :index view
- UI: Remove the extra 'Upcoming Conferences' when the system needs
  to start the flow of the creation of the first user
2021-03-06 03:58:32 +01:00
Hiroshi SHIBATA
ae98ac1430
Fixed some typos (#2695)
* Fix typos
2020-10-30 11:06:43 +02:00
Stella Rouzi
e38cfc55c4
Merge pull request #2586 from rahul2240/bug1
add condition for booth rejection mail
2020-01-07 00:34:38 +02:00
Brian
b828a9d6c6
fixes redirect loop
Redirecting users to `/account/sign_in` caused a redirect loop which crashed the page, but still adds them to the `users` table correctly.. Forcing users to the `root_path` solves the redirect loop.
2019-12-20 08:26:22 -05:00
Rahul
c1941ff35e add if condition to send booth rejection mail 2019-08-23 17:47:56 +05:30
Ana María Martínez Gómez
86440cb956
Merge pull request #2578 from rahul2240/master-alias
add booth in alias
2019-08-10 18:41:34 +02:00
Rahul
bf7a7932ba add booth in alias
Booth can be replaced with any alias by replacing it in alias.en.yml.
2019-08-10 21:40:25 +05:30
Rahul
49c59f1d7a add render in update method
render edit is added so that error and flash message could trigger after the form is submitted.
2019-07-21 20:43:26 +05:30
Henne Vogelsang
e6049adc52
Fix gigitty link
The modal didn't really work on mobiles. On mobiles you also need the schedule
link because it's hard to point your mobile to a QR code on your mobile...
2019-05-24 15:19:37 +02:00
Henne Vogelsang
7338bc2648
Skip CSRF authenticity
The way we are handling adding commercials (preload with javascript)
leads to an outdated token otherwise.
2019-05-24 14:08:23 +02:00
Henne Vogelsang
84b25e3a54
Remove protect_from_forgery
This is handled in ApplicationController
2019-05-24 14:07:39 +02:00
Henne Vogelsang
4dc618810b
Point to Giggity from the schedule page
Tell users that they can also view schedules in an android app.
2019-05-24 11:37:03 +02:00
Ana María Martínez Gómez
b8013661a2
Use render plain instead text
`render text` is deprecated and it has been remvoed from Rails 5.1.
2019-05-13 17:15:31 +02:00
Ana María Martínez Gómez
41d6fad7a5
s/redirect_to :back/redirect_back/
`redirect_to` has been removed in Rails 5.1 in favor of:

```
redirect_back(fallback_location: root_path)
```
2019-05-05 09:40:50 +02:00
Ana María Martínez Gómez
ca32024268
s/skip_before_filter/skip_before_action/
`skip_before_filter` was deprecated in Rails 4.2 and removed in Rails
5.1 in favor of `skip_before_action`.
2019-05-05 09:40:49 +02:00
Stella Rouzi
9bdd889e32
Merge pull request #2471 from rahul2240/export
Fix broken export
2019-04-29 21:35:55 +03:00
Stella Rouzi
0c52f78b32
Merge pull request #2444 from snpd25/branch1
fixed error submission of survey form
2019-04-29 19:29:46 +03:00