When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find visible css ".rating.bright" … 0 times, found 3 matches
expected to find visible css ".rating:not(.bright)" … 5 times, found 2 matches
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:21
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed in the event proposal tab is another user’s
vote, because the fragment’s cache dependencies don’t include the
current user.
resolves#2767
When fragment caching is enabled—
--- a/config/environments/test.rb
+++ b/config/environments/test.rb
@@ -27 +26,0 @@
- config.action_controller.perform_caching = false
@@ -29 +27,0 @@
- config.cache_store = :null_store
—the test of voting fails with:
expected to find text "Not rated" in "…You voted: 3/5…"
# ./spec/features/voting_spec.rb:15
# ./spec/features/voting_spec.rb:13
# ./spec/features/voting_spec.rb:57
i.e. the vote displayed on the event index is another user’s vote,
because the fragment’s cache dependencies don’t include the current
user.
re #2767
Changes:
- restoration of labels that were formerly generated by Formtastic
- corrections to markup of HTML labels and Bootstrap form controls
- minor copy editing
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: select 'boolean', from: 'Type of Question:', visible: false # Hidden by bootstrap-select
Capybara::ElementNotFound:
Unable to find select box "Type of Question:" that is not disabled and Unable to find input box with datalist completion "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# Capybara::ElementNotFound:
# Unable to find select box "Type of Question:" that is not disabled
# ./spec/features/surveys_spec.rb:24:in `block (3 levels) in <top (required)>'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
Resolves:
app/views/admin/surveys/_form.html.haml:25: warning: key :class is duplicated and overwritten on line 25
app/views/admin/surveys/_form.html.haml:27: warning: key :class is duplicated and overwritten on line 27
Resolves:
Failures:
1) Survey as an organizer create a survey
Failure/Error: raise ActionController::MissingExactTemplate, message
ActionController::MissingExactTemplate:
Admin::SurveyQuestionsController#new is missing a template for request formats: text/html
# <internal:kernel>:90:in `tap'
Failed examples:
rspec ./spec/features/surveys_spec.rb:15 # Survey as an organizer create a survey
data-provide="markdown-editable" is intended for inline editing of page
content à la contenteditable. When this is applied to a textarea, the
editor is loaded only after the user clicks on the field. This behavior
breaks focus and is incompatible with keyboard navigation.
Admins may want to have discussions or any other general activity
that does not have any particular speaker. Thus, speaker validation
is removed.
Closes https://github.com/openSUSE/osem/issues/2520
Absolute URLs may be potentially breaking functionality, eg in case of
sub-directory installation.
Fixes https://github.com/openSUSE/osem/issues/2472
Co-authored-by: Ana María Martínez Gómez <anamaria@martinezgomez.name>
If the room size is not set (which is possible as the size is not
mandatory), the events registrations page breaks because of a
comparison of nil with Integer.
While creating a splashpage,admin may want to
select all the options by checking all the boxes
at once, or clear all the checked boxes at
once.
Closes https://github.com/openSUSE/osem/issues/2022
Datapickers in Call for Events/Booths/Tracks were broken which made impossible
to create them (as the date is required).
Those are not the only Datepickers broken and a similar solution should work
for the rest as well.
Fixes https://github.com/openSUSE/osem/issues/2349
Can't cache the event as the data is changed the scheduling js.
We also can't verify the token in the EventSchedules controller
as we are making susequent ajax calls and have no means to refresh
the token for the second request.
Make draggables scrollable.
There also is no need to spam the console with debug code...
Partly fixes#2353
Requiring a ticket after registration is convoluted; while it may be neccesary
for some workflows, it definitely isn't for others, and the core of osem
doesn't need it... so let's make it optional.
* Clean up legacy charting imports
* Update existing donut and line charts
* Create helpers for parsing out existing chart data
* Move chart partials to a more common path
Supercedes https://github.com/openSUSE/osem/pull/2031 .
Note:
* "Questions" modals have been dropped from this view; questions are no
longer asked on registration, since Surveys(PR#1100) were added.
