Commit graph

4479 commits

Author SHA1 Message Date
Henne Vogelsang
89716499ae
Merge pull request #3146 from openSUSE/depfu/update/rqrcode-2.1.2
Update rqrcode: 2.1.1 → 2.1.2 (patch)
2023-04-18 11:54:18 +02:00
Henne Vogelsang
a00aad4f47
Merge pull request #3149 from openSUSE/depfu/update/addressable-2.8.3
Update addressable: 2.8.0 → 2.8.3 (patch)
2023-04-18 11:53:30 +02:00
Henne Vogelsang
22d7275f8f
Merge pull request #3153 from openSUSE/depfu/update/nokogiri-1.14.3
🚨 [security] Update nokogiri: 1.14.0 → 1.14.3 (patch)
2023-04-17 14:15:22 +02:00
depfu[bot]
b1eedab434
Update nokogiri to version 1.14.3 2023-04-11 20:37:21 +00:00
Henne Vogelsang
c6c78b9390
Merge pull request #3152 from hennevogel/feature/lograge
Introduces lograge
2023-04-11 13:57:04 +02:00
Henne Vogelsang
21ce273520
Introduces lograge
for more terse logging
2023-04-11 13:49:22 +02:00
Henne Vogelsang
ab81dd667b
Stop pinning nokogiri for security updates...
The bundle does this already.
2023-04-11 12:55:30 +02:00
Henne Vogelsang
5174c2f3ef
Merge pull request #3151 from hennevogel/update/ruby31
Update to latest ruby 3.1 version
2023-04-11 11:53:00 +02:00
Henne Vogelsang
22beddd3f1
Update to latest ruby 3.1 version 2023-04-11 11:38:49 +02:00
depfu[bot]
0b6a0e888d
Update addressable to version 2.8.3 2023-04-08 11:15:32 +00:00
depfu[bot]
2ee1bec59a
Update rqrcode to version 2.1.2 2023-04-04 13:40:39 +00:00
Henne Vogelsang
41630622b6
Merge pull request #3141 from openSUSE/depfu/update/cancancan-3.5.0
Update cancancan: 3.3.0 → 3.5.0 (minor)
2023-04-04 15:36:01 +02:00
Henne Vogelsang
30c2432ff6
Merge pull request #3128 from openSUSE/depfu/update/tilt-2.1.0
Update tilt: 2.0.10 → 2.1.0 (minor)
2023-04-04 15:35:03 +02:00
Henne Vogelsang
22c1f071ab
Merge pull request #3142 from openSUSE/depfu/update/rack-2.2.6.4
🚨 [security] Update rack: 2.2.6.3 → 2.2.6.4 (patch)
2023-03-21 15:24:57 +01:00
depfu[bot]
1415ea262c
Update rack to version 2.2.6.4 2023-03-15 02:35:30 +00:00
depfu[bot]
46e679c748
Update cancancan to version 3.5.0 2023-03-12 15:15:45 +00:00
Andrew Kvalheim
cdee712d07 Display track description on proposal form
Tracks are otherwise undocumented for CfP respondents.
2023-03-11 13:51:02 -08:00
Andrew Kvalheim
6ed1725b01 Server-side render initial visibility of select help text
Resolves failure to display initial help text of difficulty level.
2023-03-11 13:50:51 -08:00
Andrew Kvalheim
e5ab9b4db1 Test select help text
Incidentally fulfills the same need as #2662
2023-03-11 10:47:32 -08:00
Andrew Kvalheim
741c188260 Move text out of Font Awesome icons
Font Awesome icon elements are intended to be empty. Extending the icon
elements around adjacent text caused the text to be displayed in an
irregular font.
2023-03-10 14:17:46 -08:00
Andrew Kvalheim
1e97b391c2 Clarify to whom emails will be sent 2023-03-08 17:18:51 -08:00
Henne Vogelsang
4de554e0d4
Merge pull request #3134 from openSUSE/depfu/update/rack-2.2.6.3
🚨 [security] Update rack: 2.2.6.2 → 2.2.6.3 (patch)
2023-03-08 14:13:33 +01:00
depfu[bot]
2b77d5128e
Update rack to version 2.2.6.3 2023-03-07 20:24:24 +00:00
Andrew Kvalheim
1f31c1c80d Correct invalid table markup
- Add required <tr> within <thead>
  - Add implicit <tbody> after <thead>
2023-03-04 14:33:08 -08:00
Andrew Kvalheim
e01fd2d721 Add URLs to API responses
Resolves inability of API consumers to provide links to OSEM.
2023-03-04 10:15:56 -08:00
Andrew Kvalheim
80d7ac545c Set nofollow on links in Markdown content
To disincentivize spamdexing, links in user-generated content should be
disavowed by annotation with `rel="nofollow"` attributes:

  - https://en.wikipedia.org/wiki/Nofollow

Automated spam has already targeted OSEM in the wild:

  - https://github.com/SeaGL/organization/issues/274

Ideally link annotation would be performed during Markdown rendering or
a single sanitization pass, but this is currently an unresolved issue:

  - https://github.com/vmg/redcarpet/issues/720
2023-03-03 17:16:53 -08:00
Andrew Kvalheim
c54a8a1238 Add tests of HTML sanitization 2023-03-03 16:50:20 -08:00
Andrew Kvalheim
04f6a73d73 Add user to cache dependencies of event proposal tab
When fragment caching is enabled—

    --- a/config/environments/test.rb
    +++ b/config/environments/test.rb
    @@ -27 +26,0 @@
    -  config.action_controller.perform_caching = false
    @@ -29 +27,0 @@
    -  config.cache_store = :null_store

—the test of voting fails with:

    expected to find visible css ".rating.bright" … 0 times, found 3 matches
    expected to find visible css ".rating:not(.bright)" … 5 times, found 2 matches
    # ./spec/features/voting_spec.rb:21
    # ./spec/features/voting_spec.rb:21
    # ./spec/features/voting_spec.rb:57

i.e. the vote displayed in the event proposal tab is another user’s
vote, because the fragment’s cache dependencies don’t include the
current user.

resolves #2767
2023-03-01 11:52:16 -08:00
Andrew Kvalheim
1563881153 Add user to cache dependencies of vote in events index
When fragment caching is enabled—

    --- a/config/environments/test.rb
    +++ b/config/environments/test.rb
    @@ -27 +26,0 @@
    -  config.action_controller.perform_caching = false
    @@ -29 +27,0 @@
    -  config.cache_store = :null_store

—the test of voting fails with:

    expected to find text "Not rated" in "…You voted: 3/5…"
    # ./spec/features/voting_spec.rb:15
    # ./spec/features/voting_spec.rb:13
    # ./spec/features/voting_spec.rb:57

i.e. the vote displayed on the event index is another user’s vote,
because the fragment’s cache dependencies don’t include the current
user.

re #2767
2023-03-01 11:43:50 -08:00
Andrew Kvalheim
17366c6eab Update events when rated
When fragment caching is enabled—

    --- a/config/environments/test.rb
    +++ b/config/environments/test.rb
    @@ -27 +26,0 @@
    -  config.action_controller.perform_caching = false
    @@ -29 +27,0 @@
    -  config.cache_store = :null_store

—the test of voting fails with:

    expected to find css ".rating.bright" … 3 times but there were no matches
    expected to find visible css ".rating:not(.bright)" … 2 times, found 5 matches
    # ./spec/features/voting_spec.rb:31
    # ./spec/features/voting_spec.rb:30
    # ./spec/features/voting_spec.rb:53

i.e. the rating displayed on the event index is not updated after
voting, because while the fragment’s cache dependencies include the
event, voting doesn’t update the event.

re #2767
2023-03-01 11:33:21 -08:00
Andrew Kvalheim
4df59d85e2 Add test of voting 2023-03-01 11:17:39 -08:00
Andrew Kvalheim
5b89f64eaf Set default URL host
Setting the default host resolves:

    Missing host to link to! Please provide the :host parameter, set
    default_url_options[:host], or set :only_path to true

Configuring RSpec to use the default host resolves:

    Expected response to be a redirect to <http://test.host/…>
    but was a redirect to <http://localhost/…>.
2023-02-28 11:06:24 -08:00
depfu[bot]
e7c2375dcf
Update tilt to version 2.1.0 2023-02-24 17:45:28 +00:00
Henne Vogelsang
097470bb0c
Merge pull request #3125 from hennevogel/update/base-os
Update our base os
2023-02-02 18:58:27 +01:00
Henne Vogelsang
c5d46867c3
Stop installing bundler/foreman, it's done in osem/base now 2023-02-02 18:47:44 +01:00
Henne Vogelsang
13374571c9
Update ruby/bundler version to the one we use in osem/base 2023-02-02 18:47:43 +01:00
Henne Vogelsang
41287aea03
Remove outdated badges 2023-02-01 14:10:01 +01:00
Henne Vogelsang
164ae1cdc1
Add initial railway configuration 2023-02-01 13:45:27 +01:00
Henne Vogelsang
2844024ad8
Merge pull request #3086 from openSUSE/depfu/update/momentjs-rails-2.29.4.1
Update momentjs-rails: 2.29.1.1 → 2.29.4.1 (patch)
2023-01-24 13:43:13 +01:00
depfu[bot]
16584d0313
Update momentjs-rails to version 2.29.4.1 2023-01-23 10:55:38 +00:00
Henne Vogelsang
1f85d9d3f3
Merge pull request #3120 from openSUSE/depfu/update/rack-2.2.6.2
🚨 [security] Update rack: 2.2.4 → 2.2.6.2 (minor)
2023-01-23 11:54:48 +01:00
Henne Vogelsang
266049b27b
Merge pull request #3119 from openSUSE/depfu/update/globalid-1.0.1
🚨 [security] Update globalid: 1.0.0 → 1.0.1 (patch)
2023-01-23 11:54:37 +01:00
Henne Vogelsang
492a8907e8
Merge pull request #3109 from openSUSE/depfu/update/rails-html-sanitizer-1.4.4
🚨 [security] Update rails-html-sanitizer: 1.4.3 → 1.4.4 (patch)
2023-01-23 11:54:15 +01:00
Henne Vogelsang
3ead127065
Merge pull request #3108 from openSUSE/depfu/update/loofah-2.19.1
🚨 [security] Update loofah: 2.18.0 → 2.19.1 (minor)
2023-01-23 11:53:48 +01:00
depfu[bot]
4422ea0dae
Update rack to version 2.2.6.2 2023-01-20 16:30:34 +00:00
depfu[bot]
702e01b5af
Update globalid to version 1.0.1 2023-01-20 16:25:36 +00:00
depfu[bot]
65be3e1d03
Update rails-html-sanitizer to version 1.4.4 2023-01-20 16:20:51 +00:00
depfu[bot]
bfd9f9cd15
Update loofah to version 2.19.1 2023-01-20 16:15:30 +00:00
Henne Vogelsang
b7ed61680c
Merge pull request #3118 from openSUSE/depfu/update/nokogiri-1.14.0
🚨 [security] Update nokogiri: 1.13.8 → 1.14.0 (minor)
2023-01-20 17:10:16 +01:00
depfu[bot]
57847e4022
Update nokogiri to version 1.14.0 2023-01-19 22:15:49 +00:00