Commit graph

861 commits

Author SHA1 Message Date
Michael Ball
d1ca21f479 Merge OSEM updates 2021-03-08 02:50:27 -08:00
Michael Ball
8242eb3338 Remove submission_limit validation for submission_text 2021-03-08 02:18:44 -08:00
Michael Ball
2d1246448c Add some tests for the submission instructions 2021-03-08 02:13:57 -08:00
Michael Ball
bc4177154a Add editing submission instructions 2021-03-06 12:45:00 -08:00
Henne Vogelsang
58d51c6d25
Merge pull request #2648 from AndrewKvalheim/webmock-webdrivers
Resolve conflict between WebMock and Webdrivers
2021-03-06 21:38:06 +01:00
Michael Ball
3d99661d02 Add a submission instructions columns 2021-03-06 11:30:57 -08:00
Henne Vogelsang
7f1d3b923a
Merge pull request #2662 from AndrewKvalheim/issue-2661-workaround
Fix bug in test of animated form
2021-03-06 20:02:04 +01:00
Henne Vogelsang
0729c6f6fe
Merge pull request #2659 from AndrewKvalheim/transactional-tests
Use Rails transactional tests
2021-03-06 20:01:47 +01:00
Andrew Kvalheim
07f1323eff
Fix bug in test of animated form
The help text for the event type field is animated using a technique
unaffected by `Capybara.disable_animation`. Wait for the animation.

Resolves: #2356
Works around: #2661
2021-03-06 19:43:35 +01:00
Andrew Kvalheim
c3e02c20b9
Use Rails transactional tests
As of Rails 5.1:

  - Rails has built-in support for running tests within database
    transactions, so Database Cleaner is no longer needed for this.
  - Rails automatically shares the database connection across threads,
    so transactional_capybara is no longer needed.

Changes:

  - Enable `use_transactional_tests`.
  - Remove transactional_capybara.
  - Remove the Database Cleaner test wrapper.

This resolves:

  - transactional_capybara mismanages the shared database connection,
    causing the connection to falsely report as idle after the first
    test. At 6 minutes (idle_timeout + reaping_frequency) into testing,
    the connection is closed, causing e.g. `PG::ConnectionBad` errors.
2021-03-06 19:41:06 +01:00
Andrew Kvalheim
310fc8dc68
Fix bug in test database preparation
Presumably the intent of this was to clear the database and repopulate
it with seed data. `transaction` isn't the right strategy for this; it
just rolls back any existing transactions.
2021-03-06 19:41:06 +01:00
Andrew Kvalheim
2c8521a2e5
Remove redundant code
This functionality is provided by transactional_capybara.
2021-03-06 19:41:05 +01:00
Andrew Kvalheim
c0913ab723
Work around RuboCop false positive
Details: rubocop-hq/rubocop#7853
2021-03-06 19:38:47 +01:00
Andrew Kvalheim
0df16e4773
Fix bug in logging of screenshots of failed tests
Presumably this was a typo.
2021-03-06 19:38:47 +01:00
Andrew Kvalheim
fa129d218f
Whitelist Webdrivers update URLs in WebMock
Resolves #2557:

    $ docker-compose run --rm osem bundle exec rspec --tag js
    …
    WebMock::NetConnectNotAllowedError

See titusfortner/webdrivers#109 for details.
2021-03-06 19:20:30 +01:00
Espartaco Palma
5d79049e59
Linters gonna lint
I was not aware the linting was also applied to specs
2021-03-06 19:09:38 +01:00
Espartaco Palma
fd2635509f
Introducing delegation for city and country name (Conference - Venue
Using ActiveSupport delegate macro.
2021-03-06 19:06:36 +01:00
Henne Vogelsang
2b0a257090
Set cobertura as simplecove formatter in github actions 2021-03-06 18:37:04 +01:00
Stella Rouzi
cb7519f7a4
Check CfP existence in proposal form 2021-03-06 12:38:02 +01:00
Henne Vogelsang
823f41427f
Merge pull request #2591 from openSUSE/remove-travel-schedule
Remove travel schedule from registration
2021-03-06 05:04:07 +01:00
James Mason
7a04f3582f
Remove travel schedule from registration
(cherry picked from commit d18cc02f0185df39bb4213d8a63a955dfb433dcb)
Re: https://github.com/openSUSE/osem/issues/2333
2021-03-06 04:09:02 +01:00
Emily Gonyer
77accc1100
removed-gendered-terms 2021-03-06 03:27:38 +01:00
Henne Vogelsang
b688d353ac
Skip some failing specs... 2021-03-06 02:41:07 +01:00
Henne Vogelsang
634bc832e3
Remove pry requires from spec 2021-03-06 02:41:07 +01:00
Jimmy
6e3cdc2614 [test] Add test for auto-redirect 2021-03-04 22:05:55 -08:00
CactusPuppy
207046dc65
Merge pull request #11 from CactusPuppy/176894810/add_summision_text
Add submission text to event proposals
2021-03-01 23:38:06 -08:00
CactusPuppy
54a5f84d8b
Prefer single-quoted strings 2021-03-01 23:01:28 -08:00
CactusPuppy
30ec69282d
Fix '==' instead of assignment operator 2021-03-01 23:00:04 -08:00
CactusPuppy
c8e6dc86d7
Increase test coverage to stop codecov from complaining 2021-03-01 22:56:45 -08:00
lzy-1006
9ee29f6daa
Merge pull request #12 from CactusPuppy/176895037-add-link-to-view-event-from-admin-page
Add link to view event from admin page
2021-03-01 21:45:32 -08:00
CactusPuppy
f207d070ac
Add spec for submission limits 2021-02-27 11:29:27 -08:00
CactusPuppy
0aa33c497c
Ensure that user is actually guest when testing 2021-02-27 11:25:37 -08:00
CactusPuppy
b94894fe87
Update annotate_models 2021-02-26 11:04:20 -08:00
Jimmy
05f877cfe5 [test] Add tests for previewing proposal in admin page 2021-02-25 11:15:23 -08:00
madhekare
16d9dfef4c
submission_text rspec 2021-02-24 23:41:19 -08:00
Jimmy
e44714b06b Merge branch 'master' of https://github.com/CactusPuppy/snapcon into 176917559-add-brand-elements-to-email 2021-02-24 22:08:12 -08:00
Michael Ball
9abaf38e5a
Delint from a local pronto run 2021-02-24 21:44:02 -08:00
CactusPuppy
50675c8dbe
Fix a minor typo with spec description 2021-02-24 20:55:59 -08:00
CactusPuppy
38c10d326d
Fix spec incorrectly testing for conference org names 2021-02-24 20:55:30 -08:00
CactusPuppy
82a08ffa74
Fix typo 2021-02-24 20:28:13 -08:00
CactusPuppy
21e282679f
Fix Rubocop issues 2021-02-24 20:24:03 -08:00
Michael Ball
c170221605 More image/nav tests 2021-02-24 20:10:05 -08:00
Michael Ball
005aebd936 Minor app helper tests 2021-02-24 20:07:12 -08:00
Michael Ball
92f23a519e Fix outdated datatables spec 2021-02-24 12:53:01 -08:00
Michael Ball
2b2745ade9 run rubocp --fix 2021-02-24 09:47:56 -08:00
Michael Ball
1ca72dcf74 Attempt to fixup logo specs 2021-02-24 09:34:04 -08:00
Michael Ball
13aa7db90d use TODO-SNAPCON for the comment tag since rubocop is not flexible enough 2021-02-24 03:32:19 -08:00
Michael Ball
60b9684dd8 Sigh...skip one more annoying spec 2021-02-24 02:28:44 -08:00
Michael Ball
8c51c27146 Skip Admin Dashboard specs since front end metrics are disabled 2021-02-24 02:19:05 -08:00
Michael Ball
49821fff52 Fix TicketScanning spec by properly creating a *paid* ticket purchase 2021-02-24 02:03:49 -08:00