Commit graph

7 commits

Author SHA1 Message Date
Jimmy
1fd1d395d5
[test]Add test for ConferenceHelper#get_happening_next_events_schedules 2021-04-19 13:33:00 +08:00
Jimmy
2bcd7d39b3 [test] Add unit test for conference_helper#conference_color 2021-03-12 07:49:55 -08:00
Jimmy
72dd36993b [style] Remove unused variable 2021-03-12 00:20:30 -08:00
Jimmy
fdb08b0c9a [refactor] Move Mailbot#logo_url and #conference_color to ConferenceHelper 2021-03-12 00:14:29 -08:00
James Mason
6d31dfeef4 Add frozen_string_literal magic comment
re: https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Style/FrozenStringLiteralComment
2018-05-09 06:54:26 -07:00
James Mason
fa55224163 Break up the one-query-of-doom
The single query was producing a tremendously large ActiveRecord allocation.

While this isn't nearly as cool as one query, it's still a significant
reduction in SQL trips, and now has the bonus of only loading what is
actually going to be displayed.
2017-12-22 10:48:55 -08:00
James Mason
27f6d8ad73 Let's get serious about linting, folks. 2017-12-22 10:48:55 -08:00