Commit graph

890 commits

Author SHA1 Message Date
CactusPuppy
039a931c90
Ensure coverage.xml is generated on Travis 2021-03-18 20:32:57 -07:00
Jimmy
cab293e947 [fix] Fix event_schedule# happening_now?; Add tests for happening_now JSON endpoint 2021-03-18 18:53:55 +08:00
Jimmy
871457f65b [feat] Use existing #happening_now method; respond to both html and json requests 2021-03-17 21:02:35 +08:00
Jimmy
fcb3dc96c0 [style] Delete comments 2021-03-12 21:16:21 -08:00
Jimmy
2bcd7d39b3 [test] Add unit test for conference_helper#conference_color 2021-03-12 07:49:55 -08:00
Jimmy
72dd36993b [style] Remove unused variable 2021-03-12 00:20:30 -08:00
Jimmy
fdb08b0c9a [refactor] Move Mailbot#logo_url and #conference_color to ConferenceHelper 2021-03-12 00:14:29 -08:00
Jimmy
fc0494c1f3 Merge branch 'master' of https://github.com/CactusPuppy/snapcon into 177195121-improve-email-templates 2021-03-11 23:23:24 -08:00
Jimmy
394dc0506f temp 2021-03-11 23:15:07 -08:00
Jimmy
4856bc718d [fix] Restore a mistakenly deleted test 2021-03-11 22:00:15 -08:00
Jimmy
11d4255c67 merge 2021-03-11 21:28:17 -08:00
Jimmy
899d4c91f6 [test] Simplify mailbot.rb; Add corresponding tests 2021-03-10 23:09:52 -08:00
Jimmy
130bff9506 [fix] change pending to skip to satisfy CI 2021-03-10 16:36:09 -08:00
Jimmy
fb07a43566 [style] fix style 2021-03-10 16:20:01 -08:00
Jimmy
75baeb4f98 [fix] Fix ticket purchases tests 2021-03-10 16:17:34 -08:00
Jimmy
85c7b31a77 Merge branch 'master' of https://github.com/CactusPuppy/snapcon into 176895512-automatically-redirect-to-registration-after-buying-a-ticket 2021-03-10 14:58:01 -08:00
CactusPuppy
58ae746e78
Add test for covering Rest to Template button 2021-03-10 13:26:45 -08:00
Jimmy
aa1b281f9a [test] Fix test for user#count_registration_tickets 2021-03-10 11:00:14 -08:00
Michael Ball
0428d07736 Fixup specs for stripe to acctually run and be accurate. Mostly.
* extracts a bunch of logic to be more native capybara
* updates for existing changes in the app
* using ENV directly is an antipattern...but oh well.
* TBD: Why is unregister failing?
2021-03-10 03:30:22 -08:00
Jimmy
9fd6659d9d [style] fix style 2021-03-09 18:31:02 -08:00
Jimmy
59d19b3ae8 [style] fix style 2021-03-09 18:28:09 -08:00
Jimmy
11a4d200f7 [test] Fix style; add test for user#count_registration_tickets 2021-03-09 18:25:15 -08:00
Michael Ball
d93390faa6 Fix datatables spec 2021-03-08 21:00:06 -08:00
Michael Ball
332bf8f1df Support the ability for admins to delete users 2021-03-08 20:19:57 -08:00
Michael Ball
e311a65f02 Delint Autofix 2021-03-08 16:50:56 -08:00
Michael Ball
f3271f5cdc Merge master 2021-03-08 16:48:06 -08:00
Michael Ball
fd4d776e2c datatables specs are passing on this fork! 2021-03-08 11:28:52 -08:00
Michael Ball
4d34817928
Delint 2021-03-08 03:08:03 -08:00
Michael Ball
337a04d4ab
Delint 2021-03-08 03:07:56 -08:00
Michael Ball
d1ca21f479 Merge OSEM updates 2021-03-08 02:50:27 -08:00
Michael Ball
8242eb3338 Remove submission_limit validation for submission_text 2021-03-08 02:18:44 -08:00
Michael Ball
2d1246448c Add some tests for the submission instructions 2021-03-08 02:13:57 -08:00
Michael Ball
bc4177154a Add editing submission instructions 2021-03-06 12:45:00 -08:00
Henne Vogelsang
58d51c6d25
Merge pull request #2648 from AndrewKvalheim/webmock-webdrivers
Resolve conflict between WebMock and Webdrivers
2021-03-06 21:38:06 +01:00
Michael Ball
3d99661d02 Add a submission instructions columns 2021-03-06 11:30:57 -08:00
Henne Vogelsang
7f1d3b923a
Merge pull request #2662 from AndrewKvalheim/issue-2661-workaround
Fix bug in test of animated form
2021-03-06 20:02:04 +01:00
Henne Vogelsang
0729c6f6fe
Merge pull request #2659 from AndrewKvalheim/transactional-tests
Use Rails transactional tests
2021-03-06 20:01:47 +01:00
Andrew Kvalheim
07f1323eff
Fix bug in test of animated form
The help text for the event type field is animated using a technique
unaffected by `Capybara.disable_animation`. Wait for the animation.

Resolves: #2356
Works around: #2661
2021-03-06 19:43:35 +01:00
Andrew Kvalheim
c3e02c20b9
Use Rails transactional tests
As of Rails 5.1:

  - Rails has built-in support for running tests within database
    transactions, so Database Cleaner is no longer needed for this.
  - Rails automatically shares the database connection across threads,
    so transactional_capybara is no longer needed.

Changes:

  - Enable `use_transactional_tests`.
  - Remove transactional_capybara.
  - Remove the Database Cleaner test wrapper.

This resolves:

  - transactional_capybara mismanages the shared database connection,
    causing the connection to falsely report as idle after the first
    test. At 6 minutes (idle_timeout + reaping_frequency) into testing,
    the connection is closed, causing e.g. `PG::ConnectionBad` errors.
2021-03-06 19:41:06 +01:00
Andrew Kvalheim
310fc8dc68
Fix bug in test database preparation
Presumably the intent of this was to clear the database and repopulate
it with seed data. `transaction` isn't the right strategy for this; it
just rolls back any existing transactions.
2021-03-06 19:41:06 +01:00
Andrew Kvalheim
2c8521a2e5
Remove redundant code
This functionality is provided by transactional_capybara.
2021-03-06 19:41:05 +01:00
Andrew Kvalheim
c0913ab723
Work around RuboCop false positive
Details: rubocop-hq/rubocop#7853
2021-03-06 19:38:47 +01:00
Andrew Kvalheim
0df16e4773
Fix bug in logging of screenshots of failed tests
Presumably this was a typo.
2021-03-06 19:38:47 +01:00
Andrew Kvalheim
fa129d218f
Whitelist Webdrivers update URLs in WebMock
Resolves #2557:

    $ docker-compose run --rm osem bundle exec rspec --tag js
    …
    WebMock::NetConnectNotAllowedError

See titusfortner/webdrivers#109 for details.
2021-03-06 19:20:30 +01:00
Espartaco Palma
5d79049e59
Linters gonna lint
I was not aware the linting was also applied to specs
2021-03-06 19:09:38 +01:00
Espartaco Palma
fd2635509f
Introducing delegation for city and country name (Conference - Venue
Using ActiveSupport delegate macro.
2021-03-06 19:06:36 +01:00
Henne Vogelsang
2b0a257090
Set cobertura as simplecove formatter in github actions 2021-03-06 18:37:04 +01:00
Stella Rouzi
cb7519f7a4
Check CfP existence in proposal form 2021-03-06 12:38:02 +01:00
Henne Vogelsang
823f41427f
Merge pull request #2591 from openSUSE/remove-travel-schedule
Remove travel schedule from registration
2021-03-06 05:04:07 +01:00
James Mason
7a04f3582f
Remove travel schedule from registration
(cherry picked from commit d18cc02f0185df39bb4213d8a63a955dfb433dcb)
Re: https://github.com/openSUSE/osem/issues/2333
2021-03-06 04:09:02 +01:00