gunghogeoduck/osem-fcy
1
0
Fork 0
mirror of https://github.com/openSUSE/osem.git synced 2026-08-13 19:54:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions
5154 commits 15 branches 2 tags 50 MiB
Commit graph

7 commits

Author SHA1 Message Date
Andrew Kvalheim
57e9135287 Use CSS-compatible row IDs in datatables 
In CSS IDs may not begin with a number:

  - https://www.w3.org/TR/CSS21/syndata.html#value-def-identifier
 2022-09-13 11:06:22 -07:00
Andrew Kvalheim
7e9ce60293 Partially revert "Skip some failing specs..." 
This reverts the skipping of tests by commit b688d353ac in:

  - `spec/models/user_spec.rb`
  - `spec/controllers/admin/users_controller_spec.rb`
  - `spec/datatables/user_datatable_spec.rb`
 2022-03-08 17:18:34 -08:00
Andrew Kvalheim
83636afee0 Update UserDatatable for ajax-datatables-rails 1 
Resolves failing test `spec/datatables/user_datatable_spec.rb:97`:

    1) UserDatatable outputs recordsTotal
       Failure/Error: filter_records(fetch_records).unscope(:group, :select).count(:all)

       NotImplementedError:
         NotImplementedError
       # ./app/datatables/user_datatable.rb:59:in `records_filtered_count'
       # ./spec/datatables/user_datatable_spec.rb:95:in `block (3 levels) in <top (required)>'
       # ./spec/datatables/user_datatable_spec.rb:98:in `block (3 levels) in <top (required)>'

Details: https://github.com/jbox-web/ajax-datatables-rails/blob/v1.3.1/doc/migrate.md#to-migrate-from-v04x-to-v100

RegistrationDatatable has already been updated in 81853d1ef9.
 2022-03-06 23:12:02 -08:00
Henne Vogelsang
4e9e13e2fd
rspec exits with 1 for pending specs somehow... 2021-08-11 14:15:47 +02:00
Henne Vogelsang
b688d353ac
Skip some failing specs... 2021-03-06 02:41:07 +01:00
James Mason
43bef689fc Rubocop autocorrections 2018-11-16 09:06:05 -08:00
James Mason
64ceaf50f4 Update Admin user datatables to use AJAX 2018-08-30 16:50:42 +02:00