gunghogeoduck/osem-fcy
1
0
Fork 0
mirror of https://github.com/openSUSE/osem.git synced 2026-08-16 13:14:03 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add helper function for speaker selection

Browse source 
The line '@users = User.all.order(:name)' is replicated a lot of times
in EventsController and ProposalsController.
So, this commit removes it and adds a helper function
'speaker_selector_input' that generates the field where the @users
variable was used.
Also, it makes the query more specific.

Fix #1455

Other changes:
* Include the username in the drop down menu
* Add .active scope to User and corresponding tests
* Add :disabled trait to User factory
This commit is contained in:
AEtherC0r3 2017-04-22 09:40:08 +03:00 • committed by Stella Rouzi
parent 36b8088726
commit fa56ff7f6d
7 changed files with 25 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/proposals_controller.rb
View file

@ -25,7 +25,6 @@ class ProposalsController < ApplicationController
def edit
@url = conference_program_proposal_path(@conference.short_title, params[:id])
@users = User.all.order(:name)
@languages = @program.languages_list
end
@ -61,7 +60,6 @@ class ProposalsController < ApplicationController
def update
@url = conference_program_proposal_path(@conference.short_title, params[:id])
@users = User.all.order(:name)
if @event.update(event_params)
redirect_to conference_program_proposals_path(conference_id: @conference.short_title),