From f63259f18705cd62b2296dcd34bede26956e8096 Mon Sep 17 00:00:00 2001 From: hitman Date: Mon, 6 Mar 2017 23:54:52 +0530 Subject: [PATCH] update rubocop.yml for new files --- .rubocop_todo.yml | 113 ++++++++++++++++++---------------------------- 1 file changed, 44 insertions(+), 69 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 4356de97..c745c398 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2017-04-21 21:35:17 +0530 using RuboCop version 0.48.1. +# on 2017-05-06 15:57:26 +0530 using RuboCop version 0.48.1. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -57,26 +57,26 @@ Lint/UnusedBlockArgument: Exclude: - 'lib/tasks/user.rake' -# Offense count: 106 +# Offense count: 109 Metrics/AbcSize: Max: 75 -# Offense count: 225 +# Offense count: 201 # Configuration parameters: CountComments, ExcludedMethods. Metrics/BlockLength: - Max: 1364 + Max: 487 -# Offense count: 19 +# Offense count: 21 Metrics/CyclomaticComplexity: Max: 12 -# Offense count: 1967 +# Offense count: 1990 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https Metrics/LineLength: Max: 619 -# Offense count: 115 +# Offense count: 117 # Configuration parameters: CountComments. Metrics/MethodLength: Max: 56 @@ -88,7 +88,8 @@ Metrics/ModuleLength: Exclude: - 'app/helpers/application_helper.rb' -# Offense count: 14 + +# Offense count: 15 Metrics/PerceivedComplexity: Max: 15 @@ -108,17 +109,16 @@ Rails/ActionFilter: - 'app/controllers/tickets_controller.rb' - 'app/controllers/users/omniauth_callbacks_controller.rb' -# Offense count: 9 +# Offense count: 7 # Cop supports --auto-correct. # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. Rails/Blank: Exclude: - 'app/models/program.rb' - 'app/models/user.rb' - - 'lib/tasks/update_resource_quantity.rake' - 'spec/factories/event_schedule.rb' -# Offense count: 140 +# Offense count: 139 # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: strict, flexible Rails/Date: @@ -181,7 +181,7 @@ Rails/HttpPositionalArguments: # Offense count: 2 Rails/OutputSafety: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' - 'app/models/commercial.rb' # Offense count: 10 @@ -195,7 +195,7 @@ Rails/PluralizationGrammar: # Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. Rails/Present: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/users_helper.rb' - 'app/models/campaign.rb' - 'app/models/cfp.rb' - 'app/models/email_settings.rb' @@ -279,7 +279,7 @@ Style/ClassVars: Exclude: - 'spec/support/kneet_connections.rb' -# Offense count: 5 +# Offense count: 9 # Cop supports --auto-correct. Style/ClosingParenthesisIndentation: Exclude: @@ -312,7 +312,7 @@ Style/CommentIndentation: - 'app/models/track.rb' - 'spec/features/volunteers_spec.rb' -# Offense count: 3 +# Offense count: 8 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly, IncludeTernaryExpressions. # SupportedStyles: assign_to_condition, assign_inside_condition @@ -320,14 +320,14 @@ Style/ConditionalAssignment: Exclude: - 'app/controllers/admin/volunteers_controller.rb' - 'app/controllers/conference_registrations_controller.rb' - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' - 'app/models/conference.rb' - 'app/models/ticket_purchase.rb' - 'app/models/user.rb' - 'db/migrate/20140610165551_migrate_data_person_to_user.rb' - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' -# Offense count: 429 +# Offense count: 435 Style/Documentation: Enabled: false @@ -335,13 +335,14 @@ Style/Documentation: # Cop supports --auto-correct. Style/ElseAlignment: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' # Offense count: 2 # Cop supports --auto-correct. Style/EmptyCaseCondition: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/change_description_helper.rb' + - 'app/helpers/format_helper.rb' # Offense count: 1 # Cop supports --auto-correct. @@ -349,7 +350,7 @@ Style/EmptyLineAfterMagicComment: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 107 +# Offense count: 106 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: empty_lines, no_empty_lines @@ -404,31 +405,17 @@ Style/FileName: - 'Gemfile' - 'Vagrantfile' -# Offense count: 38 +# Offense count: 42 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth. # SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses Style/FirstParameterIndentation: Enabled: false -# Offense count: 22 +# Offense count: 23 # Configuration parameters: MinBodyLength. Style/GuardClause: - Exclude: - - 'app/controllers/admin/questions_controller.rb' - - 'app/controllers/conference_registrations_controller.rb' - - 'app/controllers/tickets_controller.rb' - - 'app/helpers/application_helper.rb' - - 'app/models/ability.rb' - - 'app/models/cfp.rb' - - 'app/models/commercial.rb' - - 'app/models/conference.rb' - - 'app/models/registration.rb' - - 'app/models/ticket.rb' - - 'app/models/user.rb' - - 'app/serializers/conference_serializer.rb' - - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' - - 'lib/tasks/data.rake' + Enabled: false # Offense count: 4 # Cop supports --auto-correct. @@ -439,7 +426,7 @@ Style/HashSyntax: - 'Gemfile' - 'lib/tasks/user.rake' -# Offense count: 23 +# Offense count: 22 # Cop supports --auto-correct. # Configuration parameters: MaxLineLength. Style/IfUnlessModifier: @@ -448,7 +435,7 @@ Style/IfUnlessModifier: - 'app/controllers/api/v1/events_controller.rb' - 'app/controllers/conference_registrations_controller.rb' - 'app/controllers/users/omniauth_callbacks_controller.rb' - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' - 'app/models/commercial.rb' - 'app/models/conference.rb' - 'app/models/ticket_purchase.rb' @@ -456,7 +443,6 @@ Style/IfUnlessModifier: - 'db/migrate/20151031092713_change_conference_id_to_venue_id_in_rooms.rb' - 'lib/tasks/events_registrations.rake' - 'spec/controllers/admin/conferences_controller_spec.rb' - - 'spec/features/omniauth_spec.rb' - 'spec/support/flash.rb' # Offense count: 2 @@ -472,7 +458,7 @@ Style/IndentArray: # Configuration parameters: IndentationWidth. Style/IndentAssignment: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' - 'app/models/conference.rb' # Offense count: 3 @@ -494,12 +480,12 @@ Style/IndentationConsistency: - 'app/models/event.rb' - 'spec/controllers/subscriptions_controller_spec.rb' -# Offense count: 7 +# Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: Width, IgnoredPatterns. Style/IndentationWidth: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' - 'app/serializers/conference_serializer.rb' - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - 'lib/tasks/demo_data_for_development.rake' @@ -583,7 +569,6 @@ Style/MultilineMethodCallIndentation: # SupportedStyles: aligned, indented Style/MultilineOperationIndentation: Exclude: - - 'app/controllers/admin/conferences_controller.rb' - 'app/controllers/admin/events_controller.rb' - 'app/controllers/application_controller.rb' - 'app/models/ability.rb' @@ -598,14 +583,6 @@ Style/MutableConstant: - 'app/models/event_user.rb' - 'lib/tasks/migrate_config.rake' -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle, SupportedStyles. -# SupportedStyles: both, prefix, postfix -Style/NegatedIf: - Exclude: - - 'lib/tasks/update_resource_quantity.rake' - # Offense count: 4 # Cop supports --auto-correct. Style/NestedParenthesizedCalls: @@ -649,7 +626,8 @@ Style/NumericPredicate: Exclude: - 'spec/**/*' - 'app/controllers/admin/conferences_controller.rb' - - 'app/helpers/application_helper.rb' + - 'app/helpers/date_time_helper.rb' + - 'app/helpers/format_helper.rb' - 'app/models/user.rb' # Offense count: 3 @@ -664,7 +642,7 @@ Style/ParenthesesAroundCondition: Exclude: - 'app/controllers/admin/base_controller.rb' - 'app/controllers/application_controller.rb' - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' # Offense count: 17 # Cop supports --auto-correct. @@ -722,12 +700,15 @@ Style/RedundantParentheses: Exclude: - 'app/controllers/admin/base_controller.rb' -# Offense count: 10 +# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Exclude: - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' + - 'app/helpers/paths_helper.rb' + - 'app/helpers/users_helper.rb' # Offense count: 2 # Cop supports --auto-correct. @@ -767,21 +748,13 @@ Style/SpaceAfterComma: Exclude: - 'lib/tasks/data_demo.rake' -# Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyleInsidePipes, SupportedStylesInsidePipes. -# SupportedStylesInsidePipes: space, no_space -Style/SpaceAroundBlockParameters: - Exclude: - - 'app/helpers/application_helper.rb' - # Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: space, no_space Style/SpaceAroundEqualsInParameterDefault: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' - 'app/models/event.rb' # Offense count: 1 @@ -791,7 +764,7 @@ Style/SpaceAroundOperators: Exclude: - 'lib/tasks/data.rake' -# Offense count: 315 +# Offense count: 319 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: space, no_space @@ -887,7 +860,7 @@ Style/StringLiteralsInInterpolation: Exclude: - 'lib/tasks/dump_db.rake' -# Offense count: 59 +# Offense count: 60 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: percent, brackets @@ -914,14 +887,16 @@ Style/SymbolProc: # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex Style/TernaryParentheses: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' -# Offense count: 2 +# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. # SupportedStyles: final_newline, final_blank_line Style/TrailingBlankLines: Exclude: + - 'app/helpers/change_description_helper.rb' + - 'app/helpers/paths_helper.rb' - 'lib/tasks/event_attatchments.rake' - 'lib/tasks/roles.rake' @@ -945,7 +920,7 @@ Style/TrailingWhitespace: # Cop supports --auto-correct. Style/UnneededInterpolation: Exclude: - - 'app/helpers/application_helper.rb' + - 'app/helpers/format_helper.rb' - 'spec/controllers/admin/conferences_controller_spec.rb' # Offense count: 2