gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Properly fire update_email hook after commit which changes user email

Browse source
This commit is contained in:
CactusPuppy 2021-03-31 21:08:28 -07:00
parent 9f19f5d913
commit f0296e2150
No known key found for this signature in database
GPG key ID: 4B33B0A3E15E2C82
2 changed files with 57 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
app/models/user.rb
View file

@ -82,7 +82,12 @@ class User < ApplicationRecord
after_create_commit :mailbluster_create_lead
after_destroy_commit :mailbluster_delete_lead
after_update_commit :mailbluster_update_email, if: :saved_change_to_email?
# Note that because a commit may cause multiple changes
# which are not fully tracked by ActiveRecord::Dirty,
# we must resort to using a ActiveRecord::Concern which accumulates
# changes from a commit (app/models/concerns/track_saved_changes.rb)
# See https://github.com/ccmcbeck/after-commit
after_update_commit :mailbluster_update_email, if: ->(obj){ obj.saved_changes.key? 'email' }
# add scope
scope :comment_notifiable, ->(conference) {joins(:roles).where('roles.name IN (?)', [:organizer, :cfp]).where('roles.resource_type = ? AND roles.resource_id = ?', 'Conference', conference.id)}
@ -386,7 +391,7 @@ class User < ApplicationRecord
def mailbluster_update_email
# FIXME: May fail if multiple saves occur in one commit
MailblusterEditLeadJob.perform_later(self, old_email: email_before_last_save)
MailblusterEditLeadJob.perform_later(self, old_email: self.saved_changes['email'][0])
end
def touch_events