From e9ba87a49c00b373db4bc5631b3808c5f7e3f1c7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Geuken?= Date: Fri, 17 Apr 2015 10:15:38 +0200 Subject: [PATCH] get_progress: cleanup case statement --- app/models/target.rb | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/app/models/target.rb b/app/models/target.rb index e4e07591..341e75fe 100644 --- a/app/models/target.rb +++ b/app/models/target.rb @@ -28,16 +28,17 @@ class Target < ActiveRecord::Base # ====Returns # * +String+ -> progress in percent def get_progress - case unit + numerator = case unit when Target.units[:submissions] - numerator = conference.events.where('created_at < ?', due_date).count + conference.events.where('created_at < ?', due_date).count when Target.units[:registrations] - numerator = conference.registrations.where('created_at < ?', due_date).count + conference.registrations.where('created_at < ?', due_date).count when Target.units[:program_minutes] - numerator = conference.current_program_minutes + conference.current_program_minutes else - numerator = 0 + 0 end + (100 * numerator / target_count).to_s end