Fix the test failures

spec/controllers/admin/tracks_controller_spec.rb

@@ -22,8 +22,8 @@ describe Admin::TracksController do
 
     it 'assigns @tracks with the correct values' do
       expect(assigns(:tracks).length).to eq 2
-      expect(assigns(:tracks).include?(track)).to eq true
-      expect(assigns(:tracks).include?(self_organized_track)).to eq true
+      expect(assigns(:tracks).include?(track)).to be true
+      expect(assigns(:tracks).include?(self_organized_track)).to be true
     end
 
     it 'renders the index template' do
@@ -52,7 +52,7 @@ describe Admin::TracksController do
 
     it 'assigns a new track with the correct conference' do
       expect(assigns(:track)).to be_a Track
-      expect(assigns(:track).new_record?).to eq true
+      expect(assigns(:track).new_record?).to be true
       expect(assigns(:track).program_id).to eq conference.program.id
     end
 
@@ -69,7 +69,7 @@ describe Admin::TracksController do
 
       it 'assigns a new track with the correct conference' do
         expect(assigns(:track)).to be_a Track
-        expect(assigns(:track).new_record?).to eq false
+        expect(assigns(:track).new_record?).to be false
         expect(assigns(:track).program_id).to eq conference.program.id
       end
 
@@ -87,7 +87,7 @@ describe Admin::TracksController do
 
       it 'the new track has the correct attributes' do
         expect(assigns(:track).state).to eq 'confirmed'
-        expect(assigns(:track).cfp_active).to eq true
+        expect(assigns(:track).cfp_active).to be true
       end
     end
 
@@ -99,7 +99,7 @@ describe Admin::TracksController do
 
       it 'assigns a new track with the correct conference' do
         expect(assigns(:track)).to be_a Track
-        expect(assigns(:track).new_record?).to eq true
+        expect(assigns(:track).new_record?).to be true
         expect(assigns(:track).program_id).to eq conference.program.id
       end
 
@@ -112,7 +112,7 @@ describe Admin::TracksController do
       end
 
       it 'does not create a new track' do
-        expect(conference.program.tracks.find_by(short_name: 'my_track')).to eq nil
+        expect(conference.program.tracks.find_by(short_name: 'my_track')).to be_nil
       end
     end
   end
@@ -199,7 +199,7 @@ describe Admin::TracksController do
       end
 
       it 'deletes the track' do
-        expect(Track.find_by(id: track)).to eq nil
+        expect(Track.find_by(id: track)).to be_nil
       end
     end
 
@@ -249,7 +249,7 @@ describe Admin::TracksController do
         end
 
         it 'becomes true' do
-          expect(self_organized_track.cfp_active).to eq true
+          expect(self_organized_track.cfp_active).to be true
         end
       end
 
@@ -269,7 +269,7 @@ describe Admin::TracksController do
         end
 
         it 'stays false' do
-          expect(self_organized_track.cfp_active).to eq false
+          expect(self_organized_track.cfp_active).to be false
         end
       end
     end
@@ -295,7 +295,7 @@ describe Admin::TracksController do
         end
 
         it 'becomes false' do
-          expect(self_organized_track.cfp_active).to eq false
+          expect(self_organized_track.cfp_active).to be false
         end
       end
 
@@ -315,7 +315,7 @@ describe Admin::TracksController do
         end
 
         it 'stays true' do
-          expect(self_organized_track.cfp_active).to eq true
+          expect(self_organized_track.cfp_active).to be true
         end
       end
     end

spec/controllers/admin/users_controller_spec.rb

@@ -25,12 +25,12 @@ describe Admin::UsersController do
       user_to_confirm = create(:user, email: 'unconfirmed_user@osem.io', confirmed_at: nil)
       patch :toggle_confirmation, params: { id: user_to_confirm.id, user: { to_confirm: 'true' } }
       user_to_confirm.reload
-      expect(user_to_confirm.confirmed?).to eq true
+      expect(user_to_confirm.confirmed?).to be true
     end
     it 'undo confirmation of user' do
       patch :toggle_confirmation, params: { id: user.id, user: { to_confirm: 'false' } }
       user.reload
-      expect(user.confirmed?).to eq false
+      expect(user.confirmed?).to be false
     end
   end
   describe 'PATCH #update' do

spec/controllers/admin/versions_controller_spec.rb

@@ -31,7 +31,7 @@ describe Admin::VersionsController do
         expect(flash[:error]).to match('The item is already in the state that you are trying to revert it back to')
       end
 
-      it 'reverting deletion of object  creates it again' do
+      it 'reverting deletion of object creates it again' do
         event_type = conference.program.event_types.first
         event_type.destroy
         event_types_count = conference.program.event_types.count
@@ -41,7 +41,7 @@ describe Admin::VersionsController do
         expect(conference.program.event_types.count).to eq(event_types_count + 1)
       end
 
-      it 'reverting creation of object deletes it ' do
+      it 'reverting creation of object deletes it' do
         lodging = create(:lodging, conference: conference)
         get :revert_object, params: { id: lodging.versions.last.id }
         expect(lodging.versions.last.event).to eq 'destroy'
@@ -131,8 +131,8 @@ describe Admin::VersionsController do
           sign_in @user
           get :index, params: { conference_id: conference.short_title }
 
-          expect(assigns(:versions).include?(@version_cfp)).to eq true
-          expect(assigns(:versions).include?(@version_organizer)).to eq false
+          expect(assigns(:versions).include?(@version_cfp)).to be true
+          expect(assigns(:versions).include?(@version_organizer)).to be false
         end
 
         it 'when user has role info_desk' do
@@ -140,9 +140,9 @@ describe Admin::VersionsController do
           sign_in @user
           get :index, params: { conference_id: conference.short_title }
 
-          expect(assigns(:versions).include?(@version_info_desk)).to eq true
-          expect(assigns(:versions).include?(@version_organizer)).to eq false
-          expect(assigns(:versions).include?(@version_cfp)).to eq false
+          expect(assigns(:versions).include?(@version_info_desk)).to be true
+          expect(assigns(:versions).include?(@version_organizer)).to be false
+          expect(assigns(:versions).include?(@version_cfp)).to be false
         end
 
         it 'when user has role organizer' do
@@ -150,9 +150,9 @@ describe Admin::VersionsController do
           sign_in @user
           get :index, params: { conference_id: conference.short_title }
 
-          expect(assigns(:versions).include?(@version_organizer)).to eq true
-          expect(assigns(:versions).include?(@version_cfp)).to eq true
-          expect(assigns(:versions).include?(@version_info_desk)).to eq true
+          expect(assigns(:versions).include?(@version_organizer)).to be true
+          expect(assigns(:versions).include?(@version_cfp)).to be true
+          expect(assigns(:versions).include?(@version_info_desk)).to be true
         end
       end
     end