Implement role authorization

spec/models/ability_spec.rb

@@ -1,39 +1,163 @@
 require 'spec_helper'
-require "cancan/matchers"
+require 'cancan/matchers'
 
-describe "User" do
-  describe "abilities" do
+describe 'User' do
+  describe 'Abilities' do
     subject(:ability){ Ability.new(user) }
+    let!(:first_user) { create(:user) } # automatically becomes admin
     let(:user){ nil }
+    let(:conference_not_public) { create(:conference, make_conference_public: false) }
+    let(:conference_public) { create(:conference, make_conference_public: true)}
+    let(:event_confirmed) { create(:event, state: 'confirmed') }
+    let(:someevent) { create(:event) }
 
-    context "when is an admin" do
-      let!(:user) { create(:admin) }
+    context 'when user is a guest' do  # Test abilities for guest users
 
-      it{ should be_able_to(:manage, Event.new) }
+      it{ should be_able_to(:show, conference_public)}
+      it{ should_not be_able_to(:show, conference_not_public)}
+
+      it{ should be_able_to(:show, event_confirmed)}
+      it{ should_not be_able_to(:show, someevent)}
+
+      it{ should be_able_to(:index, :schedule)}
+
+      it{ should_not be_able_to(:create, Event)}
+      it{ should_not be_able_to(:manage, Event)}
+      it{ should_not be_able_to(:manage, Conference)}
+      it{ should_not be_able_to(:manage, :any)}
     end
 
-    context "when is an participant" do
-      let(:user) { build(:participant) }
+    context 'when user is a Signed In User' do # Test abilities for signed in users (without any role)
+      let(:user) { create(:participant) }
+      let(:registration1) { create(:registration, conference: conference_public, user: user) }
+      let(:registration2) { create(:registration, conference: conference_not_public, user: user) }
 
+      it{ should be_able_to(:create, Event) }
+      it{ should be_able_to(:index, Event) }
       it{ should_not be_able_to(:manage, Event.new) }
-      it{ should be_able_to(:create, Event.new) }
-      it{ should be_able_to(:read, Event.new) }
+      it{ should be_able_to(:show, event_confirmed) }
+
+      it{ should be_able_to(:manage, registration1) }
+      it{ should be_able_to(:manage, registration2) }
+
+      it{ should be_able_to(:show, conference_public)}
+      it{ should_not be_able_to(:show, conference_not_public)}
+      it{ should_not be_able_to(:manage, Conference) }
     end
 
-    context "when is an event owner" do
+    context 'user #is_admin?' do
+      let(:user) { create(:admin) }
+      it{ should be_able_to(:manage, User) }
+      it{ should be_able_to(:create, Conference) }
+    end
+
+    context 'signed in users can manage their events' do
       let(:user) { create(:participant) }
       let(:user2) { create(:participant) }
       let(:myevent) { create(:event, users: [user]) }
       let(:someevent) { create(:event, users: [user2]) }
+      let(:commercial_myevent) { create(:commercial, commercialable: myevent) }
+      let(:commercial_someevent) { create(:commercial, commercialable: someevent) }
 
       # Users are able to update and destroy their own events
       it{ should be_able_to(:update, myevent) }
       it{ should be_able_to(:destroy, myevent) }
+      it{ should be_able_to(:manage, myevent) }
+      it{ should be_able_to(:create, myevent.commercials.new) }
+      it{ should be_able_to(:manage, commercial_myevent) }
 
       # Users are not able to update and destroy other users events
       it{ should_not be_able_to(:update, someevent) }
       it{ should_not be_able_to(:destroy, someevent) }
+      it{ should_not be_able_to(:manage, someevent) }
+      it{ should_not be_able_to(:manage, commercial_someevent) }
     end
 
+    context 'when user is an organizer' do
+      let!(:conference1) { create(:conference) }
+      let!(:conference2) { create(:conference) }
+      let(:role) { create(:organizer_role, resource: conference1) }
+      let(:user) { create(:user, role_ids: [role.id]) }
+      let(:someuser) { create(:user) }
+      let(:registration1) { create(:registration, user: someuser, conference_id: conference1.id) }
+
+      it{ should be_able_to(:manage, conference1) }
+      it{ should_not be_able_to(:manage, conference2) }
+      it{ should be_able_to(:manage, registration1) }
+      it{ should be_able_to(:create, Registration) }
+    end
+
+    context 'when user is part of cfp' do
+      let!(:conference1) { create(:conference) }
+      let!(:conference2) { create(:conference) }
+      let(:role) { create(:role, name: 'cfp', resource: conference1) }
+      let(:user) { create(:user, role_ids: role.id) }
+      let(:event) { create(:event, conference_id: conference1.id) }
+      let(:someevent) { create(:event, conference_id: conference2.id) }
+      let(:cfp) { create(:call_for_papers, conference: conference1) }
+
+      it{ should_not be_able_to(:manage, conference1) }
+      it{ should_not be_able_to(:manage, conference2) }
+      it{ should be_able_to(:index, conference1) }
+      it{ should be_able_to(:show, conference1) }
+
+      it{ should be_able_to(:manage, event) }
+      it{ should_not be_able_to(:manage, someevent) }
+
+      it{ should be_able_to(:manage, cfp) }
+      it{ should be_able_to(:manage, create(:event_type, conference: conference1)) }
+    end
+
+    context 'when user has multiple roles' do
+      let!(:conference1) { create(:conference) } # user is organizer
+      let!(:conference2) { create(:conference) } # user is cfp
+      let!(:conference3) { create(:conference) } # user is info_desk
+      let!(:conference4) { create(:conference) } # user is volunteer coordinator
+      let!(:conference5) { create(:conference, make_conference_public: true) } # user has no role
+      let!(:conference6) { create(:conference, make_conference_public: false) } # user has no role
+      let(:role_organizer) { create(:role, name: 'organizer', resource: conference1) }
+      let(:role_cfp) { create(:role, name: 'cfp', resource: conference2) }
+      let(:role_info_desk) { create(:role, name: 'info_desk', resource: conference3) }
+      let(:role_volunteer_coordinator) { create(:role, name: 'volunteer_coordinator', resource: conference4) }
+      let(:user) { create(:user, role_ids: [role_cfp.id, role_organizer.id, role_cfp.id, role_info_desk.id, role_volunteer_coordinator.id]) }
+      let(:admin) { create(:admin) }
+
+      it{ should be_able_to(:manage, conference1) }
+      it{ should_not be_able_to(:update, conference2) }
+      it{ should_not be_able_to(:update, conference3) }
+      it{ should_not be_able_to(:update, conference4) }
+      it{ should_not be_able_to(:update, conference5) }
+
+      it{ should be_able_to(:show, conference1) }
+      it{ should be_able_to(:show, conference2) }
+      it{ should be_able_to(:show, conference3) }
+      it{ should be_able_to(:show, conference4) }
+      it{ should be_able_to(:show, conference5) }
+      it{ should be_able_to(:show, conference6) }
+
+      it{ should be_able_to(:manage, conference1.venue) }
+      it{ should_not be_able_to(:manage, conference2.venue) }
+      it{ should_not be_able_to(:manage, conference3.venue) }
+      it{ should_not be_able_to(:manage, conference4.venue) }
+      it{ should_not be_able_to(:manage, conference5.venue) }
+
+      it{ should be_able_to(:manage, conference1.registrations.new) }
+      it{ should_not be_able_to(:manage, conference2.registrations.new) }
+      it{ should be_able_to(:manage, conference3.registrations.new) }
+      it{ should_not be_able_to(:manage, conference4.registrations.new) }
+      it{ should_not be_able_to(:manage, conference5.registrations.new) }
+
+      it{ should be_able_to(:manage, conference1.events.new) }
+      it{ should be_able_to(:manage, conference2.events.new) }
+      it{ should_not be_able_to(:manage, conference3.events.new) }
+      it{ should_not be_able_to(:manage, conference4.events.new) }
+      it{ should_not be_able_to(:manage, conference5.events.new) }
+
+      it{ should be_able_to(:manage, Question.new(conference_id: conference1.id)) }
+      it{ should_not be_able_to(:manage, Question.new(conference_id: conference2.id)) }
+      it{ should be_able_to(:manage, Question.new(conference_id: conference3.id)) }
+      it{ should_not be_able_to(:manage, Question.new(conference_id: conference4.id)) }
+      it{ should_not be_able_to(:manage, Question.new(conference_id: conference5.id)) }
+    end
   end
 end