Replace flash helper with "within"

So we can't forget to find "#flash" on the page ever again...
This commit is contained in:
Henne Vogelsang 2025-08-06 13:04:53 +02:00
parent bc1a21ae46
commit df0b9ab356
No known key found for this signature in database
GPG key ID: 97DDB66BDAF8D4D6
29 changed files with 116 additions and 180 deletions

View file

@ -15,12 +15,9 @@ feature Contact do
visit edit_admin_conference_contact_path(conference.short_title)
fill_in 'contact_' + field_name, with: field_value
click_button 'Update Contact'
page.find('#flash')
expect(flash)
.to eq('Contact details were successfully updated.')
contact.reload
within('#flash') { expect(page).to have_text('Contact details were successfully updated.') }
expect(contact.send(field_name)).to eq(field_value)
expect(contact.reload.send(field_name)).to eq(field_value)
expect(Contact.count).to eq(expected_count)
end
end