Replace flash helper with "within"

So we can't forget to find "#flash" on the page ever again...
This commit is contained in:
Henne Vogelsang 2025-08-06 13:04:53 +02:00
parent bc1a21ae46
commit df0b9ab356
No known key found for this signature in database
GPG key ID: 97DDB66BDAF8D4D6
29 changed files with 116 additions and 180 deletions

View file

@ -24,9 +24,7 @@ feature Conference do
fill_in 'conference_end_date', with: (today + 7).strftime('%Y/%m/%d')
click_button 'Create Conference'
page.find('#flash')
expect(flash)
.to eq('Conference was successfully created.')
within('#flash') { expect(page).to have_text('Conference was successfully created.') }
expect(Conference.count).to eq(expected_count)
user.reload
expect(user.has_cached_role? :organizer, Conference.last).to be(true)
@ -51,8 +49,7 @@ feature Conference do
click_button 'Update Conference'
end
page.find('#flash')
expect(flash).to eq('Conference was successfully updated.')
within('#flash') { expect(page).to have_text('Conference was successfully updated.') }
conference.reload
expect(conference.title).to eq('New Con')