gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replace flash helper with "within"

Browse source 
So we can't forget to find "#flash" on the page ever again...
This commit is contained in:
Henne Vogelsang 2025-08-06 13:04:53 +02:00
parent bc1a21ae46
commit df0b9ab356
No known key found for this signature in database
GPG key ID: 97DDB66BDAF8D4D6
29 changed files with 116 additions and 180 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spec/features/commercials_spec.rb
View file

@ -26,8 +26,7 @@ feature Commercial do
page.execute_script("$('#commercial_submit_action').prop('disabled', false)")
click_button 'Create Commercial'
page.find('#flash')
expect(flash).to eq('Commercial was successfully created.')
within('#flash') { expect(page).to have_text('Commercial was successfully created.') }
end
scenario 'updates a commercial of an event', feature: true, js: true do
@ -42,8 +41,7 @@ feature Commercial do
page.execute_script("$('#commercial_submit_action').prop('disabled', false)")
click_button 'Update Commercial'
end
page.find('#flash')
expect(flash).to eq('Commercial was successfully updated.')
within('#flash') { expect(page).to have_text('Commercial was successfully updated.') }
expect(event.commercials.count).to eq(1)
commercial.reload
expect(commercial.url).to eq('https://www.youtube.com/watch?v=M9bq_alk-sw')
@ -58,8 +56,7 @@ feature Commercial do
page.accept_alert do
click_link 'Delete'
end
page.find('#flash')
expect(flash).to eq('Commercial was successfully destroyed.')
within('#flash') { expect(page).to have_text('Commercial was successfully destroyed.') }
expect(event.commercials.count).to eq(0)
end
end