From db59fa096cb5882d1250b9f70c28d8dd8db12a9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Geuken?= Date: Fri, 17 Apr 2015 10:09:43 +0200 Subject: [PATCH] get_progress: Turn if condition into switch --- app/models/target.rb | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/app/models/target.rb b/app/models/target.rb index c140dc4d..1c2ff530 100644 --- a/app/models/target.rb +++ b/app/models/target.rb @@ -29,11 +29,12 @@ class Target < ActiveRecord::Base # * +String+ -> progress in percent def get_progress numerator = 0 - if unit == Target.units[:submissions] + case unit + when Target.units[:submissions] numerator = conference.events.where('created_at < ?', due_date).count - elsif unit == Target.units[:registrations] + when Target.units[:registrations] numerator = conference.registrations.where('created_at < ?', due_date).count - elsif unit == Target.units[:program_minutes] + when Target.units[:program_minutes] numerator = conference.current_program_minutes end (100 * numerator / target_count).to_s