diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 1614d080..1f07e324 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-05-08 15:38:24 UTC using RuboCop version 1.50.2. +# on 2023-05-08 16:19:23 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -604,22 +604,12 @@ RSpec/AnyInstance: - 'spec/controllers/proposals_controller_spec.rb' - 'spec/controllers/tracks_controller_spec.rb' -# Offense count: 350 +# Offense count: 5 # This cop supports safe autocorrection (--autocorrect). -RSpec/Capybara/CurrentPathExpectation: +RSpec/BeEmpty: Exclude: - - 'spec/features/base_controller_spec.rb' - - 'spec/features/cfp_ability_spec.rb' - - 'spec/features/conference_registration_spec.rb' - - 'spec/features/info_desk_ability_spec.rb' - - 'spec/features/organization_admin_ability_spec.rb' - - 'spec/features/organizer_ability_spec.rb' - - 'spec/features/proposals_spec.rb' - - 'spec/features/registration_periods_spec.rb' - - 'spec/features/splashpage_spec.rb' - - 'spec/features/ticket_purchases_spec.rb' - - 'spec/features/track_organizer_ability_spec.rb' - - 'spec/features/user_ability_spec.rb' + - 'spec/controllers/conference_registration_controller_spec.rb' + - 'spec/models/conference_spec.rb' # Offense count: 161 # This cop supports safe autocorrection (--autocorrect). @@ -628,7 +618,7 @@ RSpec/Capybara/FeatureMethods: Enabled: false # Offense count: 318 -# Configuration parameters: Prefixes. +# Configuration parameters: Prefixes, AllowedPatterns. # Prefixes: when, with, without RSpec/ContextWording: Enabled: false @@ -685,8 +675,9 @@ RSpec/EmptyLineAfterFinalLet: - 'spec/models/payment_spec.rb' - 'spec/models/ticket_spec.rb' -# Offense count: 17 +# Offense count: 16 # This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowConsecutiveOneLiners. RSpec/EmptyLineAfterHook: Exclude: - 'spec/controllers/admin/booths_controller_spec.rb' @@ -720,7 +711,8 @@ RSpec/ExampleLength: # Offense count: 15 # This cop supports safe autocorrection (--autocorrect). -# Configuration parameters: CustomTransform, IgnoredWords. +# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples. +# DisallowedExamples: works RSpec/ExampleWording: Exclude: - 'spec/controllers/admin/organizations_controller_spec.rb' @@ -754,6 +746,19 @@ RSpec/ExpectChange: - 'spec/models/event_spec.rb' - 'spec/models/user_spec.rb' +# Offense count: 12 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: require_parentheses, omit_parentheses +RSpec/FactoryBot/ConsistentParenthesesStyle: + Exclude: + - 'spec/controllers/proposals_controller_spec.rb' + - 'spec/features/proposals_spec.rb' + - 'spec/features/roles_spec.rb' + - 'spec/features/surveys_spec.rb' + - 'spec/models/resource_spec.rb' + - 'spec/models/ticket_spec.rb' + # Offense count: 9 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. # Include: **/*_spec*rb*, **/spec/**/* @@ -805,7 +810,7 @@ RSpec/ImplicitExpect: # Offense count: 39 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. -# SupportedStyles: single_line_only, single_statement_only, disallow +# SupportedStyles: single_line_only, single_statement_only, disallow, require_implicit RSpec/ImplicitSubject: Exclude: - 'spec/ability/ability_spec.rb' @@ -819,6 +824,18 @@ RSpec/ImplicitSubject: - 'spec/models/ticket_purchase_spec.rb' - 'spec/models/ticket_spec.rb' +# Offense count: 19 +# Configuration parameters: Max. +RSpec/IndexedLet: + Exclude: + - 'spec/controllers/admin/reports_controller_spec.rb' + - 'spec/controllers/admin/roles_controller_spec.rb' + - 'spec/features/voting_spec.rb' + - 'spec/models/conference_spec.rb' + - 'spec/models/ticket_purchase_spec.rb' + - 'spec/models/ticket_spec.rb' + - 'spec/models/user_spec.rb' + # Offense count: 321 # Configuration parameters: AssignmentOnly. RSpec/InstanceVariable: @@ -851,6 +868,14 @@ RSpec/LeadingSubject: RSpec/LetSetup: Enabled: false +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +RSpec/MatchArray: + Exclude: + - 'spec/controllers/admin/conferences_controller_spec.rb' + - 'spec/controllers/admin/users_controller_spec.rb' + - 'spec/models/conference_spec.rb' + # Offense count: 12 # Configuration parameters: . # SupportedStyles: have_received, receive @@ -872,7 +897,8 @@ RSpec/MultipleMemoizedHelpers: Max: 32 # Offense count: 396 -# Configuration parameters: IgnoreSharedExamples. +# Configuration parameters: EnforcedStyle, IgnoreSharedExamples. +# SupportedStyles: always, named_only RSpec/NamedSubject: Exclude: - 'spec/models/conference_spec.rb' @@ -881,9 +907,19 @@ RSpec/NamedSubject: - 'spec/models/track_spec.rb' # Offense count: 208 +# Configuration parameters: AllowedGroups. RSpec/NestedGroups: Max: 7 +# Offense count: 3 +# Configuration parameters: AllowedPatterns. +# AllowedPatterns: ^expect_, ^assert_ +RSpec/NoExpectationExample: + Exclude: + - 'spec/controllers/admin/conferences_controller_spec.rb' + - 'spec/controllers/admin/registration_periods_controller_spec.rb' + - 'spec/features/voting_spec.rb' + # Offense count: 83 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. @@ -903,6 +939,29 @@ RSpec/Rails/AvoidSetupHook: - 'spec/features/versions_spec.rb' - 'spec/helpers/events_helper_spec.rb' +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +RSpec/Rails/HaveHttpStatus: + Exclude: + - 'spec/controllers/admin/event_schedules_controller_spec.rb' + +# Offense count: 11 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Inferences. +RSpec/Rails/InferredSpecType: + Exclude: + - 'spec/controllers/admin/comments_controller_spec.rb' + - 'spec/controllers/admin/programs_controller_spec.rb' + - 'spec/controllers/application_controller_spec.rb' + - 'spec/controllers/conference_registration_controller_spec.rb' + - 'spec/helpers/application_helper_spec.rb' + - 'spec/helpers/conference_helper_spec.rb' + - 'spec/helpers/date_time_helper_spec.rb' + - 'spec/helpers/events_helper_spec.rb' + - 'spec/helpers/format_helper_spec.rb' + - 'spec/helpers/users_helper_spec.rb' + - 'spec/routing/routing_spec.rb' + # Offense count: 4 RSpec/RepeatedDescription: Exclude: @@ -934,10 +993,17 @@ RSpec/ScatteredLet: - 'spec/models/payment_spec.rb' # Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). RSpec/ScatteredSetup: Exclude: - 'spec/models/payment_spec.rb' +# Offense count: 32 +# This cop supports safe autocorrection (--autocorrect). +RSpec/SortMetadata: + Exclude: + - 'spec/features/versions_spec.rb' + # Offense count: 9 RSpec/StubbedMock: Exclude: diff --git a/Gemfile.lock b/Gemfile.lock index 9920935a..ee00feb4 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -513,8 +513,9 @@ GEM activesupport (>= 4.2.0) rack (>= 1.1) rubocop (>= 1.33.0, < 2.0) - rubocop-rspec (2.11.1) - rubocop (~> 1.19) + rubocop-rspec (2.20.0) + rubocop (~> 1.33) + rubocop-capybara (~> 2.17) ruby-oembed (0.16.1) ruby-openid (2.9.2) ruby-progressbar (1.13.0)