gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

removed unnecessary comments and fixed grammatical errors

Browse source
This commit is contained in:
shlok007 2017-06-30 09:27:19 +05:30
parent 651abcab87
commit d59a036cf1
5 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
spec/features/cfp_ability_spec.rb
View file

@ -3,8 +3,7 @@ require 'spec_helper'
feature 'Has correct abilities' do feature 'Has correct abilities' do
let(:organization) { create(:organization) } let(:organization) { create(:organization) }
# It is necessary to use bang version of let to build roles before user let(:conference) { create(:full_conference, organization: organization) }
let(:conference) { create(:full_conference, organization: organization) } # user is cfp
let(:role_cfp) { Role.find_by(name: 'cfp', resource: conference) } let(:role_cfp) { Role.find_by(name: 'cfp', resource: conference) }
let(:user_cfp) { create(:user, role_ids: [role_cfp.id]) } let(:user_cfp) { create(:user, role_ids: [role_cfp.id]) }

5
spec/features/info_desk_ability_spec.rb
View file

@ -3,11 +3,8 @@ require 'spec_helper'
feature 'Has correct abilities' do feature 'Has correct abilities' do
let(:organization) { create(:organization) } let(:organization) { create(:organization) }
# It is necessary to use bang version of let to build roles before user let(:conference) { create(:full_conference, organization: organization) }
let(:conference) { create(:full_conference, organization: organization) } # user is info_desk
let(:role_info_desk) { Role.find_by(name: 'info_desk', resource: conference) } let(:role_info_desk) { Role.find_by(name: 'info_desk', resource: conference) }
let(:user_info_desk) { create(:user, role_ids: [role_info_desk.id]) } let(:user_info_desk) { create(:user, role_ids: [role_info_desk.id]) }
context 'when user is info desk' do context 'when user is info desk' do

2
spec/features/organization_admin_ability_spec.rb
View file

@ -2,7 +2,7 @@ require 'spec_helper'
feature 'Has correct abilities' do feature 'Has correct abilities' do
let(:organization) { create(:organization) } let(:organization) { create(:organization) }
let(:conference) { create(:full_conference, organization: organization) } # user is organization_admin let(:conference) { create(:full_conference, organization: organization) }
let(:role_organization_admin) { Role.find_by(name: 'organization_admin', resource: organization) } let(:role_organization_admin) { Role.find_by(name: 'organization_admin', resource: organization) }
let(:user_organization_admin) { create(:user, role_ids: [role_organization_admin.id]) } let(:user_organization_admin) { create(:user, role_ids: [role_organization_admin.id]) }

6
spec/features/organization_spec.rb
View file

@ -6,7 +6,7 @@ feature Organization do
let(:organization_admin) { create(:user, role_ids: [organization_admin_role.id]) } let(:organization_admin) { create(:user, role_ids: [organization_admin_role.id]) }
let(:admin_user) { create(:admin) } let(:admin_user) { create(:admin) }
shared_examples 'successfully updates a organization' do shared_examples 'successfully updates an organization' do
scenario 'updates a exsisting organization', feature: true, js: true do scenario 'updates a exsisting organization', feature: true, js: true do
visit edit_admin_organization_path(organization) visit edit_admin_organization_path(organization)
fill_in 'organization_name', with: 'changed name' fill_in 'organization_name', with: 'changed name'
@ -33,7 +33,7 @@ feature Organization do
expect(Organization.last.name).to eq('Organization name') expect(Organization.last.name).to eq('Organization name')
end end
it_behaves_like 'successfully updates a organization' it_behaves_like 'successfully updates an organization'
end end
context 'signed in as organization admin' do context 'signed in as organization admin' do
@ -46,6 +46,6 @@ feature Organization do
expect(flash).to eq('You are not authorized to access this page.') expect(flash).to eq('You are not authorized to access this page.')
end end
it_behaves_like 'successfully updates a organization' it_behaves_like 'successfully updates an organization'
end end
end end

3
spec/features/organizer_ability_spec.rb
View file

@ -3,8 +3,7 @@ require 'spec_helper'
feature 'Has correct abilities' do feature 'Has correct abilities' do
let(:organization) { create(:organization) } let(:organization) { create(:organization) }
# It is necessary to use bang version of let to build roles before user let(:conference) { create(:full_conference, organization: organization) }
let(:conference) { create(:full_conference, organization: organization) } # user is organizer
let(:other_conference) { create(:conference, organization: organization) } # user is organizer, venue is not set by default let(:other_conference) { create(:conference, organization: organization) } # user is organizer, venue is not set by default
let(:role_organizer_conf) { Role.find_by(name: 'organizer', resource: conference) } let(:role_organizer_conf) { Role.find_by(name: 'organizer', resource: conference) }
let(:role_organizer_other_conf) { Role.find_by(name: 'organizer', resource: other_conference) } let(:role_organizer_other_conf) { Role.find_by(name: 'organizer', resource: other_conference) }