gunghogeoduck/osem-fcy
1
0
Fork 0
mirror of https://github.com/openSUSE/osem.git synced 2026-08-13 19:54:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use keyword arguments in tests

Browse source 
Raisl 5.1 removes support for non-keyword arguments in `#process`,
`#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head` for the
`ActionDispatch::IntegrationTest` and `ActionController::TestCase`
classes. This means we have to add `params` everywhere in the controller
tests.
This commit is contained in:
Ana María Martínez Gómez 2019-05-13 17:42:09 +02:00
parent b8013661a2
commit d1180e2767
No known key found for this signature in database
GPG key ID: EACB9B4BC80C0347
35 changed files with 975 additions and 364 deletions
Download patch file Download diff file Expand all files Collapse all files

12
spec/controllers/admin/users_controller_spec.rb
View file

@ -23,12 +23,12 @@ describe Admin::UsersController do
describe 'PATCH #toggle_confirmation' do
it 'confirms user' do
user_to_confirm = create(:user, email: 'unconfirmed_user@osem.io', confirmed_at: nil)
patch :toggle_confirmation, id: user_to_confirm.id, user: { to_confirm: 'true' }
patch :toggle_confirmation, params: { id: user_to_confirm.id, user: { to_confirm: 'true' } }
user_to_confirm.reload
expect(user_to_confirm.confirmed?).to eq true
end
it 'undo confirmation of user' do
patch :toggle_confirmation, id: user.id, user: { to_confirm: 'false' }
patch :toggle_confirmation, params: { id: user.id, user: { to_confirm: 'false' } }
user.reload
expect(user.confirmed?).to eq false
end
@ -36,7 +36,7 @@ describe Admin::UsersController do
describe 'PATCH #update' do
context 'valid attributes' do
before :each do
patch :update, id: user.id, user: { name: 'new name', email: 'new_email@osem.io' }
patch :update, params: { id: user.id, user: { name: 'new name', email: 'new_email@osem.io' } }
end
it 'locates requested @user' do
@ -66,7 +66,7 @@ describe Admin::UsersController do
describe 'POST #create' do
context 'saves successfuly' do
before do
post :create, user: attributes_for(:user)
post :create, params: { user: attributes_for(:user) }
end
it 'redirects to admin users index path' do
@ -85,7 +85,7 @@ describe Admin::UsersController do
context 'save fails' do
before do
allow_any_instance_of(User).to receive(:save).and_return(false)
post :create, user: attributes_for(:user)
post :create, params: { user: attributes_for(:user) }
end
it 'renders new template' do
@ -98,7 +98,7 @@ describe Admin::UsersController do
it 'does not create new user' do
expect do
post :create, user: attributes_for(:user)
post :create, params: { user: attributes_for(:user) }
end.not_to change{ Event.count }
end
end