Merge pull request #3252 from openSUSE/depfu/update/rubocop-rspec-2.23.0

Update rubocop-rspec 2.20.0 → 2.23.0 (minor)

.rubocop.yml

@@ -3,6 +3,7 @@ require:
   - rubocop-rails
   - rubocop-capybara
   - rubocop-performance
+  - rubocop-factory_bot
 
 inherit_from: .rubocop_todo.yml
 

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-05-08 16:19:23 UTC using RuboCop version 1.50.2.
+# on 2024-03-04 16:04:49 UTC using RuboCop version 1.61.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,6 +14,12 @@ Bundler/OrderedGems:
   Exclude:
     - 'Gemfile'
 
+# Offense count: 161
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: link_or_button, strict
+Capybara/ClickLinkOrButtonStyle:
+  Enabled: false
+
 # Offense count: 350
 # This cop supports safe autocorrection (--autocorrect).
 Capybara/CurrentPathExpectation:
@@ -31,13 +37,27 @@ Capybara/CurrentPathExpectation:
     - 'spec/features/track_organizer_ability_spec.rb'
     - 'spec/features/user_ability_spec.rb'
 
-# Offense count: 1
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_no, not_to
 Capybara/NegationMatcher:
   Exclude:
-    - 'spec/features/versions_spec.rb'
+    - 'spec/features/code_of_conduct_spec.rb'
+
+# Offense count: 14
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: DefaultSelector.
+Capybara/RSpec/HaveSelector:
+  Exclude:
+    - 'spec/features/cfp_ability_spec.rb'
+    - 'spec/features/info_desk_ability_spec.rb'
+    - 'spec/features/organization_admin_ability_spec.rb'
+    - 'spec/features/organizer_ability_spec.rb'
+    - 'spec/features/proposals_spec.rb'
+    - 'spec/features/sponsor_spec.rb'
+    - 'spec/features/track_organizer_ability_spec.rb'
+    - 'spec/features/voting_spec.rb'
 
 # Offense count: 82
 # This cop supports safe autocorrection (--autocorrect).
@@ -49,6 +69,40 @@ Capybara/SpecificMatcher:
   Exclude:
     - 'spec/features/sponsor_spec.rb'
 
+# Offense count: 7
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle, NonImplicitAssociationMethodNames.
+# SupportedStyles: explicit, implicit
+FactoryBot/AssociationStyle:
+  Exclude:
+    - 'spec/factories/comments.rb'
+    - 'spec/factories/commercials.rb'
+    - 'spec/factories/conferences.rb'
+    - 'spec/factories/surveys.rb'
+    - 'spec/factories/tracks.rb'
+
+# Offense count: 12
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Include, EnforcedStyle, ExplicitOnly.
+# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
+# SupportedStyles: require_parentheses, omit_parentheses
+FactoryBot/ConsistentParenthesesStyle:
+  Exclude:
+    - 'spec/controllers/proposals_controller_spec.rb'
+    - 'spec/features/proposals_spec.rb'
+    - 'spec/features/roles_spec.rb'
+    - 'spec/features/surveys_spec.rb'
+    - 'spec/models/resource_spec.rb'
+    - 'spec/models/ticket_spec.rb'
+
+# Offense count: 3
+# Configuration parameters: Include.
+# Include: **/*_spec.rb, **/spec/**/*, **/test/**/*, **/features/support/factories/**/*.rb
+FactoryBot/FactoryAssociationWithStrategy:
+  Exclude:
+    - 'spec/factories/booths.rb'
+    - 'spec/factories/users.rb'
+
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: IndentationWidth.
@@ -283,8 +337,9 @@ Layout/SpaceAroundMethodCallOperator:
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals.
 # SupportedStylesForExponentOperator: space, no_space
+# SupportedStylesForRationalLiterals: space, no_space
 Layout/SpaceAroundOperators:
   Exclude:
     - 'app/views/admin/events/_all_with_comments.xlsx.axlsx'
@@ -393,6 +448,7 @@ Layout/TrailingEmptyLines:
     - 'lib/tasks/roles.rake'
 
 # Offense count: 13
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Lint/AmbiguousBlockAssociation:
   Exclude:
@@ -456,14 +512,14 @@ Lint/RedundantCopDisableDirective:
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+# Configuration parameters: AutoCorrect, IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Exclude:
     - 'lib/tasks/user.rake'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
+# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
   Exclude:
     - 'config/initializers/fuckups.rb'
@@ -746,19 +802,6 @@ RSpec/ExpectChange:
     - 'spec/models/event_spec.rb'
     - 'spec/models/user_spec.rb'
 
-# Offense count: 12
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: require_parentheses, omit_parentheses
-RSpec/FactoryBot/ConsistentParenthesesStyle:
-  Exclude:
-    - 'spec/controllers/proposals_controller_spec.rb'
-    - 'spec/features/proposals_spec.rb'
-    - 'spec/features/roles_spec.rb'
-    - 'spec/features/surveys_spec.rb'
-    - 'spec/models/resource_spec.rb'
-    - 'spec/models/ticket_spec.rb'
-
 # Offense count: 9
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
@@ -825,7 +868,7 @@ RSpec/ImplicitSubject:
     - 'spec/models/ticket_spec.rb'
 
 # Offense count: 19
-# Configuration parameters: Max.
+# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
 RSpec/IndexedLet:
   Exclude:
     - 'spec/controllers/admin/reports_controller_spec.rb'
@@ -962,6 +1005,12 @@ RSpec/Rails/InferredSpecType:
     - 'spec/helpers/users_helper_spec.rb'
     - 'spec/routing/routing_spec.rb'
 
+# Offense count: 12
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/ReceiveMessages:
+  Exclude:
+    - 'spec/models/track_spec.rb'
+
 # Offense count: 4
 RSpec/RepeatedDescription:
   Exclude:
@@ -1417,6 +1466,14 @@ Security/Open:
   Exclude:
     - 'app/pdfs/ticket_pdf.rb'
 
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'app/models/payment.rb'
+
 # Offense count: 3
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/ArrayIntersect:
@@ -1447,6 +1504,7 @@ Style/ColonMethodCall:
     - 'app/models/contact.rb'
 
 # Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Style/CombinableLoops:
   Exclude:
     - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb'
@@ -1489,7 +1547,7 @@ Style/EmptyLiteral:
 
 # Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
 # SupportedStyles: compact, expanded
 Style/EmptyMethod:
   Exclude:
@@ -1543,7 +1601,7 @@ Style/HashAsLastArrayItem:
     - 'app/models/user.rb'
 
 # Offense count: 5
-# This cop supports safe autocorrection (--autocorrect).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowSplatArgument.
 Style/HashConversion:
   Exclude:
@@ -1743,7 +1801,7 @@ Style/PreferredHashMethods:
     - 'lib/tasks/migrate_config.rake'
 
 # Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowedCompactTypes.
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
@@ -1784,17 +1842,24 @@ Style/RedundantFetchBlock:
     - 'config/puma.rb'
 
 # Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Style/RedundantFilterChain:
+  Exclude:
+    - 'app/models/program.rb'
+
+# Offense count: 12
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantParentheses:
   Exclude:
     - 'app/controllers/admin/base_controller.rb'
-
-# Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantRegexpEscape:
-  Exclude:
-    - 'spec/models/room_spec.rb'
-    - 'spec/models/user_spec.rb'
+    - 'app/controllers/application_controller.rb'
+    - 'app/helpers/application_helper.rb'
+    - 'app/helpers/format_helper.rb'
+    - 'app/models/admin_ability.rb'
+    - 'app/models/conference.rb'
+    - 'app/models/program.rb'
+    - 'app/models/venue.rb'
+    - 'lib/tasks/version.rake'
 
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
@@ -1919,7 +1984,7 @@ Style/TrailingCommaInHashLiteral:
     - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb'
     - 'spec/models/conference_spec.rb'
 
-# Offense count: 3
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: WordRegex.
 # SupportedStyles: percent, brackets

Gemfile.lock

@@ -272,11 +272,12 @@ GEM
       thor (>= 0.14, < 2.0)
     jquery-ui-rails (6.0.1)
       railties (>= 3.2.16)
-    json (2.6.3)
+    json (2.7.1)
     json-schema (4.0.0)
       addressable (>= 2.8)
     jsonapi-renderer (0.2.2)
     jwt (2.7.1)
+    language_server-protocol (3.17.0.3)
     launchy (2.5.2)
       addressable (~> 2.8)
     leaflet-rails (1.9.3)
@@ -379,9 +380,10 @@ GEM
     paper_trail (12.3.0)
       activerecord (>= 5.2)
       request_store (~> 1.1)
-    parallel (1.23.0)
-    parser (3.2.2.1)
+    parallel (1.24.0)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
+      racc
     pdf-core (0.9.0)
     pdf-inspector (1.3.0)
       pdf-reader (>= 1.0, < 3.0.a)
@@ -453,7 +455,7 @@ GEM
     rake (13.0.6)
     recaptcha (5.14.0)
     redcarpet (3.6.0)
-    regexp_parser (2.8.1)
+    regexp_parser (2.9.0)
     request_store (1.5.1)
       rack (>= 1.4)
     responders (3.1.0)
@@ -491,19 +493,22 @@ GEM
       rspec-mocks (~> 3.12)
       rspec-support (~> 3.12)
     rspec-support (3.12.0)
-    rubocop (1.51.0)
+    rubocop (1.61.0)
       json (~> 2.3)
+      language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.0, < 2.0)
+      rubocop-ast (>= 1.30.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.28.1)
-      parser (>= 3.2.1.0)
-    rubocop-capybara (2.18.0)
+    rubocop-ast (1.31.1)
+      parser (>= 3.3.0.4)
+    rubocop-capybara (2.20.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.25.1)
       rubocop (~> 1.41)
     rubocop-performance (1.17.1)
       rubocop (>= 1.7.0, < 2.0)
@@ -512,9 +517,10 @@ GEM
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.33.0, < 2.0)
-    rubocop-rspec (2.20.0)
+    rubocop-rspec (2.23.0)
       rubocop (~> 1.33)
       rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
     ruby-oembed (0.16.1)
     ruby-openid (2.9.2)
     ruby-progressbar (1.13.0)
@@ -593,7 +599,7 @@ GEM
     unf (0.1.4)
       unf_ext
     unf_ext (0.0.8.2)
-    unicode-display_width (2.4.2)
+    unicode-display_width (2.5.0)
     unobtrusive_flash (3.3.1)
       railties
     version_gem (1.1.2)