From da57c5898db35bf79069af0ad24f715a404dcae7 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Tue, 5 Mar 2024 17:19:41 +0000 Subject: [PATCH 1/2] Update haml_lint to version 0.57.0 --- Gemfile.lock | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index f8f49f64..1acedc34 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -203,7 +203,7 @@ GEM globalid (1.2.1) activesupport (>= 6.1) gravtastic (3.2.6) - haml (6.1.1) + haml (6.3.0) temple (>= 0.8.2) thor tilt @@ -212,11 +212,11 @@ GEM activesupport (>= 5.1) haml (>= 4.0.6) railties (>= 5.1) - haml_lint (0.45.0) - haml (>= 4.0, < 6.2) + haml_lint (0.57.0) + haml (>= 5.0) parallel (~> 1.10) rainbow - rubocop (>= 0.50.0) + rubocop (>= 1.0) sysexits (~> 1.1) hashdiff (1.1.0) hashery (2.1.2) @@ -562,7 +562,7 @@ GEM sysexits (1.2.0) temple (0.10.3) thor (1.3.1) - tilt (2.1.0) + tilt (2.3.0) timecop (0.9.8) timeout (0.4.1) transitions (1.3.0) From abc7e0d123c1df5668dab86e2932044ac32eca49 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Tue, 26 Mar 2024 12:02:07 +0100 Subject: [PATCH 2/2] Update haml-lint TODO --- .haml-lint_todo.yml | 69 +++++++++++++++++++++++++-------------------- 1 file changed, 38 insertions(+), 31 deletions(-) diff --git a/.haml-lint_todo.yml b/.haml-lint_todo.yml index 76ec92e7..4675819b 100644 --- a/.haml-lint_todo.yml +++ b/.haml-lint_todo.yml @@ -1,6 +1,6 @@ # This configuration was generated by # `haml-lint --auto-gen-config` -# on 2021-08-13 13:00:39 +0000 using Haml-Lint version 0.28.0. +# on 2024-03-26 11:01:18 +0000 using Haml-Lint version 0.57.0. # The point is for the user to remove these configuration records # one by one as the lints are removed from the code base. # Note that changes in the inspected code, or installation of new @@ -8,7 +8,11 @@ linters: - # Offense count: 1141 + # Offense count: 401 + InstanceVariables: + enabled: false + + # Offense count: 1378 RuboCop: enabled: false @@ -22,15 +26,11 @@ linters: - "app/views/booths/index.html.haml" - "app/views/schedules/_carousel.html.haml" - # Offense count: 981 + # Offense count: 967 LineLength: enabled: false - # Offense count: 206 - InstanceVariables: - enabled: false - - # Offense count: 12 + # Offense count: 13 ViewLength: exclude: - "app/views/admin/booths/index.html.haml" @@ -43,9 +43,9 @@ linters: - "app/views/admin/versions/_object_desc_and_link.html.haml" - "app/views/conference_registrations/show.html.haml" - "app/views/layouts/_admin_sidebar.html.haml" + - "app/views/proposals/_form.html.haml" - "app/views/proposals/index.html.haml" - "app/views/proposals/show.html.haml" - - "app/views/proposals/_form.html.haml" # Offense count: 28 IdNames: @@ -63,21 +63,34 @@ linters: - "app/views/admin/users/show.html.haml" - "app/views/users/edit.html.haml" - # Offense count: 38 + # Offense count: 37 InlineStyles: enabled: false - # Offense count: 3 - UnnecessaryInterpolation: - exclude: - - "app/views/admin/conferences/_recent_submissions.html.haml" - - "app/views/proposals/new.html.haml" - - # Offense count: 262 + # Offense count: 378 SpaceInsideHashAttributes: enabled: false - # Offense count: 24 + # Offense count: 10 + TrailingEmptyLines: + exclude: + - "app/views/admin/conferences/_form_fields.html.haml" + - "app/views/admin/events/_all_with_comments.csv.haml" + - "app/views/admin/events/_form.html.haml" + - "app/views/admin/events/_proposal.html.haml" + - "app/views/admin/schedules/_form.html.haml" + - "app/views/admin/sponsorship_levels/_form.html.haml" + - "app/views/application/_big_statistic.haml" + - "app/views/booths/_form.html.haml" + - "app/views/schedules/_schedule_item.html.haml" + - "app/views/users/edit.html.haml" + + # Offense count: 1 + UnnecessaryInterpolation: + exclude: + - "app/views/admin/conferences/_recent_submissions.html.haml" + + # Offense count: 21 ClassesBeforeIds: exclude: - "app/views/admin/emails/index.html.haml" @@ -87,11 +100,9 @@ linters: - "app/views/admin/venues/_form.html.haml" - "app/views/conferences/index.html.haml" - "app/views/devise/shared/_help.html.haml" - - "app/views/devise/shared/_sign_in_form_embedded.html.haml" - "app/views/layouts/_navigation.html.haml" - - "app/views/proposals/_form.html.haml" - # Offense count: 19 + # Offense count: 16 UnnecessaryStringOutput: exclude: - "app/views/admin/event_types/index.html.haml" @@ -101,16 +112,9 @@ linters: - "app/views/admin/versions/_object_desc_and_link.html.haml" - "app/views/admin/volunteers/show.html.haml" - "app/views/conference_registrations/show.html.haml" - - "app/views/conferences/_conference_details.html.haml" - "app/views/proposals/_encouragement_text.html.haml" - - "app/views/proposals/_form.html.haml" - - "app/views/users/edit.html.haml" - "app/views/users/show.html.haml" - # Offense count: 31 - SpaceBeforeScript: - enabled: false - # Offense count: 1 ImplicitDiv: exclude: @@ -134,10 +138,13 @@ linters: - "app/views/layouts/_navigation.html.haml" - "app/views/schedules/events.html.haml" - # Offense count: 7 + # Offense count: 30 + SpaceBeforeScript: + enabled: false + + # Offense count: 5 TrailingWhitespace: exclude: - - "app/views/admin/volunteers/index.html.haml" - "app/views/admin/volunteers/show.html.haml" - "app/views/conference_registrations/_volunteer.html.haml" - "app/views/devise/passwords/new.html.haml" @@ -146,4 +153,4 @@ linters: # Offense count: 1 FinalNewline: exclude: - - "app/views/layouts/_admin.html.haml" + - "app/views/layouts/_admin.html.haml" \ No newline at end of file