gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Introduce bulk :create, :update and :destroy

Browse source 
Introduce bulk :create, :update and :destroy actions to avoid doing several request in the admin schedule.
This commit is contained in:
Ana 2016-08-18 00:27:52 +02:00 • committed by Ana María Martínez Gómez
parent 10561129f9
commit bcff982d3d
5 changed files with 186 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

111
spec/controllers/admin/event_schedules_controller_spec.rb
View file

@ -4,30 +4,39 @@ describe Admin::EventSchedulesController do
let(:venue) { create(:venue) }
let(:conference) { create(:conference, venue: venue) }
let(:room) { create(:room, venue: venue) }
let(:schedule) { create(:schedule, program: conference.program)}
let(:event_schedule) { create(:event_schedule, schedule: schedule)}
let(:schedule) { create(:schedule, program: conference.program) }
let!(:organizer_role) { Role.find_by(name: 'organizer', resource: conference) }
let(:organizer) { create(:user, role_ids: organizer_role.id) }
context 'logged in as an organizer' do
before :each do
sign_in(organizer)
event_schedule
end
describe 'POST #create' do
context 'with valid attributes' do
let(:event1) { create(:event, program: conference.program) }
let(:event2) { create(:event, program: conference.program) }
let(:create_action) do
post :create, conference_id: conference.short_title, event_schedule:
attributes_for(:event_schedule,
schedule_id: schedule.id,
event_id: create(:event, program: conference.program).id,
room_id: create(:room, venue: venue).id,
start_time: conference.start_date)
post :bulk_create, conference_id: conference.short_title,
event_schedules: {
event1.id => {
schedule_id: schedule.id,
event_id: event1.id,
room_id: create(:room, venue: venue).id,
start_time: conference.start_date
},
event2.id => {
schedule_id: schedule.id,
event_id: event2.id,
room_id: create(:room, venue: venue).id,
start_time: conference.start_date
}
}
end
it 'saves the event schedule to the database' do
expect{ create_action }.to change { EventSchedule.count }.by 1
expect{ create_action }.to change { EventSchedule.count }.by 2
end
it 'has 200 status code' do
@ -37,14 +46,17 @@ describe Admin::EventSchedulesController do
end
context 'with invalid attributes' do
let(:event1) { create(:event, program: conference.program) }
let(:create_action) do
post :create, conference_id: conference.short_title, event_schedule:
attributes_for(:event_schedule,
schedule_id: schedule.id,
event_id: nil,
room_id: nil,
start_time: nil)
post :bulk_create, conference_id: conference.short_title,
event_schedules: {
event1.id => {
schedule_id: schedule.id,
event_id: event1.id,
room_id: nil,
start_time: nil
}
}
end
it 'does not save the event schedule to the database' do
@ -60,22 +72,38 @@ describe Admin::EventSchedulesController do
describe 'POST #update' do
context 'with valid attributes' do
let(:event1) { create(:event, program: conference.program) }
let(:event2) { create(:event, program: conference.program) }
let(:event_schedule1) { create(:event_schedule, schedule: schedule, event: event1) }
let(:event_schedule2) { create(:event_schedule, schedule: schedule, event: event2) }
before :each do
patch :update, id: event_schedule.id, conference_id: conference.short_title, event_schedule:
attributes_for(:event_schedule,
schedule_id: schedule.id,
event_id: create(:event, program: conference.program).id,
room_id: room.id,
start_time: conference.start_date)
event_schedule.reload
post :bulk_update, conference_id: conference.short_title,
event_schedules: {
event1.id => {
event_schedule1.id => {
room_id: room.id,
start_time: conference.start_date
}
},
event2.id => {
event_schedule2.id => {
room_id: room.id,
start_time: conference.start_date + 1.day
}
}
}
event_schedule1.reload
event_schedule2.reload
end
it 'updates the room' do
expect(event_schedule.room_id).to eq(room.id)
expect(event_schedule1.room_id).to eq(room.id)
expect(event_schedule2.room_id).to eq(room.id)
end
it 'updates the start_time' do
expect(event_schedule.start_time).to eq(conference.start_date)
expect(event_schedule1.start_time).to eq(conference.start_date)
expect(event_schedule2.start_time).to eq(conference.start_date + 1.day)
end
it 'has 200 status code' do
@ -84,13 +112,18 @@ describe Admin::EventSchedulesController do
end
context 'with invalid attributes' do
let(:event) { create(:event, program: conference.program) }
let(:event_schedule) { create(:event_schedule, schedule: schedule, event: event) }
let(:update_action) do
patch :update, id: event_schedule.id, conference_id: conference.short_title, event_schedule:
attributes_for(:event_schedule,
schedule_id: schedule.id,
event_id: nil,
room_id: nil,
start_time: nil)
post :bulk_update, conference_id: conference.short_title,
event_schedules: {
event.id => {
event_schedule.id => {
room_id: nil,
start_time: nil
}
}
}
end
it 'does not save the event schedule to the database' do
expect{ update_action }.to_not change { event_schedule }
@ -104,12 +137,22 @@ describe Admin::EventSchedulesController do
end
describe 'DELETE #destroy' do
let(:event1) { create(:event, program: conference.program) }
let(:event2) { create(:event, program: conference.program) }
let(:event_schedule1) { create(:event_schedule, schedule: schedule, event: event1) }
let(:event_schedule2) { create(:event_schedule, schedule: schedule, event: event2) }
let(:destroy_action) do
delete :destroy, id: event_schedule.id, conference_id: conference.short_title
post :bulk_destroy, conference_id: conference.short_title,
event_schedules: {
event1.id => event_schedule1,
event2.id => event_schedule2
}
end
it 'deletes the event schedule' do
expect{ destroy_action }.to change { EventSchedule.count }.by(-1)
event_schedule1.reload
event_schedule2.reload
expect{ destroy_action }.to change { EventSchedule.count }.by(-2)
end
it 'has 200 status code' do