suggested changes that includes:

moving actions for custom domain in its own controller
use separate service class for custom domains
updated help text for custom domains
increased test coverage for custom domains
This commit is contained in:
shlok007 2017-08-19 13:57:09 +05:30
parent d2b5ec1770
commit bc17f210a6
14 changed files with 208 additions and 73 deletions

View file

@ -1,41 +0,0 @@
.row
.col-md-12
%h1
Custom Domain
%p.text-muted
Point your own domain to #{@conference.title}
%hr
.row
.col-md-12
%h2
Step 1:
%strong
Unfortunately, we can't do this for you and you have to perform this step with the help your domain registrar!
%p
Pick a domain you want to host your conference on from a domain registrar or register it with a domain registrar.
%h2
Step 2:
%p
Enter your existing domain in the field below to point the domain to your conference splashpage.
= semantic_form_for(@conference, url: update_domain_admin_conference_path(@conference.short_title)) do |f|
= f.input :custom_domain, label: false
= f.action :submit, button_html: { class: 'btn btn-primary', value: 'Attach this domain' }
%h2
Step 3:
%strong
Unfortunately, we can't do this for you and you have to perform this step with the help your domain registrar!
%p
The last step is adding a CNAME record in your registrars DNS Settings. Different registrars have different ways of adding a CNAME record. The following guides would help you setup a CNAME record depending upon the registrar of your domain. If it doesnt, you probably should get in touch with your domain registrar and ask him how to register a CNAME record in their platform.
%ul
%li
= link_to 'GoDaddy', 'https://in.godaddy.com/help/add-a-cname-record-19236'
%li
= link_to 'Namecheap', 'https://www.namecheap.com/support/knowledgebase/article.aspx/9646/2237/how-can-i-set-up-a-cname-record-for-my-domain'
%li
= link_to 'BlueHost', 'https://my.bluehost.com/cgi/help/cname#creating_a_cname'
%li
= link_to '12-reg.co.uk', 'https://www.123-reg.co.uk/support/answers/Domains/Domain-Configuration/how-do-i-set-up-a-cname-record-on-my-domain-name-1198/'
%li
= link_to '1&1', 'https://help.1and1.com/domains-c36931/manage-domains-c79822/dns-c37586/enter-a-cname-for-your-subdomain-a643600.html'
.well.well-lg
It might take upto 24-48 hours depending upon your registrar to update your DNS Settings.

View file

@ -1,82 +0,0 @@
.row
.col-md-12
%h1
Custom domain
%p.text-muted
Point your own domain to #{@conference.title}
%hr
.row
.col-md-12
%table.table
%thead
%th Domain Name
%th Correctly points to #{@conference.short_title}
%th Actions
%tbody
%tr
%td
= @conference.custom_domain
%td
- ck_domain = @conference.check_custom_domain
- if ck_domain == true
%span.glyphicon.glyphicon-ok
- elsif ck_domain == false
%span.glyphicon.glyphicon-remove
- else
%i
= ck_domain
%td
.btn-group
= link_to 'Edit', attach_custom_domain_admin_conference_path(@conference.short_title),
method: :get, class: 'btn btn-primary'
= link_to 'Delete', admin_conference_path(@conference.short_title),
method: :delete, class: 'btn btn-danger'
.row
.col-md-9.text-right
= link_to '#status-help', class: 'btn btn-default', "data-toggle"=>"collapse" do
Help?
.row
.col-md-12
.collapse#status-help
%h2
Instructions to add your own domain
%hr
%p
When you created the conference, the conference splash page is available in the following domain:
%strong
osem.io/conferences/#{@conference.short_title}
%p
However, we also provide support for hosting conferences on your own domain.
Terms to get familiar with:
%p
%strong
Domain registrar:
Domain registrar is just another term used for providers who work on reserving domain names.
%p
%strong
CNAME:
A Canonical Name record is a resource used which defines that your domain name is an alias for another domain name.
%p
To add your own domain you can follow these
%i
three
steps:
%ol
%li
Pick a domain you want to host your conference on from a domain registrar or register it with a domain registrar.
%li
Add your own domain name to OSEM ( link to conference/custom_domain#create ) and select the conference it should belong to.
%li
The last step is adding a CNAME record in your registrars DNS Settings. Different registrars have different ways of adding a CNAME record. The following guides would help you setup a CNAME record depending upon the registrar of your domain. If it doesnt, you probably should get in touch with your domain registrar and ask him how to register a CNAME record in their platform.
%ul
%li
= link_to 'GoDaddy', 'https://in.godaddy.com/help/add-a-cname-record-19236'
%li
= link_to 'Namecheap', 'https://www.namecheap.com/support/knowledgebase/article.aspx/9646/2237/how-can-i-set-up-a-cname-record-for-my-domain'
%li
= link_to 'BlueHost', 'https://my.bluehost.com/cgi/help/cname#creating_a_cname'
%li
= link_to '12-reg.co.uk', 'https://www.123-reg.co.uk/support/answers/Domains/Domain-Configuration/how-do-i-set-up-a-cname-record-on-my-domain-name-1198/'
%li
= link_to '1&1', 'https://help.1and1.com/domains-c36931/manage-domains-c79822/dns-c37586/enter-a-cname-for-your-subdomain-a643600.html'