apply StringLiterals cop (remove double quotes, unless there is string interpolation)

This commit is contained in:
Stella Rouzi 2014-08-18 21:54:43 +03:00
parent f91467a00a
commit b7c45718d8
45 changed files with 275 additions and 109 deletions

View file

@ -15,13 +15,13 @@ FactoryGirl.define do
updated_conference_registration_dates_subject 'Conference registration dates have been updated'
updated_conference_registration_dates_template 'Sample Conference\n New Dates: January 17 - 21 2014'
send_on_venue_update true
venue_update_subject "Venue has been updated"
venue_update_template "Venue has been Updated to Sample Location"
venue_update_subject 'Venue has been updated'
venue_update_template 'Venue has been Updated to Sample Location'
registration_subject 'Lorem Ipsum Dolsum'
registration_email_template 'Lorem ipsum dolor sit amet, consectetuer adipiscing elit'
call_for_papers_dates_updates_subject "Call for Papers dates have been updated"
call_for_papers_dates_updates_template "Please checkout the new updates to submit your proposal for Sample Conference"
call_for_papers_schedule_public_subject "Sample Conference Cfp schedule is Public"
call_for_papers_schedule_public_template "Call for Papers schedule is Public.Checkout the link"
call_for_papers_dates_updates_subject 'Call for Papers dates have been updated'
call_for_papers_dates_updates_template 'Please checkout the new updates to submit your proposal for Sample Conference'
call_for_papers_schedule_public_subject 'Sample Conference Cfp schedule is Public'
call_for_papers_schedule_public_template 'Call for Papers schedule is Public.Checkout the link'
end
end

View file

@ -44,7 +44,7 @@ feature EventType do
value).to eq('300')
# Remove event type
within("div.nested-fields:nth-of-type(3)") do
within('div.nested-fields:nth-of-type(3)') do
click_link 'Remove event_type'
end
expect(page.all('div.nested-fields').count == 2).to be true

View file

@ -15,7 +15,7 @@ feature Openid do
visit '/accounts/sign_in'
mock_auth_new_user
within("#openidlinks") do
within('#openidlinks') do
click_link 'omniauth-google'
end
expect(flash).to eq('test-1@gmail.com signed in successfully with google')
@ -30,7 +30,7 @@ feature Openid do
visit '/accounts/sign_in'
mock_auth_existing_user_participant
within("#openidlinks") do
within('#openidlinks') do
click_link 'omniauth-google'
end
expect(flash).to eq('test-participant-1@google.com signed in successfully with google')
@ -42,7 +42,7 @@ feature Openid do
OmniAuth.config.mock_auth[:google] = :invalid_credentials
visit '/accounts/sign_in'
expect(page.has_content?('or sign in using')).to be true
within("#openidlinks") do
within('#openidlinks') do
click_link 'omniauth-google'
end
@ -60,7 +60,7 @@ feature Openid do
visit '/accounts/edit'
mock_auth_new_user
within("#openidlinks") do
within('#openidlinks') do
click_link 'omniauth-google'
end
expect(flash).to eq('test-participant-1@google.com signed in successfully with google')
@ -77,7 +77,7 @@ feature Openid do
visit '/accounts/sign_in'
mock_auth_existing_user_participant
within("#openidlinks") do
within('#openidlinks') do
click_link 'omniauth-google'
end
expect(flash).to eq('test-participant-1@google.com signed in successfully with google')
@ -90,7 +90,7 @@ feature Openid do
visit '/accounts/edit'
mock_auth_new_user
within("#openidlinks") do
within('#openidlinks') do
click_link 'omniauth-google'
end
expect(flash).to eq('test-participant-1@google.com signed in successfully with google')
@ -106,7 +106,7 @@ feature Openid do
visit '/accounts/sign_in'
mock_auth_new_user_fb
within("#openidlinks") do
within('#openidlinks') do
click_link 'omniauth-facebook'
end
expect(flash).to eq('test-participant-1@google.com signed in successfully with facebook')

View file

@ -56,7 +56,7 @@ feature Photo do
click_button 'Save Photo'
expect(flash).
to eq("A error prohibited this Photo from being saved: Picture content type is invalid. Picture is invalid.")
to eq('A error prohibited this Photo from being saved: Picture content type is invalid. Picture is invalid.')
expect(Photo.count).to eq(expected_count)
end
end

View file

@ -3,9 +3,9 @@
RSpec.configure do |config|
config.after(:each, type: :feature) do
ename = RSpec.current_example.full_description
ename = ename.gsub " ", "_"
ename = ename.gsub ' ', '_'
ename.downcase!
ename = ename + ".html"
ename = ename + '.html'
if RSpec.current_example.exception.present?
save_page(ename)
else

View file

@ -16,11 +16,11 @@ describe 'admin/conference/roles' do
expect(rendered).to include("Add role 'Organizer' to user:")
expect(rendered).to include('Add role')
expect(rendered).to include('Users with role Organizer')
expect(rendered).to have_selector("table thead th:nth-of-type(1)", text: 'ID')
expect(rendered).to have_selector("table thead th:nth-of-type(2)", text: 'Name')
expect(rendered).to have_selector("table thead th:nth-of-type(3)", text: 'Email')
expect(rendered).to have_selector("table tbody tr:nth-of-type(1) td:nth-of-type(1)", text: organizer.id)
expect(rendered).to have_selector("table tbody tr:nth-of-type(1) td:nth-of-type(2)", text: 'test name')
expect(rendered).to have_selector("table tbody tr:nth-of-type(1) td:nth-of-type(3)", text: 'test@email.com')
expect(rendered).to have_selector('table thead th:nth-of-type(1)', text: 'ID')
expect(rendered).to have_selector('table thead th:nth-of-type(2)', text: 'Name')
expect(rendered).to have_selector('table thead th:nth-of-type(3)', text: 'Email')
expect(rendered).to have_selector('table tbody tr:nth-of-type(1) td:nth-of-type(1)', text: organizer.id)
expect(rendered).to have_selector('table tbody tr:nth-of-type(1) td:nth-of-type(2)', text: 'test name')
expect(rendered).to have_selector('table tbody tr:nth-of-type(1) td:nth-of-type(3)', text: 'test@email.com')
end
end

View file

@ -18,15 +18,15 @@ describe 'admin/emails/index' do
to include('Conference dates have been updated')
expect(rendered).
to include('Conference registration dates have been updated')
expect(rendered).to include("Venue has been updated")
expect(rendered).to include("Venue has been Updated to Sample Location")
expect(rendered).to include('Venue has been updated')
expect(rendered).to include('Venue has been Updated to Sample Location')
expect(rendered).
to include("Call for Papers dates have been updated")
to include('Call for Papers dates have been updated')
expect(rendered).
to include("Please checkout the new updates to submit your proposal for Sample Conference")
to include('Please checkout the new updates to submit your proposal for Sample Conference')
expect(rendered).
to include("Sample Conference Cfp schedule is Public")
to include('Sample Conference Cfp schedule is Public')
expect(rendered).
to include("Call for Papers schedule is Public.Checkout the link")
to include('Call for Papers schedule is Public.Checkout the link')
end
end

View file

@ -1,10 +1,10 @@
require 'spec_helper'
describe 'home/index' do
it "renders _conference partial for each conference" do
allow(view).to receive(:date_string).and_return("January 17 - 21 2014")
it 'renders _conference partial for each conference' do
allow(view).to receive(:date_string).and_return('January 17 - 21 2014')
assign(:current, [create(:conference), create(:conference)])
render
expect(view).to render_template(partial: "_conference_details", count: 2)
expect(view).to render_template(partial: '_conference_details', count: 2)
end
end