From abe017fc4e2d3a01b1c441120759fb5e16396725 Mon Sep 17 00:00:00 2001 From: CactusPuppy Date: Tue, 2 Mar 2021 15:09:34 -0800 Subject: [PATCH 1/5] Make 'all' option actually fire all rspec tests --- travis_script.sh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/travis_script.sh b/travis_script.sh index 3f4f52cf..57ca8aa5 100755 --- a/travis_script.sh +++ b/travis_script.sh @@ -15,20 +15,20 @@ case $TEST_SUITE in linters) bundle exec rubocop -Dc .rubocop.yml bundle exec haml-lint app/views - ;; - models) + ;;& + models|all) bundle exec rspec --format documentation spec/models - ;; - features) + ;;& + features|all) bundle exec rspec --format documentation spec/features - ;; - controllers) + ;;& + controllers|all) bundle exec rspec --format documentation spec/controllers - ;; - ability) + ;;& + ability|all) bundle exec rspec --format documentation spec/ability - ;; - rest) + ;;& + rest|all) bundle exec rspec --format documentation --exclude-pattern "spec/{models,features,controllers,ability}/**/*_spec.rb" ;; esac From 247beb172b8aa0dbea3dd85a62ed9e25774f8875 Mon Sep 17 00:00:00 2001 From: CactusPuppy Date: Thu, 4 Mar 2021 22:16:16 -0800 Subject: [PATCH 2/5] Allow coverage to drop by a small threshold without failing CI --- .codecov.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.codecov.yml b/.codecov.yml index db247200..9c6a4c0d 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -1 +1,6 @@ +coverage: + status: + project: + default: + threshold: 0.5% comment: off From d413da13811786c73d7f8cd795d77779b0676075 Mon Sep 17 00:00:00 2001 From: CactusPuppy Date: Thu, 4 Mar 2021 22:28:29 -0800 Subject: [PATCH 3/5] Revert "Allow coverage to drop by a small threshold without failing CI" Small changes in coverage may be indicative of a larger issue with unintentional changes in behavior. Thus, reverting the threshold change. This reverts commit 247beb172b8aa0dbea3dd85a62ed9e25774f8875. --- .codecov.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.codecov.yml b/.codecov.yml index 9c6a4c0d..db247200 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -1,6 +1 @@ -coverage: - status: - project: - default: - threshold: 0.5% comment: off From aced0925b33add05b1cc2ff38ad1867d5022f4ad Mon Sep 17 00:00:00 2001 From: CactusPuppy Date: Thu, 4 Mar 2021 22:50:37 -0800 Subject: [PATCH 4/5] Include linters in all suites --- bin/travis_script.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/travis_script.sh b/bin/travis_script.sh index 57ca8aa5..dfcbfcac 100755 --- a/bin/travis_script.sh +++ b/bin/travis_script.sh @@ -12,7 +12,7 @@ else fi case $TEST_SUITE in - linters) + linters|all) bundle exec rubocop -Dc .rubocop.yml bundle exec haml-lint app/views ;;& From 98649a6780ff626f8d26fc00a5bb6493c066dd0b Mon Sep 17 00:00:00 2001 From: CactusPuppy Date: Sun, 7 Mar 2021 23:08:29 -0800 Subject: [PATCH 5/5] Add small accpetable test coverage dip threshold --- .codecov.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.codecov.yml b/.codecov.yml index db247200..9c6a4c0d 100644 --- a/.codecov.yml +++ b/.codecov.yml @@ -1 +1,6 @@ +coverage: + status: + project: + default: + threshold: 0.5% comment: off