From e734dbd3d6a9975a88540fe095bd2a2aea370d77 Mon Sep 17 00:00:00 2001 From: "depfu[bot]" <23717796+depfu[bot]@users.noreply.github.com> Date: Mon, 1 May 2023 07:45:27 +0000 Subject: [PATCH 1/6] Update rubocop to version 1.50.2 --- Gemfile.lock | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index bd04e54e..de790a77 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -382,8 +382,8 @@ GEM paper_trail (12.3.0) activerecord (>= 5.2) request_store (~> 1.1) - parallel (1.22.1) - parser (3.1.2.0) + parallel (1.23.0) + parser (3.2.2.1) ast (~> 2.4.1) pdf-core (0.9.0) pdf-inspector (1.3.0) @@ -457,7 +457,7 @@ GEM recaptcha (5.10.0) json redcarpet (3.6.0) - regexp_parser (2.5.0) + regexp_parser (2.8.0) request_store (1.5.1) rack (>= 1.4) responders (3.0.1) @@ -495,17 +495,18 @@ GEM rspec-mocks (~> 3.11) rspec-support (~> 3.11) rspec-support (3.12.0) - rubocop (1.30.1) + rubocop (1.50.2) + json (~> 2.3) parallel (~> 1.10) - parser (>= 3.1.0.0) + parser (>= 3.2.0.0) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.18.0, < 2.0) + rubocop-ast (>= 1.28.0, < 2.0) ruby-progressbar (~> 1.7) - unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.18.0) - parser (>= 3.1.1.0) + unicode-display_width (>= 2.4.0, < 3.0) + rubocop-ast (1.28.0) + parser (>= 3.2.1.0) rubocop-rails (2.15.0) activesupport (>= 4.2.0) rack (>= 1.1) @@ -514,7 +515,7 @@ GEM rubocop (~> 1.19) ruby-oembed (0.16.1) ruby-openid (2.9.2) - ruby-progressbar (1.11.0) + ruby-progressbar (1.13.0) ruby-rc4 (0.1.5) ruby-vips (2.1.4) ffi (~> 1.12) From 9e36aa9721e5af5c87910cbee3cb495a7d6e1a4f Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:46:49 +0200 Subject: [PATCH 2/6] Regenerate rubocop TODO --- .rubocop_todo.yml | 432 ++++++++++++++++++++++++---------------------- 1 file changed, 224 insertions(+), 208 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index b4637d3e..7ac6e238 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,13 +1,13 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2022-02-10 16:47:29 UTC using RuboCop version 1.25.1. +# on 2023-05-08 11:46:10 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb Bundler/OrderedGems: @@ -15,14 +15,14 @@ Bundler/OrderedGems: - 'Gemfile' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IndentationWidth. Layout/AssignmentIndentation: Exclude: - 'app/helpers/format_helper.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/ClosingParenthesisIndentation: Exclude: - 'app/controllers/conference_registrations_controller.rb' @@ -30,8 +30,8 @@ Layout/ClosingParenthesisIndentation: - 'app/models/commercial.rb' - 'spec/controllers/users/omniauth_callbacks_controller_spec.rb' -# Offense count: 14 -# Cop supports --auto-correct. +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment. Layout/CommentIndentation: Exclude: @@ -40,36 +40,35 @@ Layout/CommentIndentation: - 'app/models/conference.rb' - 'app/models/program.rb' - 'app/models/track.rb' - - 'spec/features/volunteers_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/EmptyLineAfterGuardClause: Exclude: - 'app/controllers/subscriptions_controller.rb' - 'app/models/program.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/EmptyLineAfterMagicComment: Exclude: - 'spec/models/conference_spec.rb' -# Offense count: 108 -# Cop supports --auto-correct. +# Offense count: 102 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines Layout/EmptyLinesAroundBlockBody: Enabled: false # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/EmptyLinesAroundExceptionHandlingKeywords: Exclude: - 'app/models/payment.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. Layout/ExtraSpacing: Exclude: @@ -81,14 +80,14 @@ Layout/ExtraSpacing: - 'spec/models/conference_spec.rb' # Offense count: 43 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses Layout/FirstArgumentIndentation: Enabled: false # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_brackets Layout/FirstArrayElementIndentation: @@ -96,7 +95,7 @@ Layout/FirstArrayElementIndentation: - 'app/models/conference.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces Layout/FirstHashElementIndentation: @@ -106,7 +105,7 @@ Layout/FirstHashElementIndentation: - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: normal, indented_internal_methods Layout/IndentationConsistency: @@ -115,7 +114,7 @@ Layout/IndentationConsistency: - 'app/models/event.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IndentationWidth, EnforcedStyle. # SupportedStyles: spaces, tabs Layout/IndentationStyle: @@ -123,28 +122,46 @@ Layout/IndentationStyle: - 'app/controllers/admin/resources_controller.rb' # Offense count: 1 -# Cop supports --auto-correct. -# Configuration parameters: Width, IgnoredPatterns. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Width, AllowedPatterns. Layout/IndentationWidth: Exclude: - 'app/controllers/users_controller.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment. Layout/LeadingCommentSpace: Exclude: - 'app/models/comment.rb' +# Offense count: 18 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: space, no_space +Layout/LineContinuationSpacing: + Exclude: + - 'app/controllers/admin/booths_controller.rb' + - 'app/controllers/admin/cfps_controller.rb' + - 'app/controllers/admin/commercials_controller.rb' + - 'app/controllers/admin/difficulty_levels_controller.rb' + - 'app/controllers/admin/event_types_controller.rb' + - 'app/controllers/admin/registrations_controller.rb' + - 'app/controllers/admin/splashpages_controller.rb' + - 'app/controllers/admin/venue_commercials_controller.rb' + - 'app/controllers/admin/venues_controller.rb' + - 'app/controllers/conference_registrations_controller.rb' + - 'app/models/cfp.rb' + # Offense count: 32 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented Layout/LineEndStringConcatenationIndentation: Enabled: false # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineArrayBraceLayout: @@ -152,13 +169,13 @@ Layout/MultilineArrayBraceLayout: - 'app/controllers/conference_registrations_controller.rb' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/MultilineBlockLayout: Exclude: - 'app/serializers/conference_serializer.rb' # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineHashBraceLayout: @@ -167,22 +184,22 @@ Layout/MultilineHashBraceLayout: - 'config/routes.rb' - 'spec/models/event_spec.rb' -# Offense count: 35 -# Cop supports --auto-correct. +# Offense count: 33 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: Enabled: false -# Offense count: 55 -# Cop supports --auto-correct. +# Offense count: 47 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented, indented_relative_to_receiver Layout/MultilineMethodCallIndentation: Enabled: false # Offense count: 18 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented Layout/MultilineOperationIndentation: @@ -193,7 +210,7 @@ Layout/MultilineOperationIndentation: - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' # Offense count: 64 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceAfterComma: Exclude: - 'app/views/admin/booths/_all_booths.xlsx.axlsx' @@ -206,7 +223,7 @@ Layout/SpaceAfterComma: - 'lib/tasks/data_demo.rake' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space Layout/SpaceAroundEqualsInParameterDefault: @@ -215,13 +232,13 @@ Layout/SpaceAroundEqualsInParameterDefault: - 'app/models/event.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceAroundKeyword: Exclude: - 'config/initializers/feature.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceAroundMethodCallOperator: Exclude: - 'spec/features/cfp_ability_spec.rb' @@ -230,7 +247,7 @@ Layout/SpaceAroundMethodCallOperator: - 'spec/models/program_spec.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator. # SupportedStylesForExponentOperator: space, no_space Layout/SpaceAroundOperators: @@ -239,7 +256,7 @@ Layout/SpaceAroundOperators: - 'lib/tasks/data.rake' # Offense count: 139 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space # SupportedStylesForEmptyBraces: space, no_space @@ -247,7 +264,7 @@ Layout/SpaceBeforeBlockBraces: Enabled: false # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceBeforeComma: Exclude: - 'app/views/admin/booths/_all_booths.xlsx.axlsx' @@ -259,14 +276,14 @@ Layout/SpaceBeforeComma: - 'lib/tasks/data_demo.rake' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowForAlignment. Layout/SpaceBeforeFirstArg: Exclude: - 'app/controllers/admin/booths_controller.rb' # Offense count: 8 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. # SupportedStyles: space, no_space, compact # SupportedStylesForEmptyBrackets: space, no_space @@ -276,7 +293,7 @@ Layout/SpaceInsideArrayLiteralBrackets: - 'config/routes.rb' # Offense count: 44 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space # SupportedStylesForEmptyBraces: space, no_space @@ -296,7 +313,7 @@ Layout/SpaceInsideBlockBraces: - 'spec/models/user_spec.rb' # Offense count: 37 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact # SupportedStylesForEmptyBraces: space, no_space @@ -318,7 +335,7 @@ Layout/SpaceInsideHashLiteralBraces: - 'spec/models/payment_spec.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: space, compact, no_space Layout/SpaceInsideParens: @@ -326,13 +343,13 @@ Layout/SpaceInsideParens: - 'app/views/admin/registrations/index.xlsx.axlsx' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Layout/SpaceInsidePercentLiteralDelimiters: Exclude: - 'Gemfile' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: final_newline, final_blank_line Layout/TrailingEmptyLines: @@ -341,7 +358,7 @@ Layout/TrailingEmptyLines: - 'lib/tasks/roles.rake' # Offense count: 13 -# Configuration parameters: IgnoredMethods. +# Configuration parameters: AllowedMethods, AllowedPatterns. Lint/AmbiguousBlockAssociation: Exclude: - 'spec/controllers/admin/conferences_controller_spec.rb' @@ -353,7 +370,7 @@ Lint/AmbiguousBlockAssociation: - 'spec/models/user_spec.rb' # Offense count: 13 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Lint/AmbiguousOperatorPrecedence: Exclude: - 'app/controllers/application_controller.rb' @@ -396,43 +413,49 @@ Lint/IneffectiveAccessModifier: - 'app/models/commercial.rb' - 'app/models/conference.rb' +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Lint/NonAtomicFileOperation: + Exclude: + - 'spec/support/save_feature_failures.rb' + # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Lint/RedundantCopDisableDirective: Exclude: - 'spec/support/save_feature_failures.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: Exclude: - 'lib/tasks/user.rake' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods. Lint/UnusedMethodArgument: Exclude: - 'config/initializers/fuckups.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Lint/UriRegexp: Exclude: - 'app/models/commercial.rb' - 'app/models/contact.rb' # Offense count: 127 -# Configuration parameters: IgnoredMethods, CountRepeatedAttributes. +# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes. Metrics/AbcSize: Max: 72 -# Offense count: 313 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. -# IgnoredMethods: refine +# Offense count: 28 +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode. +# AllowedMethods: refine Metrics/BlockLength: - Max: 1341 + Max: 211 # Offense count: 1 # Configuration parameters: CountBlocks. @@ -444,13 +467,13 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 652 -# Offense count: 29 -# Configuration parameters: IgnoredMethods. +# Offense count: 27 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 16 # Offense count: 152 -# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods. +# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 56 @@ -459,8 +482,8 @@ Metrics/MethodLength: Metrics/ModuleLength: Max: 174 -# Offense count: 26 -# Configuration parameters: IgnoredMethods. +# Offense count: 24 +# Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 19 @@ -472,7 +495,7 @@ Naming/AccessorMethodName: # Offense count: 2 # Configuration parameters: ForbiddenDelimiters. -# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$)) +# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$)) Naming/HeredocDelimiterNaming: Exclude: - 'spec/factories/users.rb' @@ -480,7 +503,7 @@ Naming/HeredocDelimiterNaming: # Offense count: 2 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. -# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to +# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to Naming/MethodParameterName: Exclude: - 'app/models/conference.rb' @@ -497,7 +520,7 @@ Naming/PredicateName: - 'app/models/contact.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredName. Naming/RescuedExceptionsVariableName: Exclude: @@ -505,9 +528,9 @@ Naming/RescuedExceptionsVariableName: - 'app/models/payment.rb' # Offense count: 9 -# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers. +# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns. # SupportedStyles: snake_case, normalcase, non_integer -# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339 +# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64 Naming/VariableNumber: Exclude: - 'app/models/program.rb' @@ -526,13 +549,12 @@ RSpec/AnyInstance: - 'spec/controllers/proposals_controller_spec.rb' - 'spec/controllers/tracks_controller_spec.rb' -# Offense count: 351 -# Cop supports --auto-correct. +# Offense count: 350 +# This cop supports safe autocorrection (--autocorrect). RSpec/Capybara/CurrentPathExpectation: Exclude: - 'spec/features/base_controller_spec.rb' - 'spec/features/cfp_ability_spec.rb' - - 'spec/features/commercials_spec.rb' - 'spec/features/conference_registration_spec.rb' - 'spec/features/info_desk_ability_spec.rb' - 'spec/features/organization_admin_ability_spec.rb' @@ -544,8 +566,8 @@ RSpec/Capybara/CurrentPathExpectation: - 'spec/features/track_organizer_ability_spec.rb' - 'spec/features/user_ability_spec.rb' -# Offense count: 162 -# Cop supports --auto-correct. +# Offense count: 159 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnabledMethods. RSpec/Capybara/FeatureMethods: Enabled: false @@ -557,7 +579,7 @@ RSpec/ContextWording: Enabled: false # Offense count: 73 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SkipBlocks, EnforcedStyle. # SupportedStyles: described_class, explicit RSpec/DescribedClass: @@ -578,7 +600,7 @@ RSpec/DescribedClass: - 'spec/serializers/track_serializer_spec.rb' # Offense count: 11 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowConsecutiveOneLiners. RSpec/EmptyLineAfterExample: Exclude: @@ -591,13 +613,13 @@ RSpec/EmptyLineAfterExample: - 'spec/models/survey_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterExampleGroup: Exclude: - 'spec/controllers/admin/users_controller_spec.rb' # Offense count: 11 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterFinalLet: Exclude: - 'spec/controllers/admin/event_schedules_controller_spec.rb' @@ -609,7 +631,7 @@ RSpec/EmptyLineAfterFinalLet: - 'spec/models/ticket_spec.rb' # Offense count: 17 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterHook: Exclude: - 'spec/controllers/admin/booths_controller_spec.rb' @@ -624,7 +646,7 @@ RSpec/EmptyLineAfterHook: - 'spec/models/program_spec.rb' # Offense count: 8 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/EmptyLineAfterSubject: Exclude: - 'spec/ability/ability_spec.rb' @@ -636,19 +658,18 @@ RSpec/EmptyLineAfterSubject: - 'spec/models/survey_spec.rb' - 'spec/models/track_spec.rb' -# Offense count: 218 +# Offense count: 213 # Configuration parameters: CountAsOne. RSpec/ExampleLength: Max: 187 -# Offense count: 18 -# Cop supports --auto-correct. +# Offense count: 15 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: CustomTransform, IgnoredWords. RSpec/ExampleWording: Exclude: - 'spec/controllers/admin/organizations_controller_spec.rb' - 'spec/controllers/admin/registration_periods_controller_spec.rb' - - 'spec/controllers/application_controller_spec.rb' - 'spec/helpers/application_helper_spec.rb' - 'spec/helpers/events_helper_spec.rb' - 'spec/helpers/format_helper_spec.rb' @@ -658,7 +679,7 @@ RSpec/ExampleWording: - 'spec/models/ticket_spec.rb' # Offense count: 37 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: method_call, block RSpec/ExpectChange: @@ -678,7 +699,7 @@ RSpec/ExpectChange: - 'spec/models/event_spec.rb' - 'spec/models/user_spec.rb' -# Offense count: 10 +# Offense count: 9 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly. # Include: **/*_spec*rb*, **/spec/**/* RSpec/FilePath: @@ -690,12 +711,11 @@ RSpec/FilePath: - 'spec/features/proposals_spec.rb' - 'spec/features/ticket_purchases_spec.rb' - 'spec/features/venues_spec.rb' - - 'spec/features/volunteers_spec.rb' - 'spec/models/comment_spec.rb' - 'spec/models/openid.rb' -# Offense count: 169 -# Cop supports --auto-correct. +# Offense count: 172 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, each, example RSpec/HookArgument: @@ -707,7 +727,7 @@ RSpec/IdenticalEqualityAssertion: - 'spec/controllers/admin/conferences_controller_spec.rb' # Offense count: 140 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: is_expected, should RSpec/ImplicitExpect: @@ -728,7 +748,7 @@ RSpec/ImplicitExpect: - 'spec/models/user_spec.rb' # Offense count: 39 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: single_line_only, single_statement_only, disallow RSpec/ImplicitSubject: @@ -765,34 +785,33 @@ RSpec/InstanceVariable: - 'spec/models/user_spec.rb' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/LeadingSubject: Exclude: - 'spec/ability/ability_spec.rb' - 'spec/models/conference_spec.rb' - 'spec/models/ticket_spec.rb' -# Offense count: 59 +# Offense count: 61 RSpec/LetSetup: Enabled: false -# Offense count: 13 +# Offense count: 12 # Configuration parameters: . # SupportedStyles: have_received, receive RSpec/MessageSpies: EnforcedStyle: receive -# Offense count: 2 +# Offense count: 1 RSpec/MultipleDescribes: Exclude: - - 'spec/controllers/application_controller_spec.rb' - 'spec/models/conference_spec.rb' -# Offense count: 277 +# Offense count: 270 RSpec/MultipleExpectations: Max: 97 -# Offense count: 247 +# Offense count: 249 # Configuration parameters: AllowSubject. RSpec/MultipleMemoizedHelpers: Max: 32 @@ -810,8 +829,8 @@ RSpec/NamedSubject: RSpec/NestedGroups: Max: 7 -# Offense count: 85 -# Cop supports --auto-correct. +# Offense count: 83 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: not_to, to_not RSpec/NotToNot: @@ -822,16 +841,8 @@ RSpec/OverwritingSetup: Exclude: - 'spec/controllers/admin/booths_controller_spec.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: Strict, EnforcedStyle, AllowedExplicitMatchers. -# SupportedStyles: inflected, explicit -RSpec/PredicateMatcher: - Exclude: - - 'spec/features/code_of_conduct_spec.rb' - # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/Rails/AvoidSetupHook: Exclude: - 'spec/features/versions_spec.rb' @@ -853,7 +864,7 @@ RSpec/RepeatedExampleGroupBody: - 'spec/models/conference_spec.rb' # Offense count: 10 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: and_return, block RSpec/ReturnFromStub: @@ -861,7 +872,7 @@ RSpec/ReturnFromStub: - 'spec/helpers/events_helper_spec.rb' # Offense count: 19 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). RSpec/ScatteredLet: Exclude: - 'spec/ability/ability_spec.rb' @@ -902,29 +913,20 @@ Security/Open: - 'app/pdfs/ticket_pdf.rb' # Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: separated, grouped -Style/AccessorGrouping: +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/ArrayIntersect: Exclude: - - 'app/models/payment.rb' - -# Offense count: 12 -# Cop supports --auto-correct-all. -Style/CaseLikeIf: - Exclude: - - 'app/controllers/admin/roles_controller.rb' - - 'app/controllers/admin/users_controller.rb' - - 'app/helpers/application_helper.rb' - - 'app/helpers/versions_helper.rb' - - 'app/models/user.rb' - - 'app/views/admin/booths/booths.xlsx.axlsx' - - 'app/views/admin/events/events.xlsx.axlsx' - - 'app/views/admin/tracks/tracks.xlsx.axlsx' - - 'lib/tasks/version.rake' + - 'app/models/admin_ability.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: MinBranchesCount. +Style/CaseLikeIf: + Exclude: + - 'app/views/admin/events/events.xlsx.axlsx' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: is_a?, kind_of? Style/ClassCheck: @@ -932,7 +934,7 @@ Style/ClassCheck: - 'app/models/email_settings.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/ColonMethodCall: Exclude: - 'app/models/commercial.rb' @@ -944,7 +946,7 @@ Style/CombinableLoops: - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: Keywords, RequireColon. # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE Style/CommentAnnotation: @@ -952,7 +954,7 @@ Style/CommentAnnotation: - 'spec/controllers/admin/versions_controller_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. # SupportedStyles: assign_to_condition, assign_inside_condition Style/ConditionalAssignment: @@ -961,26 +963,26 @@ Style/ConditionalAssignment: - 'db/migrate/20140610165551_migrate_data_person_to_user.rb' - 'db/migrate/20140820124117_undo_wrong_migration20140801080705_add_users_to_events.rb' -# Offense count: 501 +# Offense count: 518 # Configuration parameters: AllowedConstants. Style/Documentation: Enabled: false # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/EmptyCaseCondition: Exclude: - 'app/helpers/format_helper.rb' - 'app/helpers/versions_helper.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/EmptyLiteral: Exclude: - 'spec/models/conference_spec.rb' # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: compact, expanded Style/EmptyMethod: @@ -993,41 +995,42 @@ Style/EmptyMethod: - 'db/migrate/20130206192339_rename_attending_social_events_with_partner.rb' - 'db/migrate/20130216122155_set_registration_defaults_to_false.rb' -# Offense count: 3 -# Cop supports --auto-correct. +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). Style/Encoding: Exclude: - 'app/uploaders/picture_uploader.rb' - 'spec/models/conference_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/ExpandPathArguments: Exclude: - 'bin/bundle' - 'bin/rspec' - 'spec/spec_helper.rb' -# Offense count: 41 -# Cop supports --auto-correct. +# Offense count: 39 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never Style/FrozenStringLiteralComment: Enabled: false # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/GlobalStdStream: Exclude: - 'config/environments/production.rb' -# Offense count: 29 -# Configuration parameters: MinBodyLength. +# Offense count: 28 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals. Style/GuardClause: Enabled: false # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: braces, no_braces Style/HashAsLastArrayItem: @@ -1036,7 +1039,7 @@ Style/HashAsLastArrayItem: - 'app/models/user.rb' # Offense count: 5 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowSplatArgument. Style/HashConversion: Exclude: @@ -1050,41 +1053,41 @@ Style/HashLikeCase: Exclude: - 'app/helpers/versions_helper.rb' -# Offense count: 358 -# Cop supports --auto-correct. +# Offense count: 367 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys -# SupportedShorthandSyntax: always, never, either +# SupportedShorthandSyntax: always, never, either, consistent Style/HashSyntax: Enabled: false # Offense count: 2 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/HashTransformValues: Exclude: - 'app/controllers/admin/comments_controller.rb' - 'app/helpers/chart_helper.rb' -# Offense count: 61 -# Cop supports --auto-correct. +# Offense count: 60 +# This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Enabled: false -# Offense count: 10 -# Cop supports --auto-correct. +# Offense count: 8 +# This cop supports unsafe autocorrection (--autocorrect-all). Style/LineEndConcatenation: Exclude: - 'spec/features/conference_spec.rb' - 'spec/features/registration_periods_spec.rb' # Offense count: 1 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). Style/MapToHash: Exclude: - 'app/controllers/admin/comments_controller.rb' # Offense count: 9 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline Style/MethodDefParentheses: @@ -1093,13 +1096,20 @@ Style/MethodDefParentheses: - 'app/models/user.rb' - 'lib/tasks/demo_data_for_development.rake' +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +Style/MinMaxComparison: + Exclude: + - 'app/helpers/format_helper.rb' + - 'app/models/cfp.rb' + # Offense count: 1 Style/MixinUsage: Exclude: - 'spec/spec_helper.rb' # Offense count: 7 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/MultilineIfModifier: Exclude: - 'app/controllers/conferences_controller.rb' @@ -1109,7 +1119,7 @@ Style/MultilineIfModifier: - 'app/models/registration_period.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: literals, strict Style/MutableConstant: @@ -1118,7 +1128,7 @@ Style/MutableConstant: - 'lib/tasks/migrate_config.rake' # Offense count: 4 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedMethods. # AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with Style/NestedParenthesizedCalls: @@ -1127,14 +1137,14 @@ Style/NestedParenthesizedCalls: - 'spec/models/conference_spec.rb' # Offense count: 27 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinBodyLength. # SupportedStyles: skip_modifier_ifs, always Style/Next: Enabled: false # Offense count: 115 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedOctalStyle. # SupportedOctalStyles: zero_with_o, zero_only Style/NumericLiteralPrefix: @@ -1148,14 +1158,14 @@ Style/NumericLiteralPrefix: - 'spec/serializers/event_serializer_spec.rb' # Offense count: 7 -# Cop supports --auto-correct. -# Configuration parameters: Strict, AllowedNumbers. +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns. Style/NumericLiterals: MinDigits: 15 # Offense count: 36 -# Cop supports --auto-correct-all. -# Configuration parameters: EnforcedStyle, IgnoredMethods. +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns. # SupportedStyles: predicate, comparison Style/NumericPredicate: Exclude: @@ -1177,24 +1187,23 @@ Style/OptionalArguments: Exclude: - 'app/models/event.rb' -# Offense count: 8 +# Offense count: 7 # Configuration parameters: AllowedMethods. # AllowedMethods: respond_to_missing? Style/OptionalBooleanParameter: Exclude: - 'app/controllers/admin/events_controller.rb' - - 'app/helpers/application_helper.rb' - 'app/helpers/format_helper.rb' - 'app/models/event.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/OrAssignment: Exclude: - 'app/controllers/schedules_controller.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions. Style/ParenthesesAroundCondition: Exclude: @@ -1202,8 +1211,8 @@ Style/ParenthesesAroundCondition: - 'app/controllers/application_controller.rb' - 'app/helpers/format_helper.rb' -# Offense count: 19 -# Cop supports --auto-correct. +# Offense count: 17 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Exclude: @@ -1219,11 +1228,10 @@ Style/PercentLiteralDelimiters: - 'app/models/track.rb' - 'app/uploaders/picture_uploader.rb' - 'config/deploy.rb' - - 'config/initializers/formtastic.rb' - 'spec/models/program_spec.rb' # Offense count: 1 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: short, verbose Style/PreferredHashMethods: @@ -1231,54 +1239,61 @@ Style/PreferredHashMethods: - 'lib/tasks/migrate_config.rake' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowedCompactTypes. # SupportedStyles: compact, exploded Style/RaiseArgs: EnforcedStyle: compact # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RandomWithOffset: Exclude: - 'spec/factories/sponsors.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantAssignment: Exclude: - 'app/helpers/application_helper.rb' - 'app/helpers/format_helper.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantCondition: Exclude: - 'app/helpers/versions_helper.rb' - 'app/models/ticket.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantConstantBase: + Exclude: + - 'config/environments/production.rb' + - 'spec/spec_helper.rb' + # Offense count: 3 -# Cop supports --auto-correct-all. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: SafeForConstants. Style/RedundantFetchBlock: Exclude: - 'config/puma.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantParentheses: Exclude: - 'app/controllers/admin/base_controller.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). Style/RedundantRegexpEscape: Exclude: - 'spec/models/room_spec.rb' - 'spec/models/user_spec.rb' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Exclude: @@ -1286,8 +1301,14 @@ Style/RedundantReturn: - 'app/controllers/admin/events_controller.rb' - 'app/controllers/admin/organizations_controller.rb' +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Style/RedundantStringEscape: + Exclude: + - 'app/models/conference.rb' + # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, AllowInnerSlashes. # SupportedStyles: slashes, percent_r, mixed Style/RegexpLiteral: @@ -1295,7 +1316,7 @@ Style/RegexpLiteral: - 'app/uploaders/picture_uploader.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, explicit Style/RescueStandardError: @@ -1304,7 +1325,7 @@ Style/RescueStandardError: - 'lib/tasks/migrate_config.rake' # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: only_raise, only_fail, semantic Style/SignalException: @@ -1313,7 +1334,7 @@ Style/SignalException: - 'spec/support/flash.rb' # Offense count: 6 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowModifier. Style/SoleNestedConditional: Exclude: @@ -1325,20 +1346,20 @@ Style/SoleNestedConditional: - 'db/migrate/20151018152439_create_programs_table.rb' # Offense count: 1 -# Cop supports --auto-correct. +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: RequireEnglish. -# SupportedStyles: use_perl_names, use_english_names +# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names Style/SpecialGlobalVars: EnforcedStyle: use_perl_names -# Offense count: 31 -# Cop supports --auto-correct-all. +# Offense count: 28 +# This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: Enabled: false -# Offense count: 35 -# Cop supports --auto-correct. +# Offense count: 25 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: @@ -1354,7 +1375,7 @@ Style/StringLiterals: - 'lib/tasks/user.rake' # Offense count: 14 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle. # SupportedStyles: single_quotes, double_quotes Style/StringLiteralsInInterpolation: @@ -1364,21 +1385,22 @@ Style/StringLiteralsInInterpolation: - 'app/views/admin/events/_confirmed_events.xlsx.axlsx' - 'lib/tasks/dump_db.rake' -# Offense count: 109 -# Cop supports --auto-correct. +# Offense count: 110 +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, MinSize. # SupportedStyles: percent, brackets Style/SymbolArray: Enabled: false -# Offense count: 10 -# Cop supports --auto-correct-all. -# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods. -# IgnoredMethods: respond_to, define_method +# Offense count: 11 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments. +# AllowedMethods: define_method Style/SymbolProc: Exclude: - 'app/controllers/admin/comments_controller.rb' - 'app/controllers/admin/questions_controller.rb' + - 'app/controllers/admin/tracks_controller.rb' - 'app/models/ability.rb' - 'app/models/admin_ability.rb' - 'db/migrate/20140730104658_migrate_roles_for_cancancan.rb' @@ -1386,7 +1408,7 @@ Style/SymbolProc: - 'spec/support/flash.rb' # Offense count: 2 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, AllowSafeAssignment. # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex Style/TernaryParentheses: @@ -1394,7 +1416,7 @@ Style/TernaryParentheses: - 'app/helpers/format_helper.rb' # Offense count: 21 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma Style/TrailingCommaInHashLiteral: @@ -1402,23 +1424,17 @@ Style/TrailingCommaInHashLiteral: - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' - 'spec/models/conference_spec.rb' -# Offense count: 1 -# Cop supports --auto-correct. -Style/UnlessElse: - Exclude: - - 'config/routes.rb' - # Offense count: 3 -# Cop supports --auto-correct. +# This cop supports safe autocorrection (--autocorrect). # Configuration parameters: WordRegex. # SupportedStyles: percent, brackets Style/WordArray: EnforcedStyle: percent MinSize: 6 -# Offense count: 532 -# Cop supports --auto-correct. -# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. +# Offense count: 526 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https Layout/LineLength: Max: 619 From 76145f0874289b2d78dd33fe96dddde90d4b9273 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:48:43 +0200 Subject: [PATCH 3/6] Include rubocop-rails in configuration --- .rubocop.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index ff82c04c..5238ee6b 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,4 +1,6 @@ -require: rubocop-rspec +require: + - rubocop-rspec + - rubocop-rails inherit_from: .rubocop_todo.yml From 7b85b86e159175e6edc4ed82f905574205bb5aaf Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:52:04 +0200 Subject: [PATCH 4/6] Introduces rubocop-capybara --- .rubocop.yml | 1 + Gemfile | 1 + Gemfile.lock | 3 +++ 3 files changed, 5 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index 5238ee6b..edb15a05 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,6 +1,7 @@ require: - rubocop-rspec - rubocop-rails + - rubocop-capybara inherit_from: .rubocop_todo.yml diff --git a/Gemfile b/Gemfile index 301ff1a6..5879c729 100644 --- a/Gemfile +++ b/Gemfile @@ -235,6 +235,7 @@ group :development do gem 'rubocop', require: false gem 'rubocop-rspec', require: false gem 'rubocop-rails', require: false + gem 'rubocop-capybara', require: false gem 'haml_lint' # to open mails gem 'letter_opener' diff --git a/Gemfile.lock b/Gemfile.lock index de790a77..da8c96e2 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -507,6 +507,8 @@ GEM unicode-display_width (>= 2.4.0, < 3.0) rubocop-ast (1.28.0) parser (>= 3.2.1.0) + rubocop-capybara (2.18.0) + rubocop (~> 1.41) rubocop-rails (2.15.0) activesupport (>= 4.2.0) rack (>= 1.1) @@ -716,6 +718,7 @@ DEPENDENCIES rspec-activemodel-mocks rspec-rails rubocop + rubocop-capybara rubocop-rails rubocop-rspec ruby-oembed From ff52f02fa4e00e9763add6d7dcc111e218e8d2c2 Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:53:15 +0200 Subject: [PATCH 5/6] Introduces rubocop-performance --- .rubocop.yml | 1 + Gemfile | 1 + Gemfile.lock | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/.rubocop.yml b/.rubocop.yml index edb15a05..c8635706 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -2,6 +2,7 @@ require: - rubocop-rspec - rubocop-rails - rubocop-capybara + - rubocop-performance inherit_from: .rubocop_todo.yml diff --git a/Gemfile b/Gemfile index 5879c729..32452659 100644 --- a/Gemfile +++ b/Gemfile @@ -236,6 +236,7 @@ group :development do gem 'rubocop-rspec', require: false gem 'rubocop-rails', require: false gem 'rubocop-capybara', require: false + gem 'rubocop-performance', require: false gem 'haml_lint' # to open mails gem 'letter_opener' diff --git a/Gemfile.lock b/Gemfile.lock index da8c96e2..43f514ba 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -509,6 +509,9 @@ GEM parser (>= 3.2.1.0) rubocop-capybara (2.18.0) rubocop (~> 1.41) + rubocop-performance (1.17.1) + rubocop (>= 1.7.0, < 2.0) + rubocop-ast (>= 0.4.0) rubocop-rails (2.15.0) activesupport (>= 4.2.0) rack (>= 1.1) @@ -719,6 +722,7 @@ DEPENDENCIES rspec-rails rubocop rubocop-capybara + rubocop-performance rubocop-rails rubocop-rspec ruby-oembed From 0c322b2541f924d10bd5f207977ce956aba698ac Mon Sep 17 00:00:00 2001 From: Henne Vogelsang Date: Mon, 8 May 2023 13:54:26 +0200 Subject: [PATCH 6/6] Update rubocop TODO for the new rails, capybara and performance cops. --- .rubocop_todo.yml | 428 +++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 408 insertions(+), 20 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 7ac6e238..bb27ea75 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,12 @@ # This configuration was generated by # `rubocop --auto-gen-config` -# on 2023-05-08 11:46:10 UTC using RuboCop version 1.50.2. +# on 2023-05-08 11:54:05 UTC using RuboCop version 1.50.2. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 2 +# Offense count: 3 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb @@ -14,6 +14,41 @@ Bundler/OrderedGems: Exclude: - 'Gemfile' +# Offense count: 350 +# This cop supports safe autocorrection (--autocorrect). +Capybara/CurrentPathExpectation: + Exclude: + - 'spec/features/base_controller_spec.rb' + - 'spec/features/cfp_ability_spec.rb' + - 'spec/features/conference_registration_spec.rb' + - 'spec/features/info_desk_ability_spec.rb' + - 'spec/features/organization_admin_ability_spec.rb' + - 'spec/features/organizer_ability_spec.rb' + - 'spec/features/proposals_spec.rb' + - 'spec/features/registration_periods_spec.rb' + - 'spec/features/splashpage_spec.rb' + - 'spec/features/ticket_purchases_spec.rb' + - 'spec/features/track_organizer_ability_spec.rb' + - 'spec/features/user_ability_spec.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: have_no, not_to +Capybara/NegationMatcher: + Exclude: + - 'spec/features/versions_spec.rb' + +# Offense count: 82 +# This cop supports safe autocorrection (--autocorrect). +Capybara/SpecificFinders: + Enabled: false + +# Offense count: 1 +Capybara/SpecificMatcher: + Exclude: + - 'spec/features/sponsor_spec.rb' + # Offense count: 1 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: IndentationWidth. @@ -467,12 +502,12 @@ Metrics/BlockNesting: Metrics/ClassLength: Max: 652 -# Offense count: 27 +# Offense count: 26 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/CyclomaticComplexity: Max: 16 -# Offense count: 152 +# Offense count: 151 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns. Metrics/MethodLength: Max: 56 @@ -482,7 +517,7 @@ Metrics/MethodLength: Metrics/ModuleLength: Max: 174 -# Offense count: 24 +# Offense count: 23 # Configuration parameters: AllowedMethods, AllowedPatterns. Metrics/PerceivedComplexity: Max: 19 @@ -538,6 +573,32 @@ Naming/VariableNumber: - 'spec/models/payment_spec.rb' - 'spec/models/ticket_purchase_spec.rb' +# Offense count: 1 +# Configuration parameters: MinSize. +Performance/CollectionLiteralInLoop: + Exclude: + - 'app/models/conference.rb' + +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/InefficientHashSearch: + Exclude: + - 'app/controllers/admin/versions_controller.rb' + - 'app/helpers/versions_helper.rb' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/MapCompact: + Exclude: + - 'app/datatables/registration_datatable.rb' + - 'lib/tasks/events_registrations.rake' + +# Offense count: 2 +# This cop supports unsafe autocorrection (--autocorrect-all). +Performance/StringInclude: + Exclude: + - 'app/models/commercial.rb' + # Offense count: 28 RSpec/AnyInstance: Exclude: @@ -907,6 +968,343 @@ RSpec/VoidExpect: Exclude: - 'spec/models/conference_spec.rb' +# Offense count: 4 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ActiveRecordAliases: + Exclude: + - 'db/migrate/20141104131625_generate_username.rb' + - 'db/migrate/20141117214230_move_banner_description_to_conference.rb' + - 'db/migrate/20141118153918_change_venue_conference_association.rb' + - 'db/migrate/20141118162030_change_lodging_association_to_conference.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/ActiveRecordCallbacksOrder: + Exclude: + - 'app/models/event.rb' + - 'app/models/track.rb' + - 'app/models/venue.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ApplicationController: + Exclude: + - 'app/controllers/api/base_controller.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ApplicationMailer: + Exclude: + - 'app/mailers/mailbot.rb' + +# Offense count: 129 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/ApplicationRecord: + Enabled: false + +# Offense count: 10 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. +Rails/Blank: + Exclude: + - 'app/controllers/conferences_controller.rb' + - 'app/controllers/users/omniauth_callbacks_controller.rb' + - 'app/models/program.rb' + - 'app/models/user.rb' + - 'spec/factories/event_schedule.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/CompactBlank: + Exclude: + - 'app/controllers/surveys_controller.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Rails/ContentTag: + Exclude: + - 'app/helpers/application_helper.rb' + +# Offense count: 20 +# Configuration parameters: Include. +# Include: db/migrate/*.rb +Rails/CreateTableWithTimestamps: + Enabled: false + +# Offense count: 103 +# Configuration parameters: EnforcedStyle, AllowToTime. +# SupportedStyles: strict, flexible +Rails/Date: + Enabled: false + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforceForPrefixed. +Rails/Delegate: + Exclude: + - 'app/models/event.rb' + - 'app/models/room.rb' + - 'app/models/track.rb' + +# Offense count: 4 +# This cop supports safe autocorrection (--autocorrect). +Rails/DuplicateAssociation: + Exclude: + - 'app/models/program.rb' + - 'app/models/user.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +Rails/DurationArithmetic: + Exclude: + - 'spec/models/program_spec.rb' + - 'spec/models/user_spec.rb' + +# Offense count: 3 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Whitelist, AllowedMethods, AllowedReceivers. +# Whitelist: find_by_sql +# AllowedMethods: find_by_sql +# AllowedReceivers: Gem::Specification +Rails/DynamicFindBy: + Exclude: + - 'app/controllers/admin/events_controller.rb' + - 'db/migrate/20140701123203_add_events_per_week_to_conference.rb' + +# Offense count: 5 +# This cop supports safe autocorrection (--autocorrect). +Rails/EagerEvaluationLogMessage: + Exclude: + - 'app/controllers/admin/events_controller.rb' + - 'app/controllers/application_controller.rb' + - 'app/controllers/proposals_controller.rb' + - 'app/models/event.rb' + +# Offense count: 3 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/EnumHash: + Exclude: + - 'app/models/conference.rb' + - 'app/models/survey.rb' + - 'app/models/survey_question.rb' + +# Offense count: 7 +# Configuration parameters: EnforcedStyle. +# SupportedStyles: slashes, arguments +Rails/FilePath: + Exclude: + - 'app/pdfs/ticket_pdf.rb' + - 'config/initializers/carrierwave.rb' + - 'lib/tasks/migrate_config.rake' + - 'spec/features/lodgings_spec.rb' + - 'spec/features/sponsor_spec.rb' + - 'spec/support/deprecation_shitlist.rb' + +# Offense count: 6 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasAndBelongsToMany: + Exclude: + - 'app/models/conference.rb' + - 'app/models/qanswer.rb' + - 'app/models/question.rb' + - 'app/models/registration.rb' + - 'app/models/vchoice.rb' + +# Offense count: 24 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/HasManyOrHasOneDependent: + Enabled: false + +# Offense count: 5 +# Configuration parameters: Include. +# Include: app/helpers/**/*.rb +Rails/HelperInstanceVariable: + Exclude: + - 'app/helpers/application_helper.rb' + - 'app/helpers/events_helper.rb' + - 'app/helpers/format_helper.rb' + +# Offense count: 8 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: numeric, symbolic +Rails/HttpStatus: + Exclude: + - 'app/controllers/admin/commercials_controller.rb' + - 'app/controllers/admin/event_schedules_controller.rb' + - 'app/controllers/admin/programs_controller.rb' + - 'app/controllers/admin/tracks_controller.rb' + - 'app/controllers/admin/venue_commercials_controller.rb' + - 'app/controllers/commercials_controller.rb' + +# Offense count: 99 +Rails/I18nLocaleTexts: + Enabled: false + +# Offense count: 7 +# Configuration parameters: IgnoreScopes, Include. +# Include: app/models/**/*.rb +Rails/InverseOf: + Exclude: + - 'app/models/booth.rb' + - 'app/models/conference.rb' + - 'app/models/event.rb' + - 'app/models/user.rb' + +# Offense count: 1 +# Configuration parameters: Include. +# Include: app/controllers/**/*.rb, app/mailers/**/*.rb +Rails/LexicallyScopedActionFilter: + Exclude: + - 'app/controllers/registrations_controller.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Rails/LinkToBlank: + Exclude: + - 'app/helpers/format_helper.rb' + +# Offense count: 1 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Include. +# Include: app/mailers/**/*.rb +Rails/MailerName: + Exclude: + - 'app/mailers/mailbot.rb' + +# Offense count: 3 +Rails/OutputSafety: + Exclude: + - 'app/helpers/events_helper.rb' + - 'app/models/commercial.rb' + +# Offense count: 6 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: conservative, aggressive +Rails/PluckInWhere: + Exclude: + - 'app/models/ability.rb' + - 'app/models/admin_ability.rb' + +# Offense count: 16 +# This cop supports safe autocorrection (--autocorrect). +Rails/PluralizationGrammar: + Exclude: + - 'spec/models/conference_spec.rb' + +# Offense count: 2 +# This cop supports safe autocorrection (--autocorrect). +Rails/Presence: + Exclude: + - 'app/controllers/schedules_controller.rb' + - 'app/models/user.rb' + +# Offense count: 15 +# This cop supports safe autocorrection (--autocorrect). +# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. +Rails/Present: + Exclude: + - 'app/models/cfp.rb' + - 'app/models/email_settings.rb' + - 'app/models/event.rb' + - 'app/models/program.rb' + - 'app/models/venue.rb' + +# Offense count: 6 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: Include. +# Include: **/Rakefile, **/*.rake +Rails/RakeEnvironment: + Exclude: + - 'lib/tasks/dump_db.rake' + - 'lib/tasks/spec.rake' + +# Offense count: 21 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/RedundantPresenceValidationOnBelongsTo: + Enabled: false + +# Offense count: 2 +Rails/RenderInline: + Exclude: + - 'app/controllers/conferences_controller.rb' + - 'app/controllers/schedules_controller.rb' + +# Offense count: 4 +# Configuration parameters: Include. +# Include: db/**/*.rb +Rails/ReversibleMigration: + Exclude: + - 'db/migrate/20170108053041_add_default_to_revision_in_conference.rb' + - 'db/migrate/20170715131706_make_track_state_not_null_and_add_default_value.rb' + - 'db/migrate/20170720134353_make_track_cfp_active_not_null.rb' + - 'db/migrate/20171118113113_change_visit_id_type_of_ahoy_events_to_integer.rb' + +# Offense count: 48 +# Configuration parameters: ForbiddenMethods, AllowedMethods. +# ForbiddenMethods: decrement!, decrement_counter, increment!, increment_counter, insert, insert!, insert_all, insert_all!, toggle!, touch, touch_all, update_all, update_attribute, update_column, update_columns, update_counters, upsert, upsert_all +Rails/SkipsModelValidations: + Enabled: false + +# Offense count: 40 +# This cop supports unsafe autocorrection (--autocorrect-all). +# Configuration parameters: EnforcedStyle. +# SupportedStyles: strict, flexible +Rails/TimeZone: + Exclude: + - 'app/models/comment.rb' + - 'app/models/conference.rb' + - 'config/environments/test.rb' + - 'db/migrate/20180226032958_add_created_at_and_updated_at_to_event_types.rb' + - 'db/migrate/20180313012253_add_timestamps_to_tickets.rb' + - 'lib/tasks/dump_db.rake' + - 'spec/controllers/admin/comments_controller_spec.rb' + - 'spec/factories/users.rb' + - 'spec/models/conference_spec.rb' + +# Offense count: 13 +# Configuration parameters: Include. +# Include: app/models/**/*.rb +Rails/UniqueValidationWithoutIndex: + Exclude: + - 'app/models/booth.rb' + - 'app/models/cfp.rb' + - 'app/models/commercial.rb' + - 'app/models/conference.rb' + - 'app/models/events_registration.rb' + - 'app/models/organization.rb' + - 'app/models/registration.rb' + - 'app/models/role.rb' + - 'app/models/subscription.rb' + - 'app/models/survey_reply.rb' + - 'app/models/survey_submission.rb' + - 'app/models/track.rb' + - 'app/models/vote.rb' + +# Offense count: 17 +# This cop supports unsafe autocorrection (--autocorrect-all). +Rails/WhereEquals: + Exclude: + - 'app/controllers/admin/registrations_controller.rb' + - 'app/models/admin_ability.rb' + - 'app/models/conference.rb' + - 'app/models/event_schedule.rb' + - 'app/models/program.rb' + - 'app/models/user.rb' + +# Offense count: 1 +# This cop supports safe autocorrection (--autocorrect). +Rails/WhereNot: + Exclude: + - 'db/migrate/20140820093735_migrating_supporter_registrations_to_ticket_users.rb' + # Offense count: 3 Security/Open: Exclude: @@ -1002,15 +1400,13 @@ Style/Encoding: - 'app/uploaders/picture_uploader.rb' - 'spec/models/conference_spec.rb' -# Offense count: 3 +# Offense count: 1 # This cop supports safe autocorrection (--autocorrect). Style/ExpandPathArguments: Exclude: - - 'bin/bundle' - - 'bin/rspec' - 'spec/spec_helper.rb' -# Offense count: 39 +# Offense count: 36 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: EnforcedStyle. # SupportedStyles: always, always_true, never @@ -1068,7 +1464,7 @@ Style/HashTransformValues: - 'app/controllers/admin/comments_controller.rb' - 'app/helpers/chart_helper.rb' -# Offense count: 60 +# Offense count: 58 # This cop supports safe autocorrection (--autocorrect). Style/IfUnlessModifier: Enabled: false @@ -1345,27 +1741,19 @@ Style/SoleNestedConditional: - 'db/migrate/20140801170430_move_event_media_to_commercial.rb' - 'db/migrate/20151018152439_create_programs_table.rb' -# Offense count: 1 -# This cop supports unsafe autocorrection (--autocorrect-all). -# Configuration parameters: RequireEnglish. -# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names -Style/SpecialGlobalVars: - EnforcedStyle: use_perl_names - # Offense count: 28 # This cop supports unsafe autocorrection (--autocorrect-all). # Configuration parameters: Mode. Style/StringConcatenation: Enabled: false -# Offense count: 25 +# Offense count: 17 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Exclude: - 'Gemfile' - - 'bin/rspec' - 'config/deploy.rb' - 'config/environments/production.rb' - 'config/puma.rb' @@ -1432,7 +1820,7 @@ Style/WordArray: EnforcedStyle: percent MinSize: 6 -# Offense count: 526 +# Offense count: 524 # This cop supports safe autocorrection (--autocorrect). # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns. # URISchemes: http, https