gunghogeoduck/osem-fcy
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Rebuild rubocop TODOs after auto-correcting

Browse source
This commit is contained in:
James Mason 2018-04-04 10:18:51 -07:00
parent 31c50255e9
commit 84dbb52d11
No known key found for this signature in database
GPG key ID: 1B3951886C449023
580 changed files with 3689 additions and 3133 deletions
Download patch file Download diff file Expand all files Collapse all files

40
spec/controllers/admin/roles_controller_spec.rb
View file

@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'spec_helper'
describe Admin::RolesController do
@ -12,7 +14,7 @@ describe Admin::RolesController do
describe 'GET #index' do
before :each do
sign_in(admin)
get :index, conference_id: conference.short_title
get :index, params: { conference_id: conference.short_title }
end
it 'assigns default value to selection variable' do
@ -43,9 +45,7 @@ describe Admin::RolesController do
describe 'PATCH #update' do
before :each do
sign_in admin
patch :update, conference_id: conference.short_title,
id: 'cfp',
role: { description: 'New description for cfp role!' }
patch :update, params: { conference_id: conference.short_title, id: 'cfp', role: { description: 'New description for cfp role!' } }
end
it 'changes the description of the role' do
@ -56,9 +56,7 @@ describe Admin::RolesController do
describe 'POST #toggle' do
before :each do
sign_in admin
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user1@osem.io' },
id: 'cfp'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user1@osem.io' }, id: 'cfp' }
end
context 'assigns correct values to variables' do
@ -77,17 +75,13 @@ describe Admin::RolesController do
context 'adds role to user' do
it 'adds second user' do
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user2@osem.io' },
id: 'cfp'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user2@osem.io' }, id: 'cfp' }
expect(user2.roles).to eq [cfp_role]
end
it 'assigns second role to user' do
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user1@osem.io' },
id: 'organizer'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user1@osem.io' }, id: 'organizer' }
expect(user1.roles).to eq [organizer_role, cfp_role]
end
@ -95,23 +89,17 @@ describe Admin::RolesController do
context 'removes role from user' do
it 'removes role from user' do
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user1@osem.io', state: 'false' },
id: 'cfp'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user1@osem.io', state: 'false' }, id: 'cfp' }
expect(user1.roles).to eq []
end
it 'removes second role from user' do
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user1@osem.io' },
id: 'organizer'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user1@osem.io' }, id: 'organizer' }
expect(user1.roles).to eq [organizer_role, cfp_role]
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user1@osem.io', state: 'false' },
id: 'cfp'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user1@osem.io', state: 'false' }, id: 'cfp' }
user1.reload
expect(user1.roles).to eq [organizer_role]
@ -120,15 +108,11 @@ describe Admin::RolesController do
it 'does not remove role if user is the last organizer' do
# Add role organizer
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user1@osem.io', state: 'true' },
id: 'organizer'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user1@osem.io', state: 'true' }, id: 'organizer' }
expect(organizer_role.users).to eq [user1]
# Try to remove role organizer, when there is only 1 user as organizer
post :toggle_user, conference_id: conference.short_title,
user: { email: 'user1@osem.io', state: 'false' },
id: 'organizer'
post :toggle_user, params: { conference_id: conference.short_title, user: { email: 'user1@osem.io', state: 'false' }, id: 'organizer' }
expect(organizer_role.users).to eq [user1]
end
end